[INFO] updating cached repository tmikus/rlox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tmikus/rlox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tmikus/rlox" "work/ex/clippy-test-run/sources/stable/gh/tmikus/rlox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tmikus/rlox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tmikus/rlox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmikus/rlox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmikus/rlox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ab1dde3b5ee3559c4d83f66a58f08343f21c4d98 [INFO] sha for GitHub repo tmikus/rlox: ab1dde3b5ee3559c4d83f66a58f08343f21c4d98 [INFO] validating manifest of tmikus/rlox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tmikus/rlox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tmikus/rlox [INFO] finished frobbing tmikus/rlox [INFO] frobbed toml for tmikus/rlox written to work/ex/clippy-test-run/sources/stable/gh/tmikus/rlox/Cargo.toml [INFO] started frobbing tmikus/rlox [INFO] finished frobbing tmikus/rlox [INFO] frobbed toml for tmikus/rlox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmikus/rlox/Cargo.toml [INFO] crate tmikus/rlox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tmikus/rlox against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tmikus/rlox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa27c7dbdea84c5a7dfc94b18505d304b517d8a921091679f0cde08402b5b8ac [INFO] running `"docker" "start" "-a" "aa27c7dbdea84c5a7dfc94b18505d304b517d8a921091679f0cde08402b5b8ac"` [INFO] [stderr] Checking rlox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | token_type: token_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | lexeme: lexeme, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lexeme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | literal: literal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `literal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | token_type: token_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | lexeme: lexeme, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lexeme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | literal: literal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `literal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ptr::null` [INFO] [stderr] --> src/scanner.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ptr::null; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Debug` [INFO] [stderr] --> src/token_type.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt::Debug; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ptr::null` [INFO] [stderr] --> src/scanner.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ptr::null; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Debug` [INFO] [stderr] --> src/token_type.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt::Debug; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `IDENTIFIER` [INFO] [stderr] --> src/token_type.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | IDENTIFIER, STRING, NUMBER, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AND` [INFO] [stderr] --> src/token_type.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CLASS` [INFO] [stderr] --> src/token_type.rs:19:8 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ELSE` [INFO] [stderr] --> src/token_type.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FALSE` [INFO] [stderr] --> src/token_type.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FUN` [INFO] [stderr] --> src/token_type.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FOR` [INFO] [stderr] --> src/token_type.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `IF` [INFO] [stderr] --> src/token_type.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NIL` [INFO] [stderr] --> src/token_type.rs:19:42 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `OR` [INFO] [stderr] --> src/token_type.rs:19:47 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PRINT` [INFO] [stderr] --> src/token_type.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RETURN` [INFO] [stderr] --> src/token_type.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SUPER` [INFO] [stderr] --> src/token_type.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `THIS` [INFO] [stderr] --> src/token_type.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TRUE` [INFO] [stderr] --> src/token_type.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VAR` [INFO] [stderr] --> src/token_type.rs:20:37 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `WHILE` [INFO] [stderr] --> src/token_type.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `line` [INFO] [stderr] --> src/token.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | line: i32, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `IDENTIFIER` [INFO] [stderr] --> src/token_type.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | IDENTIFIER, STRING, NUMBER, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AND` [INFO] [stderr] --> src/token_type.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CLASS` [INFO] [stderr] --> src/token_type.rs:19:8 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ELSE` [INFO] [stderr] --> src/token_type.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FALSE` [INFO] [stderr] --> src/token_type.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FUN` [INFO] [stderr] --> src/token_type.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FOR` [INFO] [stderr] --> src/token_type.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `IF` [INFO] [stderr] --> src/token_type.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NIL` [INFO] [stderr] --> src/token_type.rs:19:42 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `OR` [INFO] [stderr] --> src/token_type.rs:19:47 [INFO] [stderr] | [INFO] [stderr] 19 | AND, CLASS, ELSE, FALSE, FUN, FOR, IF, NIL, OR, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PRINT` [INFO] [stderr] --> src/token_type.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RETURN` [INFO] [stderr] --> src/token_type.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SUPER` [INFO] [stderr] --> src/token_type.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `THIS` [INFO] [stderr] --> src/token_type.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TRUE` [INFO] [stderr] --> src/token_type.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VAR` [INFO] [stderr] --> src/token_type.rs:20:37 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `WHILE` [INFO] [stderr] --> src/token_type.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | PRINT, RETURN, SUPER, THIS, TRUE, VAR, WHILE, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `line` [INFO] [stderr] --> src/token.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | line: i32, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `LEFT_PAREN` should have a camel case name such as `LeftParen` [INFO] [stderr] --> src/token_type.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | LEFT_PAREN, RIGHT_PAREN, LEFT_BRACE, RIGHT_BRACE, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `RIGHT_PAREN` should have a camel case name such as `RightParen` [INFO] [stderr] --> src/token_type.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | LEFT_PAREN, RIGHT_PAREN, LEFT_BRACE, RIGHT_BRACE, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `LEFT_BRACE` should have a camel case name such as `LeftBrace` [INFO] [stderr] --> src/token_type.rs:6:28 [INFO] [stderr] | [INFO] [stderr] 6 | LEFT_PAREN, RIGHT_PAREN, LEFT_BRACE, RIGHT_BRACE, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `RIGHT_BRACE` should have a camel case name such as `RightBrace` [INFO] [stderr] --> src/token_type.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | LEFT_PAREN, RIGHT_PAREN, LEFT_BRACE, RIGHT_BRACE, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `BANG_EQUAL` should have a camel case name such as `BangEqual` [INFO] [stderr] --> src/token_type.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | BANG, BANG_EQUAL, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `EQUAL_EQUAL` should have a camel case name such as `EqualEqual` [INFO] [stderr] --> src/token_type.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | EQUAL, EQUAL_EQUAL, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `GREATER_EQUAL` should have a camel case name such as `GreaterEqual` [INFO] [stderr] --> src/token_type.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | GREATER, GREATER_EQUAL, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `LESS_EQUAL` should have a camel case name such as `LessEqual` [INFO] [stderr] --> src/token_type.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | LESS, LESS_EQUAL, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/token.rs:43:11 [INFO] [stderr] | [INFO] [stderr] 43 | lexeme: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | fn run_file(path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variant `LEFT_PAREN` should have a camel case name such as `LeftParen` [INFO] [stderr] --> src/token_type.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | LEFT_PAREN, RIGHT_PAREN, LEFT_BRACE, RIGHT_BRACE, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `RIGHT_PAREN` should have a camel case name such as `RightParen` [INFO] [stderr] --> src/token_type.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | LEFT_PAREN, RIGHT_PAREN, LEFT_BRACE, RIGHT_BRACE, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `LEFT_BRACE` should have a camel case name such as `LeftBrace` [INFO] [stderr] --> src/token_type.rs:6:28 [INFO] [stderr] | [INFO] [stderr] 6 | LEFT_PAREN, RIGHT_PAREN, LEFT_BRACE, RIGHT_BRACE, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `RIGHT_BRACE` should have a camel case name such as `RightBrace` [INFO] [stderr] --> src/token_type.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | LEFT_PAREN, RIGHT_PAREN, LEFT_BRACE, RIGHT_BRACE, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `BANG_EQUAL` should have a camel case name such as `BangEqual` [INFO] [stderr] --> src/token_type.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | BANG, BANG_EQUAL, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `EQUAL_EQUAL` should have a camel case name such as `EqualEqual` [INFO] [stderr] --> src/token_type.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | EQUAL, EQUAL_EQUAL, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `GREATER_EQUAL` should have a camel case name such as `GreaterEqual` [INFO] [stderr] --> src/token_type.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | GREATER, GREATER_EQUAL, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `LESS_EQUAL` should have a camel case name such as `LessEqual` [INFO] [stderr] --> src/token_type.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | LESS, LESS_EQUAL, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | / match file.read_to_string(&mut source) { [INFO] [stderr] 38 | | Err(why) => panic!("Couldn't read {}: {}", file_path.display(), why.description()), [INFO] [stderr] 39 | | Ok(_) => {}, [INFO] [stderr] 40 | | } [INFO] [stderr] | |___^ help: try this: `if let Err(why) = file.read_to_string(&mut source) { panic!("Couldn't read {}: {}", file_path.display(), why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/token.rs:43:11 [INFO] [stderr] | [INFO] [stderr] 43 | lexeme: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | fn run_file(path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | / match file.read_to_string(&mut source) { [INFO] [stderr] 38 | | Err(why) => panic!("Couldn't read {}: {}", file_path.display(), why.description()), [INFO] [stderr] 39 | | Ok(_) => {}, [INFO] [stderr] 40 | | } [INFO] [stderr] | |___^ help: try this: `if let Err(why) = file.read_to_string(&mut source) { panic!("Couldn't read {}: {}", file_path.display(), why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.55s [INFO] running `"docker" "inspect" "aa27c7dbdea84c5a7dfc94b18505d304b517d8a921091679f0cde08402b5b8ac"` [INFO] running `"docker" "rm" "-f" "aa27c7dbdea84c5a7dfc94b18505d304b517d8a921091679f0cde08402b5b8ac"` [INFO] [stdout] aa27c7dbdea84c5a7dfc94b18505d304b517d8a921091679f0cde08402b5b8ac