[INFO] updating cached repository tlrobrn/gol-with-display [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tlrobrn/gol-with-display [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tlrobrn/gol-with-display" "work/ex/clippy-test-run/sources/stable/gh/tlrobrn/gol-with-display"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tlrobrn/gol-with-display'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tlrobrn/gol-with-display" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tlrobrn/gol-with-display"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tlrobrn/gol-with-display'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f09308f1580dfdeb940012e57386dd91394c22a9 [INFO] sha for GitHub repo tlrobrn/gol-with-display: f09308f1580dfdeb940012e57386dd91394c22a9 [INFO] validating manifest of tlrobrn/gol-with-display on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tlrobrn/gol-with-display on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tlrobrn/gol-with-display [INFO] finished frobbing tlrobrn/gol-with-display [INFO] frobbed toml for tlrobrn/gol-with-display written to work/ex/clippy-test-run/sources/stable/gh/tlrobrn/gol-with-display/Cargo.toml [INFO] started frobbing tlrobrn/gol-with-display [INFO] finished frobbing tlrobrn/gol-with-display [INFO] frobbed toml for tlrobrn/gol-with-display written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tlrobrn/gol-with-display/Cargo.toml [INFO] crate tlrobrn/gol-with-display has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tlrobrn/gol-with-display against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tlrobrn/gol-with-display:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f660a01c9504b04374a16dffc60d43b9733e53c2bfc00328a8c019949a3889bb [INFO] running `"docker" "start" "-a" "f660a01c9504b04374a16dffc60d43b9733e53c2bfc00328a8c019949a3889bb"` [INFO] [stderr] Compiling rayon-core v1.0.0 [INFO] [stderr] Compiling either v1.1.0 [INFO] [stderr] Checking deque v0.3.2 [INFO] [stderr] Checking odds v0.2.25 [INFO] [stderr] Checking log v0.3.7 [INFO] [stderr] Checking shader_version v0.2.2 [INFO] [stderr] Checking linked-hash-map v0.0.10 [INFO] [stderr] Checking piston-texture v0.5.0 [INFO] [stderr] Checking read_color v0.1.0 [INFO] [stderr] Checking num_cpus v1.4.0 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking draw_state v0.7.0 [INFO] [stderr] Checking vecmath v0.3.0 [INFO] [stderr] Checking deflate v0.7.11 [INFO] [stderr] Checking gif v0.9.1 [INFO] [stderr] Checking stb_truetype v0.2.1 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking pistoncore-input v0.18.0 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Checking nodrop v0.1.9 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking piston2d-graphics v0.21.1 [INFO] [stderr] Checking arrayvec v0.3.23 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking rayon v0.7.0 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking pistoncore-window v0.27.0 [INFO] [stderr] Checking pistoncore-event_loop v0.32.0 [INFO] [stderr] Checking piston v0.32.0 [INFO] [stderr] Checking jpeg-decoder v0.1.12 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking gfx_core v0.7.1 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking piston2d-opengl_graphics v0.43.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.36.0 [INFO] [stderr] Checking gfx v0.15.1 [INFO] [stderr] Checking gfx_device_gl v0.14.0 [INFO] [stderr] Checking piston-gfx_texture v0.23.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.39.0 [INFO] [stderr] Checking piston_window v0.65.0 [INFO] [stderr] Checking gol v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | point_width: point_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `point_width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | window_width: window_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | window_height: window_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | point_width: point_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `point_width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | window_width: window_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | window_height: window_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cursor` [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | cursor: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | x: (window_width as f64 / point_width) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | y: (window_height as f64 / point_width) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:129:32 [INFO] [stderr] | [INFO] [stderr] 129 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | x: (self.window_width as f64 / (2.0 * self.point_width)) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | y: (self.window_height as f64 / (2.0 * self.point_width)) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cursor` [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | cursor: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | x: (window_width as f64 / point_width) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | y: (window_height as f64 / point_width) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:129:32 [INFO] [stderr] | [INFO] [stderr] 129 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | x: (self.window_width as f64 / (2.0 * self.point_width)) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | y: (self.window_height as f64 / (2.0 * self.point_width)) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 17s [INFO] running `"docker" "inspect" "f660a01c9504b04374a16dffc60d43b9733e53c2bfc00328a8c019949a3889bb"` [INFO] running `"docker" "rm" "-f" "f660a01c9504b04374a16dffc60d43b9733e53c2bfc00328a8c019949a3889bb"` [INFO] [stdout] f660a01c9504b04374a16dffc60d43b9733e53c2bfc00328a8c019949a3889bb