[INFO] updating cached repository tkadur/Rustmoku
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tkadur/Rustmoku
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tkadur/Rustmoku" "work/ex/clippy-test-run/sources/stable/gh/tkadur/Rustmoku"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tkadur/Rustmoku'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tkadur/Rustmoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tkadur/Rustmoku"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tkadur/Rustmoku'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 17176cb5471bbe0e8d8f2caed39e2a2e7057ec07
[INFO] sha for GitHub repo tkadur/Rustmoku: 17176cb5471bbe0e8d8f2caed39e2a2e7057ec07
[INFO] validating manifest of tkadur/Rustmoku on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tkadur/Rustmoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tkadur/Rustmoku
[INFO] finished frobbing tkadur/Rustmoku
[INFO] frobbed toml for tkadur/Rustmoku written to work/ex/clippy-test-run/sources/stable/gh/tkadur/Rustmoku/Cargo.toml
[INFO] started frobbing tkadur/Rustmoku
[INFO] finished frobbing tkadur/Rustmoku
[INFO] frobbed toml for tkadur/Rustmoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tkadur/Rustmoku/Cargo.toml
[INFO] crate tkadur/Rustmoku has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tkadur/Rustmoku against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tkadur/Rustmoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] db1605ac03740540cae82411d1187c135240333d17e3b7be780925d923e52b85
[INFO] running `"docker" "start" "-a" "db1605ac03740540cae82411d1187c135240333d17e3b7be780925d923e52b85"`
[INFO] [stderr]    Compiling matrixmultiply v0.1.13
[INFO] [stderr]    Compiling ndarray v0.10.3
[INFO] [stderr]     Checking num_cpus v1.6.2
[INFO] [stderr]     Checking itertools v0.6.1
[INFO] [stderr]     Checking num-complex v0.1.40
[INFO] [stderr]     Checking rayon-core v1.2.1
[INFO] [stderr]     Checking rayon v0.8.2
[INFO] [stderr]     Checking gomoku_ai v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/game/game.rs:184:14
[INFO] [stderr]     |
[INFO] [stderr] 184 |         let (l, u): (isize, isize) = (0, self.size as isize);
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/game/game.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |         let (l, u): (isize, isize) = (0, self.size as isize);
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/game/game.rs:184:14
[INFO] [stderr]     |
[INFO] [stderr] 184 |         let (l, u): (isize, isize) = (0, self.size as isize);
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/game/game.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |         let (l, u): (isize, isize) = (0, self.size as isize);
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/game/mod.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub mod game;
[INFO] [stderr]   | ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/game/mod.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub mod game;
[INFO] [stderr]   | ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game/game.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 |         return Game::board_to_string(&self.board);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Game::board_to_string(&self.board)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game/game.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 |         return Game::board_to_string(&self.board);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Game::board_to_string(&self.board)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/game/game.rs:147:5
[INFO] [stderr]     |
[INFO] [stderr] 147 | /     pub fn board<'a>(&'a self) -> &'a Board {
[INFO] [stderr] 148 | |         &self.board
[INFO] [stderr] 149 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/game/game.rs:277:9
[INFO] [stderr]     |
[INFO] [stderr] 277 | /         b.iter()
[INFO] [stderr] 278 | |          .filter(|p| p.is_none())
[INFO] [stderr] 279 | |          .collect::<Vec<_>>()
[INFO] [stderr] 280 | |          .len() == 0
[INFO] [stderr]     | |____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] help: using `is_empty` is clearer and more explicit
[INFO] [stderr]     |
[INFO] [stderr] 277 |         b.iter()
[INFO] [stderr] 278 |          .filter(|p| p.is_none())
[INFO] [stderr] 279 |          .collect::<Vec<_>>().is_empty()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]    --> src/game/game.rs:279:10
[INFO] [stderr]     |
[INFO] [stderr] 279 | /          .collect::<Vec<_>>()
[INFO] [stderr] 280 | |          .len() == 0
[INFO] [stderr]     | |_______________^ help: replace with: `.count()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/game/game.rs:298:20
[INFO] [stderr]     |
[INFO] [stderr] 298 |                 if !elem.is_none() && Game::square_eq(elem, last.0) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elem.is_some() && Game::square_eq(elem, last.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/ai/search/alphabeta.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 | /         let cmp: fn((Bound, Option<Pos>), (Bound, Option<Pos>)) -> (Bound, Option<Pos>);
[INFO] [stderr] 92 | |
[INFO] [stderr] 93 | |         if game.player() == MAXIE {
[INFO] [stderr] 94 | |             v = (NegInf, None);
[INFO] [stderr] ...  |
[INFO] [stderr] 98 | |             cmp = min::<(Bound, Option<Pos>)>;
[INFO] [stderr] 99 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let cmp = if game.player() == MAXIE { ..; max::<(Bound, Option<Pos>)> } else { ..; min::<(Bound, Option<Pos>)> };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/ai/search/alphabeta.rs:91:18
[INFO] [stderr]    |
[INFO] [stderr] 91 |         let cmp: fn((Bound, Option<Pos>), (Bound, Option<Pos>)) -> (Bound, Option<Pos>);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/game/game.rs:147:5
[INFO] [stderr]     |
[INFO] [stderr] 147 | /     pub fn board<'a>(&'a self) -> &'a Board {
[INFO] [stderr] 148 | |         &self.board
[INFO] [stderr] 149 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/game/game.rs:277:9
[INFO] [stderr]     |
[INFO] [stderr] 277 | /         b.iter()
[INFO] [stderr] 278 | |          .filter(|p| p.is_none())
[INFO] [stderr] 279 | |          .collect::<Vec<_>>()
[INFO] [stderr] 280 | |          .len() == 0
[INFO] [stderr]     | |____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] help: using `is_empty` is clearer and more explicit
[INFO] [stderr]     |
[INFO] [stderr] 277 |         b.iter()
[INFO] [stderr] 278 |          .filter(|p| p.is_none())
[INFO] [stderr] 279 |          .collect::<Vec<_>>().is_empty()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]    --> src/game/game.rs:279:10
[INFO] [stderr]     |
[INFO] [stderr] 279 | /          .collect::<Vec<_>>()
[INFO] [stderr] 280 | |          .len() == 0
[INFO] [stderr]     | |_______________^ help: replace with: `.count()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/game/game.rs:298:20
[INFO] [stderr]     |
[INFO] [stderr] 298 |                 if !elem.is_none() && Game::square_eq(elem, last.0) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elem.is_some() && Game::square_eq(elem, last.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/ai/search/alphabeta.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 | /         let cmp: fn((Bound, Option<Pos>), (Bound, Option<Pos>)) -> (Bound, Option<Pos>);
[INFO] [stderr] 92 | |
[INFO] [stderr] 93 | |         if game.player() == MAXIE {
[INFO] [stderr] 94 | |             v = (NegInf, None);
[INFO] [stderr] ...  |
[INFO] [stderr] 98 | |             cmp = min::<(Bound, Option<Pos>)>;
[INFO] [stderr] 99 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let cmp = if game.player() == MAXIE { ..; max::<(Bound, Option<Pos>)> } else { ..; min::<(Bound, Option<Pos>)> };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/ai/search/alphabeta.rs:91:18
[INFO] [stderr]    |
[INFO] [stderr] 91 |         let cmp: fn((Bound, Option<Pos>), (Bound, Option<Pos>)) -> (Bound, Option<Pos>);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 14.36s
[INFO] running `"docker" "inspect" "db1605ac03740540cae82411d1187c135240333d17e3b7be780925d923e52b85"`
[INFO] running `"docker" "rm" "-f" "db1605ac03740540cae82411d1187c135240333d17e3b7be780925d923e52b85"`
[INFO] [stdout] db1605ac03740540cae82411d1187c135240333d17e3b7be780925d923e52b85