[INFO] updating cached repository tjpalmer/pratt-parser
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tjpalmer/pratt-parser
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tjpalmer/pratt-parser" "work/ex/clippy-test-run/sources/stable/gh/tjpalmer/pratt-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tjpalmer/pratt-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tjpalmer/pratt-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tjpalmer/pratt-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tjpalmer/pratt-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e293fb6bdd30d3bae39c7046ea5e0b49fcc7505c
[INFO] sha for GitHub repo tjpalmer/pratt-parser: e293fb6bdd30d3bae39c7046ea5e0b49fcc7505c
[INFO] validating manifest of tjpalmer/pratt-parser on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tjpalmer/pratt-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tjpalmer/pratt-parser
[INFO] finished frobbing tjpalmer/pratt-parser
[INFO] frobbed toml for tjpalmer/pratt-parser written to work/ex/clippy-test-run/sources/stable/gh/tjpalmer/pratt-parser/Cargo.toml
[INFO] started frobbing tjpalmer/pratt-parser
[INFO] finished frobbing tjpalmer/pratt-parser
[INFO] frobbed toml for tjpalmer/pratt-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tjpalmer/pratt-parser/Cargo.toml
[INFO] crate tjpalmer/pratt-parser has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tjpalmer/pratt-parser against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tjpalmer/pratt-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0b0410e143ae0ced018065d41a49c1a00ae632914b49c3fa88bb23cb5d294f3f
[INFO] running `"docker" "start" "-a" "0b0410e143ae0ced018065d41a49c1a00ae632914b49c3fa88bb23cb5d294f3f"`
[INFO] [stderr]     Checking pratt-parser-example v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `super::tokenizer::Tokenizer`
[INFO] [stderr]  --> src/parser.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use super::tokenizer::Tokenizer;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/tokenizer.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 | /         loop {
[INFO] [stderr] 36 | |             match it.peek() {
[INFO] [stderr] 37 | |                 Some(&ch) => match ch {
[INFO] [stderr] 38 | |                     '0' ... '9' => {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |             }
[INFO] [stderr] 65 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(&ch) = it.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     match symbol {
[INFO] [stderr] 24 | |         &Symbol::Add | &Symbol::Subtract => 10,
[INFO] [stderr] 25 | |         &Symbol::Multiply | &Symbol::Divide => 20,
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |     match *symbol {
[INFO] [stderr] 24 |         Symbol::Add | Symbol::Subtract => 10,
[INFO] [stderr] 25 |         Symbol::Multiply | Symbol::Divide => 20,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser.rs:45:31
[INFO] [stderr]    |
[INFO] [stderr] 45 |           let next_precedence = match next_token {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 46 | |             &Token::Operator(ref symbol) => get_precedence(symbol),
[INFO] [stderr] 47 | |             _ => return Err(format!("Expected operator after expr"))
[INFO] [stderr] 48 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let next_precedence = match *next_token {
[INFO] [stderr] 46 |             Token::Operator(ref symbol) => get_precedence(symbol),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/parser.rs:47:29
[INFO] [stderr]    |
[INFO] [stderr] 47 |             _ => return Err(format!("Expected operator after expr"))
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected operator after expr".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |           Some(t) => match t {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 70 | |             &Token::Integer(n) => {
[INFO] [stderr] 71 | |                 Ok(Expr::Integer(n))
[INFO] [stderr] 72 | |             },
[INFO] [stderr] 73 | |             _ => Err(format!("unexpected token: {:?}", t))
[INFO] [stderr] 74 | |         },
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 69 |         Some(t) => match *t {
[INFO] [stderr] 70 |             Token::Integer(n) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:83:20
[INFO] [stderr]     |
[INFO] [stderr] 83  |           Some(t) => match t {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 84  | |             &Token::Operator(ref s) => {
[INFO] [stderr] 85  | |
[INFO] [stderr] 86  | |                 let op = match s {
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |             _ => Err(format!("Unexpected token {:?}", t))
[INFO] [stderr] 103 | |         },
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 83  |         Some(t) => match *t {
[INFO] [stderr] 84  |             Token::Operator(ref s) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser.rs:86:26
[INFO] [stderr]    |
[INFO] [stderr] 86 |                   let op = match s {
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 87 | |                     &Symbol::Add => Op::Add,
[INFO] [stderr] 88 | |                     &Symbol::Subtract => Op::Subtract,
[INFO] [stderr] 89 | |                     &Symbol::Multiply => Op::Multiply,
[INFO] [stderr] 90 | |                     &Symbol::Divide => Op::Divide,
[INFO] [stderr] 91 | |                 };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |                 let op = match *s {
[INFO] [stderr] 87 |                     Symbol::Add => Op::Add,
[INFO] [stderr] 88 |                     Symbol::Subtract => Op::Subtract,
[INFO] [stderr] 89 |                     Symbol::Multiply => Op::Multiply,
[INFO] [stderr] 90 |                     Symbol::Divide => Op::Divide,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/tokenizer.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 | /         loop {
[INFO] [stderr] 36 | |             match it.peek() {
[INFO] [stderr] 37 | |                 Some(&ch) => match ch {
[INFO] [stderr] 38 | |                     '0' ... '9' => {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |             }
[INFO] [stderr] 65 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(&ch) = it.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     match symbol {
[INFO] [stderr] 24 | |         &Symbol::Add | &Symbol::Subtract => 10,
[INFO] [stderr] 25 | |         &Symbol::Multiply | &Symbol::Divide => 20,
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |     match *symbol {
[INFO] [stderr] 24 |         Symbol::Add | Symbol::Subtract => 10,
[INFO] [stderr] 25 |         Symbol::Multiply | Symbol::Divide => 20,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser.rs:45:31
[INFO] [stderr]    |
[INFO] [stderr] 45 |           let next_precedence = match next_token {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 46 | |             &Token::Operator(ref symbol) => get_precedence(symbol),
[INFO] [stderr] 47 | |             _ => return Err(format!("Expected operator after expr"))
[INFO] [stderr] 48 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let next_precedence = match *next_token {
[INFO] [stderr] 46 |             Token::Operator(ref symbol) => get_precedence(symbol),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/parser.rs:47:29
[INFO] [stderr]    |
[INFO] [stderr] 47 |             _ => return Err(format!("Expected operator after expr"))
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected operator after expr".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |           Some(t) => match t {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 70 | |             &Token::Integer(n) => {
[INFO] [stderr] 71 | |                 Ok(Expr::Integer(n))
[INFO] [stderr] 72 | |             },
[INFO] [stderr] 73 | |             _ => Err(format!("unexpected token: {:?}", t))
[INFO] [stderr] 74 | |         },
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 69 |         Some(t) => match *t {
[INFO] [stderr] 70 |             Token::Integer(n) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:83:20
[INFO] [stderr]     |
[INFO] [stderr] 83  |           Some(t) => match t {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 84  | |             &Token::Operator(ref s) => {
[INFO] [stderr] 85  | |
[INFO] [stderr] 86  | |                 let op = match s {
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |             _ => Err(format!("Unexpected token {:?}", t))
[INFO] [stderr] 103 | |         },
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 83  |         Some(t) => match *t {
[INFO] [stderr] 84  |             Token::Operator(ref s) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser.rs:86:26
[INFO] [stderr]    |
[INFO] [stderr] 86 |                   let op = match s {
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 87 | |                     &Symbol::Add => Op::Add,
[INFO] [stderr] 88 | |                     &Symbol::Subtract => Op::Subtract,
[INFO] [stderr] 89 | |                     &Symbol::Multiply => Op::Multiply,
[INFO] [stderr] 90 | |                     &Symbol::Divide => Op::Divide,
[INFO] [stderr] 91 | |                 };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |                 let op = match *s {
[INFO] [stderr] 87 |                     Symbol::Add => Op::Add,
[INFO] [stderr] 88 |                     Symbol::Subtract => Op::Subtract,
[INFO] [stderr] 89 |                     Symbol::Multiply => Op::Multiply,
[INFO] [stderr] 90 |                     Symbol::Divide => Op::Divide,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.97s
[INFO] running `"docker" "inspect" "0b0410e143ae0ced018065d41a49c1a00ae632914b49c3fa88bb23cb5d294f3f"`
[INFO] running `"docker" "rm" "-f" "0b0410e143ae0ced018065d41a49c1a00ae632914b49c3fa88bb23cb5d294f3f"`
[INFO] [stdout] 0b0410e143ae0ced018065d41a49c1a00ae632914b49c3fa88bb23cb5d294f3f