[INFO] updating cached repository tjefferson08/rustcraft [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tjefferson08/rustcraft [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tjefferson08/rustcraft" "work/ex/clippy-test-run/sources/stable/gh/tjefferson08/rustcraft"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tjefferson08/rustcraft'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tjefferson08/rustcraft" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tjefferson08/rustcraft"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tjefferson08/rustcraft'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d9cd7eab7dafd803a4fbd4c2038754757c89dce3 [INFO] sha for GitHub repo tjefferson08/rustcraft: d9cd7eab7dafd803a4fbd4c2038754757c89dce3 [INFO] validating manifest of tjefferson08/rustcraft on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tjefferson08/rustcraft on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tjefferson08/rustcraft [INFO] finished frobbing tjefferson08/rustcraft [INFO] frobbed toml for tjefferson08/rustcraft written to work/ex/clippy-test-run/sources/stable/gh/tjefferson08/rustcraft/Cargo.toml [INFO] started frobbing tjefferson08/rustcraft [INFO] finished frobbing tjefferson08/rustcraft [INFO] frobbed toml for tjefferson08/rustcraft written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tjefferson08/rustcraft/Cargo.toml [INFO] crate tjefferson08/rustcraft has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tjefferson08/rustcraft against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tjefferson08/rustcraft:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0b9407ad03f3e5f4bd1f47aa5ac7dc15103467c43ef3ab05ab116c51429c1fe [INFO] running `"docker" "start" "-a" "e0b9407ad03f3e5f4bd1f47aa5ac7dc15103467c43ef3ab05ab116c51429c1fe"` [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling cgmath v0.16.1 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Compiling log v0.4.3 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling x11-dl v2.18.1 [INFO] [stderr] Checking rand v0.5.4 [INFO] [stderr] Compiling proc-macro2 v0.4.9 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Compiling wayland-scanner v0.20.11 [INFO] [stderr] Checking smallvec v0.6.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling quote v0.6.4 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Compiling wayland-client v0.20.11 [INFO] [stderr] Compiling wayland-protocols v0.20.11 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking tempfile v3.0.3 [INFO] [stderr] Compiling syn v0.14.5 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking wayland-sys v0.20.11 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking wayland-commons v0.20.11 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking rustcraft v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/mod.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/mod.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/textures/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | texture_size: texture_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/textures/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | image_size: image_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | display: display [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/mod.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/mod.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/textures/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | texture_size: texture_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/textures/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | image_size: image_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | display: display [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/application.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn run_game_loop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/application.rs:37:78 [INFO] [stderr] | [INFO] [stderr] 37 | let delta_t = (time_since_previous_loop.subsec_nanos() as f32) / 1000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/application.rs:112:62 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn push_state(&mut self, game_state: Box) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/application.rs:116:33 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn pop_state(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/camera.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn reset(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/camera.rs:23:58 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn update_position(&mut self, pos: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/camera.rs:27:58 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn update_rotation(&mut self, rot: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/entity.rs:24:64 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn update_position(&mut self, delta_pos: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/game_state.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | immut_ps [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/game_state.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let immut_ps = playing_state; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/game_state.rs:53:61 [INFO] [stderr] | [INFO] [stderr] 53 | fn process_event(&mut self, event: Event, delta_t: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/game_state.rs:60:84 [INFO] [stderr] | [INFO] [stderr] 60 | fn process_keyboard_input(&mut self, pressed_keys: &[bool; 256], delta_t: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/game_state.rs:124:76 [INFO] [stderr] | [INFO] [stderr] 124 | fn process_mouse_move(&mut self, deflection: (i32, i32), delta_t: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deg`, `PerspectiveFov` [INFO] [stderr] --> src/model/cube.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | use cgmath::{Deg, Matrix3, Matrix4, PerspectiveFov, Rad, Vector3}; [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/model/cube.rs:194:60 [INFO] [stderr] | [INFO] [stderr] 194 | fn update_position(&mut self, delta_pos: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/model/cube.rs:198:60 [INFO] [stderr] | [INFO] [stderr] 198 | fn update_rotation(&mut self, delta_rot: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/renderer/mod.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn clear(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/renderer/mod.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn update(self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/shaders/mod.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(_) => return s, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/window.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | w [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/window.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let w = Window { [INFO] [stderr] | _________________^ [INFO] [stderr] 25 | | display: display [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/window.rs:38:41 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn reset_cursor_position(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/application.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn run_game_loop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/application.rs:37:78 [INFO] [stderr] | [INFO] [stderr] 37 | let delta_t = (time_since_previous_loop.subsec_nanos() as f32) / 1000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/application.rs:112:62 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn push_state(&mut self, game_state: Box) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/application.rs:116:33 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn pop_state(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/camera.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn reset(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/camera.rs:23:58 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn update_position(&mut self, pos: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/camera.rs:27:58 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn update_rotation(&mut self, rot: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/entity.rs:24:64 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn update_position(&mut self, delta_pos: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/game_state.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | immut_ps [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/game_state.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let immut_ps = playing_state; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/game_state.rs:53:61 [INFO] [stderr] | [INFO] [stderr] 53 | fn process_event(&mut self, event: Event, delta_t: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/game_state.rs:60:84 [INFO] [stderr] | [INFO] [stderr] 60 | fn process_keyboard_input(&mut self, pressed_keys: &[bool; 256], delta_t: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/game_state.rs:124:76 [INFO] [stderr] | [INFO] [stderr] 124 | fn process_mouse_move(&mut self, deflection: (i32, i32), delta_t: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deg`, `PerspectiveFov` [INFO] [stderr] --> src/model/cube.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | use cgmath::{Deg, Matrix3, Matrix4, PerspectiveFov, Rad, Vector3}; [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/model/cube.rs:194:60 [INFO] [stderr] | [INFO] [stderr] 194 | fn update_position(&mut self, delta_pos: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/model/cube.rs:198:60 [INFO] [stderr] | [INFO] [stderr] 198 | fn update_rotation(&mut self, delta_rot: Vector3) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/renderer/mod.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn clear(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/renderer/mod.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn update(self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/shaders/mod.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(_) => return s, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/window.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | w [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/window.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let w = Window { [INFO] [stderr] | _________________^ [INFO] [stderr] 25 | | display: display [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/window.rs:38:41 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn reset_cursor_position(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `events` [INFO] [stderr] --> src/application.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | let events = events_loop.poll_events(|event| { [INFO] [stderr] | ^^^^^^ help: consider using `_events` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `speed` [INFO] [stderr] --> src/game_state.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let speed = 50.0; [INFO] [stderr] | ^^^^^ help: consider using `_speed` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_t` [INFO] [stderr] --> src/game_state.rs:53:47 [INFO] [stderr] | [INFO] [stderr] 53 | fn process_event(&mut self, event: Event, delta_t: f32) -> () { [INFO] [stderr] | ^^^^^^^ help: consider using `_delta_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_t` [INFO] [stderr] --> src/game_state.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | fn update(&mut self, delta_t: f32) { [INFO] [stderr] | ^^^^^^^ help: consider using `_delta_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_t` [INFO] [stderr] --> src/game_state.rs:156:43 [INFO] [stderr] | [INFO] [stderr] 156 | fn draw(&self, renderer: &mut Master, delta_t: f32) { [INFO] [stderr] | ^^^^^^^ help: consider using `_delta_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tex_coords_right` [INFO] [stderr] --> src/model/cube.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let tex_coords_right: TextureCoordinates = atlas.texture_coords_for(0, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_tex_coords_right` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tex_coords_left` [INFO] [stderr] --> src/model/cube.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | let tex_coords_left: TextureCoordinates = atlas.texture_coords_for(0, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_tex_coords_left` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tex_coords_top` [INFO] [stderr] --> src/model/cube.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let tex_coords_top: TextureCoordinates = atlas.texture_coords_for(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_tex_coords_top` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tex_coords_bottom` [INFO] [stderr] --> src/model/cube.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let tex_coords_bottom: TextureCoordinates = atlas.texture_coords_for(0, 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_tex_coords_bottom` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/textures/mod.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn texture_coords_for(&self, x: u32, y: u32) -> TextureCoordinates { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/textures/mod.rs:36:46 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn texture_coords_for(&self, x: u32, y: u32) -> TextureCoordinates { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/application.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | let mut current_state = self.current_state_mut(); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pop_state` [INFO] [stderr] --> src/application.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn pop_state(&mut self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_position` [INFO] [stderr] --> src/entity.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn from_position(pos: (f32, f32, f32)) -> Entity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_position` [INFO] [stderr] --> src/entity.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn update_position(&mut self, delta_pos: Vector3) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `texture_size` [INFO] [stderr] --> src/textures/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | texture_size: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `image_size` [INFO] [stderr] --> src/textures/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | image_size: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `textures_per_row` [INFO] [stderr] --> src/textures/mod.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | fn textures_per_row(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_cursor_position` [INFO] [stderr] --> src/window.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn reset_cursor_position(&self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let events =` [INFO] [stderr] --> src/application.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / let events = events_loop.poll_events(|event| { [INFO] [stderr] 56 | | // assume current mouse is in 'reset' position (in case [INFO] [stderr] 57 | | // there ARE no mouse events this loop, we don't want to [INFO] [stderr] 58 | | // keep "pulling" in whatever direction we last deflected) [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/application.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn current_state(&self) -> &Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&GameState` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/application.rs:124:44 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn current_state_mut(&mut self) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&mut GameState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: unused variable: `events` [INFO] [stderr] --> src/application.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | let events = events_loop.poll_events(|event| { [INFO] [stderr] | ^^^^^^ help: consider using `_events` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `speed` [INFO] [stderr] --> src/game_state.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let speed = 50.0; [INFO] [stderr] | ^^^^^ help: consider using `_speed` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_t` [INFO] [stderr] --> src/game_state.rs:53:47 [INFO] [stderr] | [INFO] [stderr] 53 | fn process_event(&mut self, event: Event, delta_t: f32) -> () { [INFO] [stderr] | ^^^^^^^ help: consider using `_delta_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_t` [INFO] [stderr] --> src/game_state.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | fn update(&mut self, delta_t: f32) { [INFO] [stderr] | ^^^^^^^ help: consider using `_delta_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_t` [INFO] [stderr] --> src/game_state.rs:156:43 [INFO] [stderr] | [INFO] [stderr] 156 | fn draw(&self, renderer: &mut Master, delta_t: f32) { [INFO] [stderr] | ^^^^^^^ help: consider using `_delta_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tex_coords_right` [INFO] [stderr] --> src/model/cube.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let tex_coords_right: TextureCoordinates = atlas.texture_coords_for(0, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_tex_coords_right` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tex_coords_left` [INFO] [stderr] --> src/model/cube.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | let tex_coords_left: TextureCoordinates = atlas.texture_coords_for(0, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_tex_coords_left` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tex_coords_top` [INFO] [stderr] --> src/model/cube.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let tex_coords_top: TextureCoordinates = atlas.texture_coords_for(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_tex_coords_top` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tex_coords_bottom` [INFO] [stderr] --> src/model/cube.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let tex_coords_bottom: TextureCoordinates = atlas.texture_coords_for(0, 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_tex_coords_bottom` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/textures/mod.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn texture_coords_for(&self, x: u32, y: u32) -> TextureCoordinates { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/textures/mod.rs:36:46 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn texture_coords_for(&self, x: u32, y: u32) -> TextureCoordinates { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/application.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | let mut current_state = self.current_state_mut(); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/camera.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | self.entity.rotation.x = self.entity.rotation.x + rot.x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.entity.rotation.x += rot.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/camera.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | self.entity.rotation.y = self.entity.rotation.y + rot.y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.entity.rotation.y += rot.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:17:47 [INFO] [stderr] | [INFO] [stderr] 17 | .with_dimensions(LogicalSize::new(WIDTH as f64, HEIGHT as f64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:17:61 [INFO] [stderr] | [INFO] [stderr] 17 | .with_dimensions(LogicalSize::new(WIDTH as f64, HEIGHT as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:41:55 [INFO] [stderr] | [INFO] [stderr] 41 | .set_cursor_position(LogicalPosition::new(WIDTH as f64 / 2.0, HEIGHT as f64 / 2.0)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:41:75 [INFO] [stderr] | [INFO] [stderr] 41 | .set_cursor_position(LogicalPosition::new(WIDTH as f64 / 2.0, HEIGHT as f64 / 2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pop_state` [INFO] [stderr] --> src/application.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn pop_state(&mut self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_position` [INFO] [stderr] --> src/entity.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn from_position(pos: (f32, f32, f32)) -> Entity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_position` [INFO] [stderr] --> src/entity.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn update_position(&mut self, delta_pos: Vector3) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `texture_size` [INFO] [stderr] --> src/textures/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | texture_size: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `image_size` [INFO] [stderr] --> src/textures/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | image_size: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `textures_per_row` [INFO] [stderr] --> src/textures/mod.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | fn textures_per_row(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_cursor_position` [INFO] [stderr] --> src/window.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn reset_cursor_position(&self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let events =` [INFO] [stderr] --> src/application.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / let events = events_loop.poll_events(|event| { [INFO] [stderr] 56 | | // assume current mouse is in 'reset' position (in case [INFO] [stderr] 57 | | // there ARE no mouse events this loop, we don't want to [INFO] [stderr] 58 | | // keep "pulling" in whatever direction we last deflected) [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/application.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn current_state(&self) -> &Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&GameState` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/application.rs:124:44 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn current_state_mut(&mut self) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&mut GameState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/camera.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | self.entity.rotation.x = self.entity.rotation.x + rot.x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.entity.rotation.x += rot.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/camera.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | self.entity.rotation.y = self.entity.rotation.y + rot.y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.entity.rotation.y += rot.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:17:47 [INFO] [stderr] | [INFO] [stderr] 17 | .with_dimensions(LogicalSize::new(WIDTH as f64, HEIGHT as f64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:17:61 [INFO] [stderr] | [INFO] [stderr] 17 | .with_dimensions(LogicalSize::new(WIDTH as f64, HEIGHT as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:41:55 [INFO] [stderr] | [INFO] [stderr] 41 | .set_cursor_position(LogicalPosition::new(WIDTH as f64 / 2.0, HEIGHT as f64 / 2.0)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:41:75 [INFO] [stderr] | [INFO] [stderr] 41 | .set_cursor_position(LogicalPosition::new(WIDTH as f64 / 2.0, HEIGHT as f64 / 2.0)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 30s [INFO] running `"docker" "inspect" "e0b9407ad03f3e5f4bd1f47aa5ac7dc15103467c43ef3ab05ab116c51429c1fe"` [INFO] running `"docker" "rm" "-f" "e0b9407ad03f3e5f4bd1f47aa5ac7dc15103467c43ef3ab05ab116c51429c1fe"` [INFO] [stdout] e0b9407ad03f3e5f4bd1f47aa5ac7dc15103467c43ef3ab05ab116c51429c1fe