[INFO] updating cached repository tiziano88/mqtt-lights [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tiziano88/mqtt-lights [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tiziano88/mqtt-lights" "work/ex/clippy-test-run/sources/stable/gh/tiziano88/mqtt-lights"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tiziano88/mqtt-lights'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tiziano88/mqtt-lights" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tiziano88/mqtt-lights"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tiziano88/mqtt-lights'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4dd2e64b4887a6457eef702a798999a3b658d41a [INFO] sha for GitHub repo tiziano88/mqtt-lights: 4dd2e64b4887a6457eef702a798999a3b658d41a [INFO] validating manifest of tiziano88/mqtt-lights on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tiziano88/mqtt-lights on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tiziano88/mqtt-lights [INFO] finished frobbing tiziano88/mqtt-lights [INFO] frobbed toml for tiziano88/mqtt-lights written to work/ex/clippy-test-run/sources/stable/gh/tiziano88/mqtt-lights/Cargo.toml [INFO] started frobbing tiziano88/mqtt-lights [INFO] finished frobbing tiziano88/mqtt-lights [INFO] frobbed toml for tiziano88/mqtt-lights written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tiziano88/mqtt-lights/Cargo.toml [INFO] crate tiziano88/mqtt-lights has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tiziano88/mqtt-lights against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tiziano88/mqtt-lights:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb96e29184889994c6c07e73b3346e755a77efd9997c77b6d56e6821ed66c61c [INFO] running `"docker" "start" "-a" "eb96e29184889994c6c07e73b3346e755a77efd9997c77b6d56e6821ed66c61c"` [INFO] [stderr] Checking byteorder v0.3.13 [INFO] [stderr] Checking quick-error v1.2.1 [INFO] [stderr] Checking rgb v0.7.2 [INFO] [stderr] Checking serde v1.0.55 [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Compiling openssl-sys v0.9.30 [INFO] [stderr] Checking rand v0.5.1 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Compiling syn v0.13.10 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking phf v0.7.22 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Compiling palette v0.4.0 [INFO] [stderr] Checking mqtt-protocol v0.3.1 [INFO] [stderr] Checking mote v0.1.2 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling serde_derive v1.0.55 [INFO] [stderr] Checking rumqtt v0.10.1 [INFO] [stderr] Compiling palette_derive v0.4.0 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking mqtt-lights v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `updates` [INFO] [stderr] --> src/main.rs:216:17 [INFO] [stderr] | [INFO] [stderr] 216 | let updates = handler_light [INFO] [stderr] | ^^^^^^^ help: consider using `_updates` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `updates` [INFO] [stderr] --> src/main.rs:216:17 [INFO] [stderr] | [INFO] [stderr] 216 | let updates = handler_light [INFO] [stderr] | ^^^^^^^ help: consider using `_updates` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:263:14 [INFO] [stderr] | [INFO] [stderr] 263 | .unwrap_or("/dev/ttyACM0".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "/dev/ttyACM0".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:72 [INFO] [stderr] | [INFO] [stderr] 281 | interval = std::time::Duration::from_millis(1000 / light.rate as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(light.rate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:283:39 [INFO] [stderr] | [INFO] [stderr] 283 | let decay = 1.0 * light.decay as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(light.decay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:285:72 [INFO] [stderr] | [INFO] [stderr] 285 | let dist = rand::distributions::Poisson::new(2.0 * light.lambda as f64 / 255.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(light.lambda)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `mask` [INFO] [stderr] --> src/main.rs:295:34 [INFO] [stderr] | [INFO] [stderr] 295 | for i in 0..mote::PIXELS_PER_CHANNEL as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 295 | for (i, ) in mask.iter().enumerate().take(mote::PIXELS_PER_CHANNEL as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:320:14 [INFO] [stderr] | [INFO] [stderr] 320 | for i in 0..pixels.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try replacing the loop by: `out[..pixels.len()].clone_from_slice(&pixels[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:326:25 [INFO] [stderr] | [INFO] [stderr] 326 | fn make_mask(particles: &Vec, n: u64) -> [palette::rgb::LinSrgb; mote::TOTAL_PIXELS] { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Particle]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:263:14 [INFO] [stderr] | [INFO] [stderr] 263 | .unwrap_or("/dev/ttyACM0".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "/dev/ttyACM0".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:72 [INFO] [stderr] | [INFO] [stderr] 281 | interval = std::time::Duration::from_millis(1000 / light.rate as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(light.rate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:283:39 [INFO] [stderr] | [INFO] [stderr] 283 | let decay = 1.0 * light.decay as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(light.decay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:285:72 [INFO] [stderr] | [INFO] [stderr] 285 | let dist = rand::distributions::Poisson::new(2.0 * light.lambda as f64 / 255.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(light.lambda)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `mask` [INFO] [stderr] --> src/main.rs:295:34 [INFO] [stderr] | [INFO] [stderr] 295 | for i in 0..mote::PIXELS_PER_CHANNEL as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 295 | for (i, ) in mask.iter().enumerate().take(mote::PIXELS_PER_CHANNEL as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:320:14 [INFO] [stderr] | [INFO] [stderr] 320 | for i in 0..pixels.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try replacing the loop by: `out[..pixels.len()].clone_from_slice(&pixels[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:326:25 [INFO] [stderr] | [INFO] [stderr] 326 | fn make_mask(particles: &Vec, n: u64) -> [palette::rgb::LinSrgb; mote::TOTAL_PIXELS] { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Particle]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.66s [INFO] running `"docker" "inspect" "eb96e29184889994c6c07e73b3346e755a77efd9997c77b6d56e6821ed66c61c"` [INFO] running `"docker" "rm" "-f" "eb96e29184889994c6c07e73b3346e755a77efd9997c77b6d56e6821ed66c61c"` [INFO] [stdout] eb96e29184889994c6c07e73b3346e755a77efd9997c77b6d56e6821ed66c61c