[INFO] updating cached repository timvisee/ffsend [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/timvisee/ffsend [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/timvisee/ffsend" "work/ex/clippy-test-run/sources/stable/gh/timvisee/ffsend"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/timvisee/ffsend'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/timvisee/ffsend" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timvisee/ffsend"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timvisee/ffsend'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 19322306f1f8fae1780e5f2d914e28d14b8a00b3 [INFO] sha for GitHub repo timvisee/ffsend: 19322306f1f8fae1780e5f2d914e28d14b8a00b3 [INFO] validating manifest of timvisee/ffsend on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of timvisee/ffsend on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing timvisee/ffsend [INFO] finished frobbing timvisee/ffsend [INFO] frobbed toml for timvisee/ffsend written to work/ex/clippy-test-run/sources/stable/gh/timvisee/ffsend/Cargo.toml [INFO] started frobbing timvisee/ffsend [INFO] finished frobbing timvisee/ffsend [INFO] frobbed toml for timvisee/ffsend written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timvisee/ffsend/Cargo.toml [INFO] crate timvisee/ffsend has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting timvisee/ffsend against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/timvisee/ffsend:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1262665f57a4f884c2fdac648ef9075b17484bcce135cd7680f282829a27945d [INFO] running `"docker" "start" "-a" "1262665f57a4f884c2fdac648ef9075b17484bcce135cd7680f282829a27945d"` [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling ident_case v1.0.0 [INFO] [stderr] Checking string v0.1.2 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking byte-tools v0.3.0 [INFO] [stderr] Compiling derive_builder v0.7.0 [INFO] [stderr] Compiling derive_builder v0.6.0 [INFO] [stderr] Checking opaque-debug v0.2.1 [INFO] [stderr] Checking encode_unicode v0.3.5 [INFO] [stderr] Checking arrayref v0.3.5 [INFO] [stderr] Checking version-compare v0.0.6 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking rpassword v2.0.0 [INFO] [stderr] Checking block-padding v0.1.2 [INFO] [stderr] Checking pbr v1.0.1 [INFO] [stderr] Checking http v0.1.14 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking generic-array v0.12.0 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking tar v0.4.20 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking digest v0.8.0 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking hmac v0.7.0 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking hkdf v0.7.0 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Compiling darling_core v0.6.3 [INFO] [stderr] Checking hyper v0.12.15 [INFO] [stderr] Compiling darling_core v0.8.0 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling darling_macro v0.6.3 [INFO] [stderr] Compiling darling v0.6.3 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Compiling derive_builder_core v0.3.0 [INFO] [stderr] Compiling darling_macro v0.8.0 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Compiling darling v0.8.0 [INFO] [stderr] Compiling derive_builder_core v0.4.0 [INFO] [stderr] Checking chbs v0.0.8 [INFO] [stderr] Checking ffsend-api v0.1.1 [INFO] [stderr] Checking ffsend v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/action/download.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / if !extract && metadata.metadata().is_archive() { [INFO] [stderr] 89 | | if prompt_yes( [INFO] [stderr] 90 | | "You're downloading an archive, extract it into the selected directory?", [INFO] [stderr] 91 | | Some(true), [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | if !extract && metadata.metadata().is_archive() && prompt_yes( [INFO] [stderr] 89 | "You're downloading an archive, extract it into the selected directory?", [INFO] [stderr] 90 | Some(true), [INFO] [stderr] 91 | &matcher_main, [INFO] [stderr] 92 | ) { [INFO] [stderr] 93 | extract = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/action/upload.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / if !archive && path.is_dir() { [INFO] [stderr] 130 | | if prompt_yes( [INFO] [stderr] 131 | | "You've selected a directory, only a single file may be uploaded.\n\ [INFO] [stderr] 132 | | Archive the directory into a single file?", [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | if !archive && path.is_dir() && prompt_yes( [INFO] [stderr] 130 | "You've selected a directory, only a single file may be uploaded.\n\ [INFO] [stderr] 131 | Archive the directory into a single file?", [INFO] [stderr] 132 | Some(true), [INFO] [stderr] 133 | &matcher_main, [INFO] [stderr] 134 | ) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/archive/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod archive; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/action/download.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / if !extract && metadata.metadata().is_archive() { [INFO] [stderr] 89 | | if prompt_yes( [INFO] [stderr] 90 | | "You're downloading an archive, extract it into the selected directory?", [INFO] [stderr] 91 | | Some(true), [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | if !extract && metadata.metadata().is_archive() && prompt_yes( [INFO] [stderr] 89 | "You're downloading an archive, extract it into the selected directory?", [INFO] [stderr] 90 | Some(true), [INFO] [stderr] 91 | &matcher_main, [INFO] [stderr] 92 | ) { [INFO] [stderr] 93 | extract = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/action/upload.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / if !archive && path.is_dir() { [INFO] [stderr] 130 | | if prompt_yes( [INFO] [stderr] 131 | | "You've selected a directory, only a single file may be uploaded.\n\ [INFO] [stderr] 132 | | Archive the directory into a single file?", [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | if !archive && path.is_dir() && prompt_yes( [INFO] [stderr] 130 | "You've selected a directory, only a single file may be uploaded.\n\ [INFO] [stderr] 131 | Archive the directory into a single file?", [INFO] [stderr] 132 | Some(true), [INFO] [stderr] 133 | &matcher_main, [INFO] [stderr] 134 | ) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/archive/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod archive; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Fail::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/util.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | .causes() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Fail::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/util.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | .causes() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/action/debug.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | .unwrap_or("disabled".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "disabled".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/action/debug.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | .unwrap_or("disabled".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "disabled".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/action/upload.rs:222:41 [INFO] [stderr] | [INFO] [stderr] 222 | Cell::new(&password.unwrap_or("?".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/action/debug.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | .unwrap_or("disabled".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "disabled".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/action/debug.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | .unwrap_or("disabled".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "disabled".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/action/upload.rs:222:41 [INFO] [stderr] | [INFO] [stderr] 222 | Cell::new(&password.unwrap_or("?".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 31s [INFO] running `"docker" "inspect" "1262665f57a4f884c2fdac648ef9075b17484bcce135cd7680f282829a27945d"` [INFO] running `"docker" "rm" "-f" "1262665f57a4f884c2fdac648ef9075b17484bcce135cd7680f282829a27945d"` [INFO] [stdout] 1262665f57a4f884c2fdac648ef9075b17484bcce135cd7680f282829a27945d