[INFO] updating cached repository timvisee/dotfiler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/timvisee/dotfiler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/timvisee/dotfiler" "work/ex/clippy-test-run/sources/stable/gh/timvisee/dotfiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/timvisee/dotfiler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/timvisee/dotfiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timvisee/dotfiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timvisee/dotfiler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e460815627201ee385115c08723e0eb6d2889009 [INFO] sha for GitHub repo timvisee/dotfiler: e460815627201ee385115c08723e0eb6d2889009 [INFO] validating manifest of timvisee/dotfiler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of timvisee/dotfiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing timvisee/dotfiler [INFO] finished frobbing timvisee/dotfiler [INFO] frobbed toml for timvisee/dotfiler written to work/ex/clippy-test-run/sources/stable/gh/timvisee/dotfiler/Cargo.toml [INFO] started frobbing timvisee/dotfiler [INFO] finished frobbing timvisee/dotfiler [INFO] frobbed toml for timvisee/dotfiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timvisee/dotfiler/Cargo.toml [INFO] crate timvisee/dotfiler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting timvisee/dotfiler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/timvisee/dotfiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f83c9041c7b4e00156fee86a1ac3ddaf3e024503d79d947e314ae483759b841b [INFO] running `"docker" "start" "-a" "f83c9041c7b4e00156fee86a1ac3ddaf3e024503d79d947e314ae483759b841b"` [INFO] [stderr] Checking nom v2.1.0 [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking toml v0.2.1 [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Checking config v0.4.1 [INFO] [stderr] Checking dotfiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dot/dotpath.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dot/scanner.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dot/dotpath.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dot/scanner.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | pub const APP_NAME: &'static str = "dotfiler"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | pub const APP_VERSION_NAME: &'static str = "v0.0.1-alpha"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | pub const APP_AUTHOR: &'static str = "Tim Visee "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | pub const APP_DESCRIPTION: &'static str = "A simple but useful tool to manage your dotfiles."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | pub const CONFIG_FILE_NAME: &'static str = ".dotfiler.yml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | pub const APP_NAME: &'static str = "dotfiler"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | pub const APP_VERSION_NAME: &'static str = "v0.0.1-alpha"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | pub const APP_AUTHOR: &'static str = "Tim Visee "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | pub const APP_DESCRIPTION: &'static str = "A simple but useful tool to manage your dotfiles."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | pub const CONFIG_FILE_NAME: &'static str = ".dotfiler.yml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_file` [INFO] [stderr] --> src/dot/dotpath.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn is_file(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dot/dotpath.rs:148:39 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn scan(&mut self, recursive: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_file` [INFO] [stderr] --> src/dot/dotpath.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn is_file(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dot/dotpath.rs:148:39 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn scan(&mut self, recursive: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.45s [INFO] running `"docker" "inspect" "f83c9041c7b4e00156fee86a1ac3ddaf3e024503d79d947e314ae483759b841b"` [INFO] running `"docker" "rm" "-f" "f83c9041c7b4e00156fee86a1ac3ddaf3e024503d79d947e314ae483759b841b"` [INFO] [stdout] f83c9041c7b4e00156fee86a1ac3ddaf3e024503d79d947e314ae483759b841b