[INFO] updating cached repository timocp/adventofcode-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/timocp/adventofcode-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/timocp/adventofcode-2018" "work/ex/clippy-test-run/sources/stable/gh/timocp/adventofcode-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/timocp/adventofcode-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/timocp/adventofcode-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timocp/adventofcode-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timocp/adventofcode-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e2e87b411c3a49a331b6af67046297c6be568c0 [INFO] sha for GitHub repo timocp/adventofcode-2018: 7e2e87b411c3a49a331b6af67046297c6be568c0 [INFO] validating manifest of timocp/adventofcode-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of timocp/adventofcode-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing timocp/adventofcode-2018 [INFO] finished frobbing timocp/adventofcode-2018 [INFO] frobbed toml for timocp/adventofcode-2018 written to work/ex/clippy-test-run/sources/stable/gh/timocp/adventofcode-2018/Cargo.toml [INFO] started frobbing timocp/adventofcode-2018 [INFO] finished frobbing timocp/adventofcode-2018 [INFO] frobbed toml for timocp/adventofcode-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timocp/adventofcode-2018/Cargo.toml [INFO] crate timocp/adventofcode-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting timocp/adventofcode-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/timocp/adventofcode-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 40c2b8124977a2e2d68e2e5191a945b69333e730aaae1e2c3437bd1456df3319 [INFO] running `"docker" "start" "-a" "40c2b8124977a2e2d68e2e5191a945b69333e730aaae1e2c3437bd1456df3319"` [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Checking ordermap v0.3.5 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Compiling syn v0.15.22 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking adventofcode-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:32:45 [INFO] [stderr] | [INFO] [stderr] 32 | match closest.entry(Point { x: x, y: y }) { [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:32:45 [INFO] [stderr] | [INFO] [stderr] 32 | match closest.entry(Point { x: x, y: y }) { [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:32:51 [INFO] [stderr] | [INFO] [stderr] 32 | match closest.entry(Point { x: x, y: y }) { [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:32:51 [INFO] [stderr] | [INFO] [stderr] 32 | match closest.entry(Point { x: x, y: y }) { [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | distance: distance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | distance: distance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:57:48 [INFO] [stderr] | [INFO] [stderr] 57 | let closest = closest.get(&Point { x: x, y: y }).unwrap(); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:57:48 [INFO] [stderr] | [INFO] [stderr] 57 | let closest = closest.get(&Point { x: x, y: y }).unwrap(); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:57:54 [INFO] [stderr] | [INFO] [stderr] 57 | let closest = closest.get(&Point { x: x, y: y }).unwrap(); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day6.rs:57:54 [INFO] [stderr] | [INFO] [stderr] 57 | let closest = closest.get(&Point { x: x, y: y }).unwrap(); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day12.rs:8:44 [INFO] [stderr] | [INFO] [stderr] 8 | Two => println!("{}", part2(input, 50000000000)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `50_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day3.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return overlap_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `overlap_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day12.rs:8:44 [INFO] [stderr] | [INFO] [stderr] 8 | Two => println!("{}", part2(input, 50000000000)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `50_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day12.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | assert_eq!(1045450380, rules); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_045_450_380` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day3.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return overlap_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `overlap_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day9.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | assert_eq!(146373, simulate_game(13, 7999)); [INFO] [stderr] | ^^^^^^ help: consider: `146_373` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | fn to_image(stars: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Star]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | fn area(stars: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Star]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | fn boxsize(stars: &Vec) -> (Point, Point) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Star]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day11.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | fn summed_area(grid: &Vec>) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `grid` [INFO] [stderr] --> src/day11.rs:100:14 [INFO] [stderr] | [INFO] [stderr] 100 | for x in 0..300 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 100 | for (x, ) in grid.iter_mut().enumerate().take(300) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day12.rs:73:34 [INFO] [stderr] | [INFO] [stderr] 73 | } else if line.ends_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day2.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match compare(id1, id2) { [INFO] [stderr] 36 | | Some(s) => return s, [INFO] [stderr] 37 | | None => (), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(s) = compare(id1, id2) { return s }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day3.rs:16:66 [INFO] [stderr] | [INFO] [stderr] 16 | fn process(fabric: &mut HashMap<(usize, usize), Square>, claims: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day3.rs:43:67 [INFO] [stderr] | [INFO] [stderr] 43 | fn intact_claim(fabric: &HashMap<(usize, usize), Square>, claims: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day3.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | / match fabric.get(&(x, y)) { [INFO] [stderr] 48 | | Some(sq) => { [INFO] [stderr] 49 | | if sq.overlaps { [INFO] [stderr] 50 | | continue 'claim; [INFO] [stderr] ... | [INFO] [stderr] 53 | | None => {} [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(sq) = fabric.get(&(x, y)) { [INFO] [stderr] 48 | if sq.overlaps { [INFO] [stderr] 49 | continue 'claim; [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day4.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | fn collect_stats(events: &Vec) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Event]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a VecDeque. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day5.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | if *input.get(input.len() - 1).unwrap() == '\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `input[input.len() - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6.rs:24:32 [INFO] [stderr] | [INFO] [stderr] 24 | fn largest_finite_area(coords: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day6.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | let closest = closest.get(&Point { x: x, y: y }).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&closest[&Point { x: x, y: y }]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | fn safe_area(coords: &Vec, limit: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | fn box_size(coords: &Vec) -> (Point, Point) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7.rs:66:55 [INFO] [stderr] | [INFO] [stderr] 66 | fn next_step_except(g: &DiGraphMap, except: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day8.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | fn to_image(stars: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Star]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | fn area(stars: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Star]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | fn boxsize(stars: &Vec) -> (Point, Point) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Star]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day11.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | fn summed_area(grid: &Vec>) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `grid` [INFO] [stderr] --> src/day11.rs:100:14 [INFO] [stderr] | [INFO] [stderr] 100 | for x in 0..300 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 100 | for (x, ) in grid.iter_mut().enumerate().take(300) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day12.rs:73:34 [INFO] [stderr] | [INFO] [stderr] 73 | } else if line.ends_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day2.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match compare(id1, id2) { [INFO] [stderr] 36 | | Some(s) => return s, [INFO] [stderr] 37 | | None => (), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(s) = compare(id1, id2) { return s }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day3.rs:16:66 [INFO] [stderr] | [INFO] [stderr] 16 | fn process(fabric: &mut HashMap<(usize, usize), Square>, claims: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day3.rs:43:67 [INFO] [stderr] | [INFO] [stderr] 43 | fn intact_claim(fabric: &HashMap<(usize, usize), Square>, claims: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day3.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | / match fabric.get(&(x, y)) { [INFO] [stderr] 48 | | Some(sq) => { [INFO] [stderr] 49 | | if sq.overlaps { [INFO] [stderr] 50 | | continue 'claim; [INFO] [stderr] ... | [INFO] [stderr] 53 | | None => {} [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(sq) = fabric.get(&(x, y)) { [INFO] [stderr] 48 | if sq.overlaps { [INFO] [stderr] 49 | continue 'claim; [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day4.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | fn collect_stats(events: &Vec) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Event]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a VecDeque. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day5.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | if *input.get(input.len() - 1).unwrap() == '\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `input[input.len() - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6.rs:24:32 [INFO] [stderr] | [INFO] [stderr] 24 | fn largest_finite_area(coords: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day6.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | let closest = closest.get(&Point { x: x, y: y }).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&closest[&Point { x: x, y: y }]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | fn safe_area(coords: &Vec, limit: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | fn box_size(coords: &Vec) -> (Point, Point) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7.rs:66:55 [INFO] [stderr] | [INFO] [stderr] 66 | fn next_step_except(g: &DiGraphMap, except: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day8.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.44s [INFO] running `"docker" "inspect" "40c2b8124977a2e2d68e2e5191a945b69333e730aaae1e2c3437bd1456df3319"` [INFO] running `"docker" "rm" "-f" "40c2b8124977a2e2d68e2e5191a945b69333e730aaae1e2c3437bd1456df3319"` [INFO] [stdout] 40c2b8124977a2e2d68e2e5191a945b69333e730aaae1e2c3437bd1456df3319