[INFO] updating cached repository timglabisch/resque_bulker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/timglabisch/resque_bulker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/timglabisch/resque_bulker" "work/ex/clippy-test-run/sources/stable/gh/timglabisch/resque_bulker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/timglabisch/resque_bulker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/timglabisch/resque_bulker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timglabisch/resque_bulker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timglabisch/resque_bulker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f1a8ef1f68f245753cacc7deebdcc8e4605f64c [INFO] sha for GitHub repo timglabisch/resque_bulker: 2f1a8ef1f68f245753cacc7deebdcc8e4605f64c [INFO] validating manifest of timglabisch/resque_bulker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of timglabisch/resque_bulker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing timglabisch/resque_bulker [INFO] finished frobbing timglabisch/resque_bulker [INFO] frobbed toml for timglabisch/resque_bulker written to work/ex/clippy-test-run/sources/stable/gh/timglabisch/resque_bulker/Cargo.toml [INFO] started frobbing timglabisch/resque_bulker [INFO] finished frobbing timglabisch/resque_bulker [INFO] frobbed toml for timglabisch/resque_bulker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timglabisch/resque_bulker/Cargo.toml [INFO] crate timglabisch/resque_bulker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting timglabisch/resque_bulker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/timglabisch/resque_bulker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7195927cac360d7f981cac8bb3e3a25323a8cd5b745587e56cc02ee554d38d28 [INFO] running `"docker" "start" "-a" "7195927cac360d7f981cac8bb3e3a25323a8cd5b745587e56cc02ee554d38d28"` [INFO] [stderr] Compiling redis v0.8.0 [INFO] [stderr] Checking rand v0.3.20 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking url v1.6.0 [INFO] [stderr] Checking chan v0.1.20 [INFO] [stderr] Checking chan-signal v0.3.1 [INFO] [stderr] Checking resque v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/config.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | queue_configs: queue_configs [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_configs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/config.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | queue_configs: queue_configs [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_configs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod config; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod config; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/worker.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/worker.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/worker.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `enqueue` [INFO] [stderr] --> src/worker.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | let enqueue: () = ::redis::cmd("rpush") [INFO] [stderr] | ^^^^^^^ help: consider using `_enqueue` instead [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/worker.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `enqueue` [INFO] [stderr] --> src/worker.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | let enqueue: () = ::redis::cmd("rpush") [INFO] [stderr] | ^^^^^^^ help: consider using `_enqueue` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `queue` [INFO] [stderr] --> src/worker.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | queue: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] warning: field is never used: `queue` [INFO] [stderr] --> src/worker.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | queue: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/worker.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | if buffer.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/worker.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | if buffer.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/worker.rs:126:55 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn reenqueue(&self, con : &Connection, data : &Vec) -> Result<(), Box<::std::error::Error>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[DequeueResult]` [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/worker.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | if buffer.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/worker.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | if buffer.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let enqueue =` [INFO] [stderr] --> src/worker.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / let enqueue: () = ::redis::cmd("rpush") [INFO] [stderr] 142 | | .arg("resque:queue:default:foo") [INFO] [stderr] 143 | | .arg(&buffer) [INFO] [stderr] 144 | | .query(con)?; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/worker.rs:126:55 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn reenqueue(&self, con : &Connection, data : &Vec) -> Result<(), Box<::std::error::Error>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[DequeueResult]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let enqueue =` [INFO] [stderr] --> src/worker.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / let enqueue: () = ::redis::cmd("rpush") [INFO] [stderr] 142 | | .arg("resque:queue:default:foo") [INFO] [stderr] 143 | | .arg(&buffer) [INFO] [stderr] 144 | | .query(con)?; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.04s [INFO] running `"docker" "inspect" "7195927cac360d7f981cac8bb3e3a25323a8cd5b745587e56cc02ee554d38d28"` [INFO] running `"docker" "rm" "-f" "7195927cac360d7f981cac8bb3e3a25323a8cd5b745587e56cc02ee554d38d28"` [INFO] [stdout] 7195927cac360d7f981cac8bb3e3a25323a8cd5b745587e56cc02ee554d38d28