[INFO] updating cached repository timglabisch/innodblockmon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/timglabisch/innodblockmon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/timglabisch/innodblockmon" "work/ex/clippy-test-run/sources/stable/gh/timglabisch/innodblockmon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/timglabisch/innodblockmon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/timglabisch/innodblockmon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timglabisch/innodblockmon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timglabisch/innodblockmon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ca65fb25a02828e1272b6475877e0ad2c86e91a7 [INFO] sha for GitHub repo timglabisch/innodblockmon: ca65fb25a02828e1272b6475877e0ad2c86e91a7 [INFO] validating manifest of timglabisch/innodblockmon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of timglabisch/innodblockmon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing timglabisch/innodblockmon [INFO] finished frobbing timglabisch/innodblockmon [INFO] frobbed toml for timglabisch/innodblockmon written to work/ex/clippy-test-run/sources/stable/gh/timglabisch/innodblockmon/Cargo.toml [INFO] started frobbing timglabisch/innodblockmon [INFO] finished frobbing timglabisch/innodblockmon [INFO] frobbed toml for timglabisch/innodblockmon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/timglabisch/innodblockmon/Cargo.toml [INFO] crate timglabisch/innodblockmon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting timglabisch/innodblockmon against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/timglabisch/innodblockmon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c33d205ee9ac5ddfdc8c7977d42f62b241781bdc33ae19120230329dd5718d3 [INFO] running `"docker" "start" "-a" "0c33d205ee9ac5ddfdc8c7977d42f62b241781bdc33ae19120230329dd5718d3"` [INFO] [stderr] Checking serde v1.0.17 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking smallvec v0.4.4 [INFO] [stderr] Checking atoi v0.2.2 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking twox-hash v1.1.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking serde_json v1.0.5 [INFO] [stderr] Checking mysql_common v0.2.0 [INFO] [stderr] Checking mysql v12.0.3 [INFO] [stderr] Checking innodblockmon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | Ok(()) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | / match self::handle(&mut server) { [INFO] [stderr] 69 | | Err(e) => { [INFO] [stderr] 70 | | println!("Error: {:#?}", e); [INFO] [stderr] 71 | | break; [INFO] [stderr] 72 | | }, [INFO] [stderr] 73 | | Ok(_) => {} [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | if let Err(e) = self::handle(&mut server) { [INFO] [stderr] 69 | println!("Error: {:#?}", e); [INFO] [stderr] 70 | break; [INFO] [stderr] 71 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:91:12 [INFO] [stderr] | [INFO] [stderr] 91 | if transactions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `transactions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | Ok(()) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | / match self::handle(&mut server) { [INFO] [stderr] 69 | | Err(e) => { [INFO] [stderr] 70 | | println!("Error: {:#?}", e); [INFO] [stderr] 71 | | break; [INFO] [stderr] 72 | | }, [INFO] [stderr] 73 | | Ok(_) => {} [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | if let Err(e) = self::handle(&mut server) { [INFO] [stderr] 69 | println!("Error: {:#?}", e); [INFO] [stderr] 70 | break; [INFO] [stderr] 71 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:91:12 [INFO] [stderr] | [INFO] [stderr] 91 | if transactions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `transactions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.92s [INFO] running `"docker" "inspect" "0c33d205ee9ac5ddfdc8c7977d42f62b241781bdc33ae19120230329dd5718d3"` [INFO] running `"docker" "rm" "-f" "0c33d205ee9ac5ddfdc8c7977d42f62b241781bdc33ae19120230329dd5718d3"` [INFO] [stdout] 0c33d205ee9ac5ddfdc8c7977d42f62b241781bdc33ae19120230329dd5718d3