[INFO] updating cached repository tilpner/cpuline [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tilpner/cpuline [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tilpner/cpuline" "work/ex/clippy-test-run/sources/stable/gh/tilpner/cpuline"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tilpner/cpuline'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tilpner/cpuline" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tilpner/cpuline"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tilpner/cpuline'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4665f6d81770acef0612396917bc71c49fcdb6d9 [INFO] sha for GitHub repo tilpner/cpuline: 4665f6d81770acef0612396917bc71c49fcdb6d9 [INFO] validating manifest of tilpner/cpuline on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tilpner/cpuline on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tilpner/cpuline [INFO] finished frobbing tilpner/cpuline [INFO] frobbed toml for tilpner/cpuline written to work/ex/clippy-test-run/sources/stable/gh/tilpner/cpuline/Cargo.toml [INFO] started frobbing tilpner/cpuline [INFO] finished frobbing tilpner/cpuline [INFO] frobbed toml for tilpner/cpuline written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tilpner/cpuline/Cargo.toml [INFO] crate tilpner/cpuline has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tilpner/cpuline against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tilpner/cpuline:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93699c455d2a09a89dcef8960eac3e3b7ed507bc65beaa11f68529a65ac22c87 [INFO] running `"docker" "start" "-a" "93699c455d2a09a89dcef8960eac3e3b7ed507bc65beaa11f68529a65ac22c87"` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking libc v0.2.36 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking unicode-segmentation v1.2.0 [INFO] [stderr] Checking log v0.3.7 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Checking vec_map v0.6.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking cpuline v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | const PROC_STAT: &'static str = "/proc/stat"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | const PROC_STAT: &'static str = "/proc/stat"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / match (&stat, &old) { [INFO] [stderr] 162 | | (&Some(ref now), &Some(ref old)) => { [INFO] [stderr] 163 | | let load = now.load_since(&old); [INFO] [stderr] 164 | | let duration_ticks = load.duration.as_secs() * user_hz [INFO] [stderr] ... | [INFO] [stderr] 179 | | _ => () [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 161 | if let (&Some(ref now), &Some(ref old)) = (&stat, &old) { [INFO] [stderr] 162 | let load = now.load_since(&old); [INFO] [stderr] 163 | let duration_ticks = load.duration.as_secs() * user_hz [INFO] [stderr] 164 | + (load.duration.subsec_nanos() as f64 / 1E9 * user_hz as f64) as u64; [INFO] [stderr] 165 | [INFO] [stderr] 166 | for (_, core) in load.cores.iter() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:165:24 [INFO] [stderr] | [INFO] [stderr] 165 | + (load.duration.subsec_nanos() as f64 / 1E9 * user_hz as f64) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(load.duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / match (&stat, &old) { [INFO] [stderr] 162 | | (&Some(ref now), &Some(ref old)) => { [INFO] [stderr] 163 | | let load = now.load_since(&old); [INFO] [stderr] 164 | | let duration_ticks = load.duration.as_secs() * user_hz [INFO] [stderr] ... | [INFO] [stderr] 179 | | _ => () [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 161 | if let (&Some(ref now), &Some(ref old)) = (&stat, &old) { [INFO] [stderr] 162 | let load = now.load_since(&old); [INFO] [stderr] 163 | let duration_ticks = load.duration.as_secs() * user_hz [INFO] [stderr] 164 | + (load.duration.subsec_nanos() as f64 / 1E9 * user_hz as f64) as u64; [INFO] [stderr] 165 | [INFO] [stderr] 166 | for (_, core) in load.cores.iter() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:165:24 [INFO] [stderr] | [INFO] [stderr] 165 | + (load.duration.subsec_nanos() as f64 / 1E9 * user_hz as f64) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(load.duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 16.93s [INFO] running `"docker" "inspect" "93699c455d2a09a89dcef8960eac3e3b7ed507bc65beaa11f68529a65ac22c87"` [INFO] running `"docker" "rm" "-f" "93699c455d2a09a89dcef8960eac3e3b7ed507bc65beaa11f68529a65ac22c87"` [INFO] [stdout] 93699c455d2a09a89dcef8960eac3e3b7ed507bc65beaa11f68529a65ac22c87