[INFO] updating cached repository tigranmt/Diff
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tigranmt/Diff
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tigranmt/Diff" "work/ex/clippy-test-run/sources/stable/gh/tigranmt/Diff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tigranmt/Diff'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tigranmt/Diff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tigranmt/Diff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tigranmt/Diff'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c41faf6455ec5b788adfe341c98cec00d9cf2712
[INFO] sha for GitHub repo tigranmt/Diff: c41faf6455ec5b788adfe341c98cec00d9cf2712
[INFO] validating manifest of tigranmt/Diff on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tigranmt/Diff on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tigranmt/Diff
[INFO] finished frobbing tigranmt/Diff
[INFO] frobbed toml for tigranmt/Diff written to work/ex/clippy-test-run/sources/stable/gh/tigranmt/Diff/Cargo.toml
[INFO] started frobbing tigranmt/Diff
[INFO] finished frobbing tigranmt/Diff
[INFO] frobbed toml for tigranmt/Diff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tigranmt/Diff/Cargo.toml
[INFO] crate tigranmt/Diff has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tigranmt/Diff against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tigranmt/Diff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 85fad8b874d56f7883fb112cb19e6ed4c22f3ee9525691e63ef17a7984475ecf
[INFO] running `"docker" "start" "-a" "85fad8b874d56f7883fb112cb19e6ed4c22f3ee9525691e63ef17a7984475ecf"`
[INFO] [stderr]     Checking diff v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/diff/difflib.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:47:6
[INFO] [stderr]    |
[INFO] [stderr] 47 |      println!("");
[INFO] [stderr]    |      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:54:6
[INFO] [stderr]    |
[INFO] [stderr] 54 |      println!("");
[INFO] [stderr]    |      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:56:6
[INFO] [stderr]    |
[INFO] [stderr] 56 |      println!("");
[INFO] [stderr]    |      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:59:6
[INFO] [stderr]    |
[INFO] [stderr] 59 |      println!("");
[INFO] [stderr]    |      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/diff/difflib.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:47:6
[INFO] [stderr]    |
[INFO] [stderr] 47 |      println!("");
[INFO] [stderr]    |      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:54:6
[INFO] [stderr]    |
[INFO] [stderr] 54 |      println!("");
[INFO] [stderr]    |      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:56:6
[INFO] [stderr]    |
[INFO] [stderr] 56 |      println!("");
[INFO] [stderr]    |      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:59:6
[INFO] [stderr]    |
[INFO] [stderr] 59 |      println!("");
[INFO] [stderr]    |      ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/diff/presenter.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 | /             if (prev.operation == DiffOperation::Insert && next.operation == DiffOperation::Remove)
[INFO] [stderr] 74 | |                     || (prev.operation == DiffOperation::Remove && next.operation == DiffOperation::Insert)
[INFO] [stderr] 75 | |             {
[INFO] [stderr] 76 | |                 if prev.start == next.start && prev.count == next.count
[INFO] [stderr] ...  |
[INFO] [stderr] 80 | |
[INFO] [stderr] 81 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if ((prev.operation == DiffOperation::Insert && next.operation == DiffOperation::Remove)
[INFO] [stderr] 74 |                     || (prev.operation == DiffOperation::Remove && next.operation == DiffOperation::Insert)) && prev.start == next.start && prev.count == next.count {
[INFO] [stderr] 75 |     count_to_skip += 2; //skip both
[INFO] [stderr] 76 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 | const STR1   : &'static str = "-s1"; //string   _from_ 
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:18:17
[INFO] [stderr]    |
[INFO] [stderr] 18 | const STR2   : &'static str = "-s2"; //string   _to_
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 | const FILE1  : &'static str = "-f1"; //file     _from_
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:20:17
[INFO] [stderr]    |
[INFO] [stderr] 20 | const FILE2  : &'static str = "-f2"; //file     _to_
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/diff/presenter.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 | /             if (prev.operation == DiffOperation::Insert && next.operation == DiffOperation::Remove)
[INFO] [stderr] 74 | |                     || (prev.operation == DiffOperation::Remove && next.operation == DiffOperation::Insert)
[INFO] [stderr] 75 | |             {
[INFO] [stderr] 76 | |                 if prev.start == next.start && prev.count == next.count
[INFO] [stderr] ...  |
[INFO] [stderr] 80 | |
[INFO] [stderr] 81 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if ((prev.operation == DiffOperation::Insert && next.operation == DiffOperation::Remove)
[INFO] [stderr] 74 |                     || (prev.operation == DiffOperation::Remove && next.operation == DiffOperation::Insert)) && prev.start == next.start && prev.count == next.count {
[INFO] [stderr] 75 |     count_to_skip += 2; //skip both
[INFO] [stderr] 76 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 | const STR1   : &'static str = "-s1"; //string   _from_ 
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:18:17
[INFO] [stderr]    |
[INFO] [stderr] 18 | const STR2   : &'static str = "-s2"; //string   _to_
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 | const FILE1  : &'static str = "-f1"; //file     _from_
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:20:17
[INFO] [stderr]    |
[INFO] [stderr] 20 | const FILE2  : &'static str = "-f2"; //file     _to_
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/main.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | #[allow(dead_code)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::useless_attribute)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:244:17
[INFO] [stderr]     |
[INFO] [stderr] 244 |                 row = row - 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: replace it with: `row -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:245:17
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 col = col - 1;     
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: replace it with: `col -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:246:17
[INFO] [stderr]     |
[INFO] [stderr] 246 |                 op_count = op_count+1;        
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:260:17
[INFO] [stderr]     |
[INFO] [stderr] 260 |                 row = row - 1;     //go UP
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: replace it with: `row -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:261:17
[INFO] [stderr]     |
[INFO] [stderr] 261 |                 op_count = op_count+1;  
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:275:17
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 col = col - 1;     //go LEFT
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: replace it with: `col -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:276:17
[INFO] [stderr]     |
[INFO] [stderr] 276 |                 op_count = op_count+1; 
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/diff/presenter.rs:37:12
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if result.len() > 0 
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:36:8
[INFO] [stderr]    |
[INFO] [stderr] 36 |     if diff_vec.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `diff_vec.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:157:17
[INFO] [stderr]     |
[INFO] [stderr] 157 |                 line_num = line_num + 1;             
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:172:17
[INFO] [stderr]     |
[INFO] [stderr] 172 |                 line_num = line_num + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:188:17
[INFO] [stderr]     |
[INFO] [stderr] 188 |                 line_num = line_num + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:204:26
[INFO] [stderr]     |
[INFO] [stderr] 204 | fn hash_from_args(args : &Vec<String>) -> HashMap<String,String>
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `diff`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/main.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | #[allow(dead_code)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::useless_attribute)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:244:17
[INFO] [stderr]     |
[INFO] [stderr] 244 |                 row = row - 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: replace it with: `row -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:245:17
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 col = col - 1;     
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: replace it with: `col -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:246:17
[INFO] [stderr]     |
[INFO] [stderr] 246 |                 op_count = op_count+1;        
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:260:17
[INFO] [stderr]     |
[INFO] [stderr] 260 |                 row = row - 1;     //go UP
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: replace it with: `row -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:261:17
[INFO] [stderr]     |
[INFO] [stderr] 261 |                 op_count = op_count+1;  
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:275:17
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 col = col - 1;     //go LEFT
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: replace it with: `col -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/diff/difflib.rs:276:17
[INFO] [stderr]     |
[INFO] [stderr] 276 |                 op_count = op_count+1; 
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/diff/difflib.rs:305:19
[INFO] [stderr]     |
[INFO] [stderr] 305 |        assert_eq!(res.len() == 0, true);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/diff/difflib.rs:315:19
[INFO] [stderr]     |
[INFO] [stderr] 315 |        assert_eq!(res.len() == 0, true);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/diff/presenter.rs:37:12
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if result.len() > 0 
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:36:8
[INFO] [stderr]    |
[INFO] [stderr] 36 |     if diff_vec.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `diff_vec.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:157:17
[INFO] [stderr]     |
[INFO] [stderr] 157 |                 line_num = line_num + 1;             
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:172:17
[INFO] [stderr]     |
[INFO] [stderr] 172 |                 line_num = line_num + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:188:17
[INFO] [stderr]     |
[INFO] [stderr] 188 |                 line_num = line_num + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:204:26
[INFO] [stderr]     |
[INFO] [stderr] 204 | fn hash_from_args(args : &Vec<String>) -> HashMap<String,String>
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `diff`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "85fad8b874d56f7883fb112cb19e6ed4c22f3ee9525691e63ef17a7984475ecf"`
[INFO] running `"docker" "rm" "-f" "85fad8b874d56f7883fb112cb19e6ed4c22f3ee9525691e63ef17a7984475ecf"`
[INFO] [stdout] 85fad8b874d56f7883fb112cb19e6ed4c22f3ee9525691e63ef17a7984475ecf