[INFO] updating cached repository tigertoes/fe2o3 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tigertoes/fe2o3 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tigertoes/fe2o3" "work/ex/clippy-test-run/sources/stable/gh/tigertoes/fe2o3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tigertoes/fe2o3'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tigertoes/fe2o3" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tigertoes/fe2o3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tigertoes/fe2o3'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6ba5d9500add8b932adc51183d9c796271d21e0f [INFO] sha for GitHub repo tigertoes/fe2o3: 6ba5d9500add8b932adc51183d9c796271d21e0f [INFO] validating manifest of tigertoes/fe2o3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tigertoes/fe2o3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tigertoes/fe2o3 [INFO] finished frobbing tigertoes/fe2o3 [INFO] frobbed toml for tigertoes/fe2o3 written to work/ex/clippy-test-run/sources/stable/gh/tigertoes/fe2o3/Cargo.toml [INFO] started frobbing tigertoes/fe2o3 [INFO] finished frobbing tigertoes/fe2o3 [INFO] frobbed toml for tigertoes/fe2o3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tigertoes/fe2o3/Cargo.toml [INFO] crate tigertoes/fe2o3 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tigertoes/fe2o3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tigertoes/fe2o3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb08bd6ace292b04cceaa6df1181f0288262fecdbb946dc2442f5c434ee7815e [INFO] running `"docker" "start" "-a" "cb08bd6ace292b04cceaa6df1181f0288262fecdbb946dc2442f5c434ee7815e"` [INFO] [stderr] Checking maxminddb v0.8.1 [INFO] [stderr] Checking hyper v0.11.7 [INFO] [stderr] Checking fe2o3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `ct_result` [INFO] [stderr] --> src/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let ct_result: Result = self.city.lookup(ip); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_ct_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `as_result` [INFO] [stderr] --> src/lib.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | let as_result: Result = self.autonomous_system.lookup(ip); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_as_result` instead [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `AS_NOT_FOUND` [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | static AS_NOT_FOUND: &'static str = "0"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | Some(c) => c.iso_code.unwrap_or(CC_NOT_FOUND.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| CC_NOT_FOUND.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ct_result` [INFO] [stderr] --> src/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let ct_result: Result = self.city.lookup(ip); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_ct_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `as_result` [INFO] [stderr] --> src/lib.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | let as_result: Result = self.autonomous_system.lookup(ip); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_as_result` instead [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `AS_NOT_FOUND` [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | static AS_NOT_FOUND: &'static str = "0"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | Some(c) => c.iso_code.unwrap_or(CC_NOT_FOUND.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| CC_NOT_FOUND.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.44s [INFO] running `"docker" "inspect" "cb08bd6ace292b04cceaa6df1181f0288262fecdbb946dc2442f5c434ee7815e"` [INFO] running `"docker" "rm" "-f" "cb08bd6ace292b04cceaa6df1181f0288262fecdbb946dc2442f5c434ee7815e"` [INFO] [stdout] cb08bd6ace292b04cceaa6df1181f0288262fecdbb946dc2442f5c434ee7815e