[INFO] updating cached repository thomaslienbacher/Moving-Tower [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/thomaslienbacher/Moving-Tower [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/thomaslienbacher/Moving-Tower" "work/ex/clippy-test-run/sources/stable/gh/thomaslienbacher/Moving-Tower"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/thomaslienbacher/Moving-Tower'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/thomaslienbacher/Moving-Tower" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thomaslienbacher/Moving-Tower"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thomaslienbacher/Moving-Tower'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dd21ae37deea0e41d016dedb0a6772d3c1b90e33 [INFO] sha for GitHub repo thomaslienbacher/Moving-Tower: dd21ae37deea0e41d016dedb0a6772d3c1b90e33 [INFO] validating manifest of thomaslienbacher/Moving-Tower on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thomaslienbacher/Moving-Tower on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thomaslienbacher/Moving-Tower [INFO] finished frobbing thomaslienbacher/Moving-Tower [INFO] frobbed toml for thomaslienbacher/Moving-Tower written to work/ex/clippy-test-run/sources/stable/gh/thomaslienbacher/Moving-Tower/Cargo.toml [INFO] started frobbing thomaslienbacher/Moving-Tower [INFO] finished frobbing thomaslienbacher/Moving-Tower [INFO] frobbed toml for thomaslienbacher/Moving-Tower written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thomaslienbacher/Moving-Tower/Cargo.toml [INFO] crate thomaslienbacher/Moving-Tower has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thomaslienbacher/Moving-Tower against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/thomaslienbacher/Moving-Tower:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e738456dace52847b8989a1d9104a6ffee7ccc3f206645d0dbc161d412df082 [INFO] running `"docker" "start" "-a" "4e738456dace52847b8989a1d9104a6ffee7ccc3f206645d0dbc161d412df082"` [INFO] [stderr] Compiling sfml-build v0.2.0 [INFO] [stderr] Compiling csfml-system-sys v0.4.0 [INFO] [stderr] Compiling csfml-window-sys v0.4.0 [INFO] [stderr] Compiling csfml-graphics-sys v0.4.0 [INFO] [stderr] Compiling csfml-audio-sys v0.4.0 [INFO] [stderr] Checking sfml v0.14.0 [INFO] [stderr] Checking moving-tower v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | window.clear(&Color::from(0x777777FF)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7777_77FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `evt` [INFO] [stderr] --> src/actors.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | fn events(&mut self, evt: Event) { [INFO] [stderr] | ^^^ help: consider using `_evt` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | window.clear(&Color::from(0x777777FF)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7777_77FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scenes.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / match pre_highscore { [INFO] [stderr] 93 | | Some(hs) => { [INFO] [stderr] 94 | | highscore = hs.max(highscore); [INFO] [stderr] 95 | | save_highscore(highscore); [INFO] [stderr] ... | [INFO] [stderr] 98 | | _ => {} [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(hs) = pre_highscore { [INFO] [stderr] 93 | highscore = hs.max(highscore); [INFO] [stderr] 94 | save_highscore(highscore); [INFO] [stderr] 95 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scenes.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / match File::open("highscore.txt") { [INFO] [stderr] 133 | | Ok(mut f) => { [INFO] [stderr] 134 | | let mut s = String::new(); [INFO] [stderr] 135 | | match f.read_to_string(&mut s) { [INFO] [stderr] ... | [INFO] [stderr] 147 | | _ => {} [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let Ok(mut f) = File::open("highscore.txt") { [INFO] [stderr] 133 | let mut s = String::new(); [INFO] [stderr] 134 | match f.read_to_string(&mut s) { [INFO] [stderr] 135 | Ok(_) => { [INFO] [stderr] 136 | match s.parse::() { [INFO] [stderr] 137 | Ok(o) => { hs = o } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scenes.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / match f.read_to_string(&mut s) { [INFO] [stderr] 136 | | Ok(_) => { [INFO] [stderr] 137 | | match s.parse::() { [INFO] [stderr] 138 | | Ok(o) => { hs = o } [INFO] [stderr] ... | [INFO] [stderr] 143 | | _ => {} [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | if let Ok(_) = f.read_to_string(&mut s) { [INFO] [stderr] 136 | match s.parse::() { [INFO] [stderr] 137 | Ok(o) => { hs = o } [INFO] [stderr] 138 | _ => {} [INFO] [stderr] 139 | } [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scenes.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | / match s.parse::() { [INFO] [stderr] 138 | | Ok(o) => { hs = o } [INFO] [stderr] 139 | | _ => {} [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Ok(o) = s.parse::() { hs = o }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scenes.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | f.write_all(format!("{}", hs).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scenes.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | f.flush(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scenes.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | f.write(format!("{}", hs).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scenes.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | f.flush(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ui.rs:131:37 [INFO] [stderr] | [INFO] [stderr] 131 | let mut c = self.fill_color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.fill_color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:132:32 [INFO] [stderr] | [INFO] [stderr] 132 | c.r = (c.r as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:133:32 [INFO] [stderr] | [INFO] [stderr] 133 | c.g = (c.g as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:134:32 [INFO] [stderr] | [INFO] [stderr] 134 | c.b = (c.b as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ui.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | let mut c = self.border_color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.border_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:141:32 [INFO] [stderr] | [INFO] [stderr] 141 | c.r = (c.r as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | c.g = (c.g as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:143:32 [INFO] [stderr] | [INFO] [stderr] 143 | c.b = (c.b as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | / match code { [INFO] [stderr] 79 | | Key::Escape => { window.close() } [INFO] [stderr] 80 | | _ => {} [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Key::Escape = code { window.close() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `evt` [INFO] [stderr] --> src/actors.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | fn events(&mut self, evt: Event) { [INFO] [stderr] | ^^^ help: consider using `_evt` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scenes.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / match pre_highscore { [INFO] [stderr] 93 | | Some(hs) => { [INFO] [stderr] 94 | | highscore = hs.max(highscore); [INFO] [stderr] 95 | | save_highscore(highscore); [INFO] [stderr] ... | [INFO] [stderr] 98 | | _ => {} [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(hs) = pre_highscore { [INFO] [stderr] 93 | highscore = hs.max(highscore); [INFO] [stderr] 94 | save_highscore(highscore); [INFO] [stderr] 95 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scenes.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / match File::open("highscore.txt") { [INFO] [stderr] 133 | | Ok(mut f) => { [INFO] [stderr] 134 | | let mut s = String::new(); [INFO] [stderr] 135 | | match f.read_to_string(&mut s) { [INFO] [stderr] ... | [INFO] [stderr] 147 | | _ => {} [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let Ok(mut f) = File::open("highscore.txt") { [INFO] [stderr] 133 | let mut s = String::new(); [INFO] [stderr] 134 | match f.read_to_string(&mut s) { [INFO] [stderr] 135 | Ok(_) => { [INFO] [stderr] 136 | match s.parse::() { [INFO] [stderr] 137 | Ok(o) => { hs = o } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scenes.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / match f.read_to_string(&mut s) { [INFO] [stderr] 136 | | Ok(_) => { [INFO] [stderr] 137 | | match s.parse::() { [INFO] [stderr] 138 | | Ok(o) => { hs = o } [INFO] [stderr] ... | [INFO] [stderr] 143 | | _ => {} [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | if let Ok(_) = f.read_to_string(&mut s) { [INFO] [stderr] 136 | match s.parse::() { [INFO] [stderr] 137 | Ok(o) => { hs = o } [INFO] [stderr] 138 | _ => {} [INFO] [stderr] 139 | } [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scenes.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | / match s.parse::() { [INFO] [stderr] 138 | | Ok(o) => { hs = o } [INFO] [stderr] 139 | | _ => {} [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Ok(o) = s.parse::() { hs = o }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scenes.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | f.write_all(format!("{}", hs).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scenes.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | f.flush(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scenes.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | f.write(format!("{}", hs).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scenes.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | f.flush(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ui.rs:131:37 [INFO] [stderr] | [INFO] [stderr] 131 | let mut c = self.fill_color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.fill_color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:132:32 [INFO] [stderr] | [INFO] [stderr] 132 | c.r = (c.r as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:133:32 [INFO] [stderr] | [INFO] [stderr] 133 | c.g = (c.g as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:134:32 [INFO] [stderr] | [INFO] [stderr] 134 | c.b = (c.b as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ui.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | let mut c = self.border_color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.border_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:141:32 [INFO] [stderr] | [INFO] [stderr] 141 | c.r = (c.r as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | c.g = (c.g as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:143:32 [INFO] [stderr] | [INFO] [stderr] 143 | c.b = (c.b as f32 * DARKENING_SCALE) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(c.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | / match code { [INFO] [stderr] 79 | | Key::Escape => { window.close() } [INFO] [stderr] 80 | | _ => {} [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Key::Escape = code { window.close() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.54s [INFO] running `"docker" "inspect" "4e738456dace52847b8989a1d9104a6ffee7ccc3f206645d0dbc161d412df082"` [INFO] running `"docker" "rm" "-f" "4e738456dace52847b8989a1d9104a6ffee7ccc3f206645d0dbc161d412df082"` [INFO] [stdout] 4e738456dace52847b8989a1d9104a6ffee7ccc3f206645d0dbc161d412df082