[INFO] updating cached repository thomas9911/minesweeper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/thomas9911/minesweeper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/thomas9911/minesweeper" "work/ex/clippy-test-run/sources/stable/gh/thomas9911/minesweeper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/thomas9911/minesweeper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/thomas9911/minesweeper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thomas9911/minesweeper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thomas9911/minesweeper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 48cdae6304d5f6d7665e11be11e8243d5cb72a96 [INFO] sha for GitHub repo thomas9911/minesweeper: 48cdae6304d5f6d7665e11be11e8243d5cb72a96 [INFO] validating manifest of thomas9911/minesweeper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thomas9911/minesweeper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thomas9911/minesweeper [INFO] finished frobbing thomas9911/minesweeper [INFO] frobbed toml for thomas9911/minesweeper written to work/ex/clippy-test-run/sources/stable/gh/thomas9911/minesweeper/Cargo.toml [INFO] started frobbing thomas9911/minesweeper [INFO] finished frobbing thomas9911/minesweeper [INFO] frobbed toml for thomas9911/minesweeper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thomas9911/minesweeper/Cargo.toml [INFO] crate thomas9911/minesweeper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thomas9911/minesweeper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/thomas9911/minesweeper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 74740865c2271d4d5f0fa09b753d57aba5c315eea2024322c53b78a3daa077dd [INFO] running `"docker" "start" "-a" "74740865c2271d4d5f0fa09b753d57aba5c315eea2024322c53b78a3daa077dd"` [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling khronos_api v3.0.0 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling minesweeper v0.2.0 (/opt/crater/workdir) [INFO] [stderr] Checking arrayvec v0.4.8 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking piston-viewport v0.5.0 [INFO] [stderr] Checking smallvec v0.6.6 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking x11-dl v2.18.3 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking wayland-sys v0.21.4 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling structopt-derive v0.2.13 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Compiling wayland-scanner v0.21.4 [INFO] [stderr] Compiling gl_generator v0.10.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking structopt v0.2.13 [INFO] [stderr] Checking wayland-commons v0.21.4 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Compiling wayland-client v0.21.4 [INFO] [stderr] Compiling wayland-protocols v0.21.4 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Compiling glutin v0.19.0 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking smithay-client-toolkit v0.4.2 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.54.0 [INFO] [stderr] Checking piston_window v0.85.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | cols: cols, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tile.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | cols: cols, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tile.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | / if self.is_legit(a, b){ [INFO] [stderr] 87 | | if self.tiles[a][b].mine { [INFO] [stderr] 88 | | count += 1; [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | if self.is_legit(a, b) && self.tiles[a][b].mine { [INFO] [stderr] 87 | count += 1; [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | const FLAG_CHAR: &'static str = "F"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | const BOMB_CHAR: &'static str = "B"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | const MASK_CHAR: &'static str = "X"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tile.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | / if self.is_legit(a, b){ [INFO] [stderr] 87 | | if self.tiles[a][b].mine { [INFO] [stderr] 88 | | count += 1; [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | if self.is_legit(a, b) && self.tiles[a][b].mine { [INFO] [stderr] 87 | count += 1; [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | const FLAG_CHAR: &'static str = "F"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | const BOMB_CHAR: &'static str = "B"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | const MASK_CHAR: &'static str = "X"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tile.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | fn is_legit(&mut self, x: usize, y: usize) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tile.rs:60:15 [INFO] [stderr] | [INFO] [stderr] 60 | & (self.tiles[x as usize][y as usize].flow_revealed == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.tiles[x as usize][y as usize].flow_revealed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/tile.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / match self.flagged { [INFO] [stderr] 138 | | true => self.flagged = false, [INFO] [stderr] 139 | | false => self.flagged = true, [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.flagged { self.flagged = false } else { self.flagged = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/counter.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | self.time_left = self.reset_time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reset_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | let scale1: f64 = width as f64 / cols as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:42 [INFO] [stderr] | [INFO] [stderr] 62 | let scale1: f64 = width as f64 / cols as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | let scale2: f64 = height as f64 / rows as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:43 [INFO] [stderr] | [INFO] [stderr] 63 | let scale2: f64 = height as f64 / rows as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | let x = mouse_input[0] as f64 / self.scale; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(mouse_input[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let y = mouse_input[1] as f64 / self.scale; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(mouse_input[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match cell.revealed { [INFO] [stderr] 89 | | true => match cell.mine { [INFO] [stderr] 90 | | true => BOMB_CHAR.to_string(), [INFO] [stderr] 91 | | false => match cell.mines_around { [INFO] [stderr] ... | [INFO] [stderr] 99 | | }, [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 88 | if cell.revealed { match cell.mine { [INFO] [stderr] 89 | true => BOMB_CHAR.to_string(), [INFO] [stderr] 90 | false => match cell.mines_around { [INFO] [stderr] 91 | 0 => " ".to_string(), [INFO] [stderr] 92 | _ => cell.mines_around.to_string(), [INFO] [stderr] 93 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | true => match cell.mine { [INFO] [stderr] | _____________________^ [INFO] [stderr] 90 | | true => BOMB_CHAR.to_string(), [INFO] [stderr] 91 | | false => match cell.mines_around { [INFO] [stderr] 92 | | 0 => " ".to_string(), [INFO] [stderr] 93 | | _ => cell.mines_around.to_string(), [INFO] [stderr] 94 | | }, [INFO] [stderr] 95 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 89 | true => if cell.mine { BOMB_CHAR.to_string() } else { match cell.mines_around { [INFO] [stderr] 90 | 0 => " ".to_string(), [INFO] [stderr] 91 | _ => cell.mines_around.to_string(), [INFO] [stderr] 92 | } }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | false => match cell.flagged { [INFO] [stderr] | ______________________^ [INFO] [stderr] 97 | | true => FLAG_CHAR.to_string(), [INFO] [stderr] 98 | | false => MASK_CHAR.to_string(), [INFO] [stderr] 99 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if cell.flagged { FLAG_CHAR.to_string() } else { MASK_CHAR.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:194:47 [INFO] [stderr] | [INFO] [stderr] 194 | let transform = c.transform.trans(mineboard.width as f64 / 4.0, mineboard.height as f64 / 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(mineboard.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:194:77 [INFO] [stderr] | [INFO] [stderr] 194 | let transform = c.transform.trans(mineboard.width as f64 / 4.0, mineboard.height as f64 / 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(mineboard.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tile.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | fn is_legit(&mut self, x: usize, y: usize) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tile.rs:60:15 [INFO] [stderr] | [INFO] [stderr] 60 | & (self.tiles[x as usize][y as usize].flow_revealed == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.tiles[x as usize][y as usize].flow_revealed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/tile.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / match self.flagged { [INFO] [stderr] 138 | | true => self.flagged = false, [INFO] [stderr] 139 | | false => self.flagged = true, [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.flagged { self.flagged = false } else { self.flagged = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/counter.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | self.time_left = self.reset_time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reset_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | let scale1: f64 = width as f64 / cols as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:42 [INFO] [stderr] | [INFO] [stderr] 62 | let scale1: f64 = width as f64 / cols as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | let scale2: f64 = height as f64 / rows as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:43 [INFO] [stderr] | [INFO] [stderr] 63 | let scale2: f64 = height as f64 / rows as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | let x = mouse_input[0] as f64 / self.scale; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(mouse_input[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let y = mouse_input[1] as f64 / self.scale; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(mouse_input[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match cell.revealed { [INFO] [stderr] 89 | | true => match cell.mine { [INFO] [stderr] 90 | | true => BOMB_CHAR.to_string(), [INFO] [stderr] 91 | | false => match cell.mines_around { [INFO] [stderr] ... | [INFO] [stderr] 99 | | }, [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 88 | if cell.revealed { match cell.mine { [INFO] [stderr] 89 | true => BOMB_CHAR.to_string(), [INFO] [stderr] 90 | false => match cell.mines_around { [INFO] [stderr] 91 | 0 => " ".to_string(), [INFO] [stderr] 92 | _ => cell.mines_around.to_string(), [INFO] [stderr] 93 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | true => match cell.mine { [INFO] [stderr] | _____________________^ [INFO] [stderr] 90 | | true => BOMB_CHAR.to_string(), [INFO] [stderr] 91 | | false => match cell.mines_around { [INFO] [stderr] 92 | | 0 => " ".to_string(), [INFO] [stderr] 93 | | _ => cell.mines_around.to_string(), [INFO] [stderr] 94 | | }, [INFO] [stderr] 95 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 89 | true => if cell.mine { BOMB_CHAR.to_string() } else { match cell.mines_around { [INFO] [stderr] 90 | 0 => " ".to_string(), [INFO] [stderr] 91 | _ => cell.mines_around.to_string(), [INFO] [stderr] 92 | } }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | false => match cell.flagged { [INFO] [stderr] | ______________________^ [INFO] [stderr] 97 | | true => FLAG_CHAR.to_string(), [INFO] [stderr] 98 | | false => MASK_CHAR.to_string(), [INFO] [stderr] 99 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if cell.flagged { FLAG_CHAR.to_string() } else { MASK_CHAR.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:194:47 [INFO] [stderr] | [INFO] [stderr] 194 | let transform = c.transform.trans(mineboard.width as f64 / 4.0, mineboard.height as f64 / 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(mineboard.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:194:77 [INFO] [stderr] | [INFO] [stderr] 194 | let transform = c.transform.trans(mineboard.width as f64 / 4.0, mineboard.height as f64 / 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(mineboard.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 19s [INFO] running `"docker" "inspect" "74740865c2271d4d5f0fa09b753d57aba5c315eea2024322c53b78a3daa077dd"` [INFO] running `"docker" "rm" "-f" "74740865c2271d4d5f0fa09b753d57aba5c315eea2024322c53b78a3daa077dd"` [INFO] [stdout] 74740865c2271d4d5f0fa09b753d57aba5c315eea2024322c53b78a3daa077dd