[INFO] updating cached repository thinkbeard/txtr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/thinkbeard/txtr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/thinkbeard/txtr" "work/ex/clippy-test-run/sources/stable/gh/thinkbeard/txtr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/thinkbeard/txtr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/thinkbeard/txtr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thinkbeard/txtr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thinkbeard/txtr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9bbac3bed8989bab859f7b1a7efad1c668492e9e [INFO] sha for GitHub repo thinkbeard/txtr: 9bbac3bed8989bab859f7b1a7efad1c668492e9e [INFO] validating manifest of thinkbeard/txtr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thinkbeard/txtr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thinkbeard/txtr [INFO] finished frobbing thinkbeard/txtr [INFO] frobbed toml for thinkbeard/txtr written to work/ex/clippy-test-run/sources/stable/gh/thinkbeard/txtr/Cargo.toml [INFO] started frobbing thinkbeard/txtr [INFO] finished frobbing thinkbeard/txtr [INFO] frobbed toml for thinkbeard/txtr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thinkbeard/txtr/Cargo.toml [INFO] crate thinkbeard/txtr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thinkbeard/txtr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/thinkbeard/txtr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 613a1f531e2c4e45d2aada88e7076fab1fb3d2a1f1e4669b903d92c39543ef0e [INFO] running `"docker" "start" "-a" "613a1f531e2c4e45d2aada88e7076fab1fb3d2a1f1e4669b903d92c39543ef0e"` [INFO] [stderr] Compiling num-bigint v0.2.1 [INFO] [stderr] Checking ucd-util v0.1.2 [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Checking either v1.4.0 [INFO] [stderr] Checking serde v1.0.23 [INFO] [stderr] Checking arrayvec v0.4.6 [INFO] [stderr] Checking num_cpus v1.7.0 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking inflate v0.4.3 [INFO] [stderr] Checking stb_truetype v0.2.4 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking ordered-float v0.5.2 [INFO] [stderr] Checking regex-syntax v0.6.2 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking regex v0.2.3 [INFO] [stderr] Compiling serde_derive_internals v0.17.0 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Compiling serde_derive v1.0.23 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking regex v1.0.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking docopt v0.8.1 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking env_logger v0.5.12 [INFO] [stderr] Checking quickcheck v0.6.2 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking imageproc v0.16.0 [INFO] [stderr] Checking txtr v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/txtr.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/txtr.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | red: red, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `red` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/txtr.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | green: green, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `green` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/txtr.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | blue: blue, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `blue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/txtr.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/txtr.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | red: red, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `red` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/txtr.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | green: green, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `green` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/txtr.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | blue: blue, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `blue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/txtr.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | img: image::open(path).expect(&format!("Could not load image at {:?}", path)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not load image at {:?}", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/txtr.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | if v > &level { [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/txtr.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | img: image::open(path).expect(&format!("Could not load image at {:?}", path)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not load image at {:?}", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/txtr.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | if v > &level { [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 51.77s [INFO] running `"docker" "inspect" "613a1f531e2c4e45d2aada88e7076fab1fb3d2a1f1e4669b903d92c39543ef0e"` [INFO] running `"docker" "rm" "-f" "613a1f531e2c4e45d2aada88e7076fab1fb3d2a1f1e4669b903d92c39543ef0e"` [INFO] [stdout] 613a1f531e2c4e45d2aada88e7076fab1fb3d2a1f1e4669b903d92c39543ef0e