[INFO] updating cached repository therunomask/Turing [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/therunomask/Turing [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/therunomask/Turing" "work/ex/clippy-test-run/sources/stable/gh/therunomask/Turing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/therunomask/Turing'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/therunomask/Turing" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/therunomask/Turing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/therunomask/Turing'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5f67427b628d77b6d7b2115a254927d1d16a1648 [INFO] sha for GitHub repo therunomask/Turing: 5f67427b628d77b6d7b2115a254927d1d16a1648 [INFO] validating manifest of therunomask/Turing on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of therunomask/Turing on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing therunomask/Turing [INFO] finished frobbing therunomask/Turing [INFO] frobbed toml for therunomask/Turing written to work/ex/clippy-test-run/sources/stable/gh/therunomask/Turing/Cargo.toml [INFO] started frobbing therunomask/Turing [INFO] finished frobbing therunomask/Turing [INFO] frobbed toml for therunomask/Turing written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/therunomask/Turing/Cargo.toml [INFO] crate therunomask/Turing has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting therunomask/Turing against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/therunomask/Turing:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59c2bb822996ff7db47d343b504850d12bfc24028bdec89557037ada1878dd35 [INFO] running `"docker" "start" "-a" "59c2bb822996ff7db47d343b504850d12bfc24028bdec89557037ada1878dd35"` [INFO] [stderr] Checking random_start v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 113 | | if v[2] >= v[3] { [INFO] [stderr] 114 | | out[1] = true; [INFO] [stderr] 115 | | } else { [INFO] [stderr] 116 | | out[2] = true; [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | } else if v[2] >= v[3] { [INFO] [stderr] 113 | out[1] = true; [INFO] [stderr] 114 | } else { [INFO] [stderr] 115 | out[2] = true; [INFO] [stderr] 116 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 113 | | if v[2] >= v[3] { [INFO] [stderr] 114 | | out[1] = true; [INFO] [stderr] 115 | | } else { [INFO] [stderr] 116 | | out[2] = true; [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | } else if v[2] >= v[3] { [INFO] [stderr] 113 | out[1] = true; [INFO] [stderr] 114 | } else { [INFO] [stderr] 115 | out[2] = true; [INFO] [stderr] 116 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `direction` [INFO] [stderr] --> src/main.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let mut direction: bool; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_direction` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `new_state_bool` [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | let mut new_state_bool: Vec; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_new_state_bool` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let mut right: bool; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | mut state_vector: &Vec, [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | mut testband: &mut Band, [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | let mut state_vector_float = vbool_to_vf32(&state_vector); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | let mut new_state = Mat6::matpro(&mat, state_vector_float); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | let mut direction: bool; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | let mut new_state_bool: Vec; [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let mut terminated = testband.mover(direction); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | let mut new_state_return: Vec; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print` [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn print(self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `dot` [INFO] [stderr] --> src/main.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | fn dot(u1: Vec, u2: Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `overwrite` [INFO] [stderr] --> src/main.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn overwrite(&mut self, new_value: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `direction` [INFO] [stderr] --> src/main.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let mut direction: bool; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_direction` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `new_state_bool` [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | let mut new_state_bool: Vec; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_new_state_bool` instead [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:22:11 [INFO] [stderr] | [INFO] [stderr] 22 | while terminated == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!terminated` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let mut right: bool; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | mut state_vector: &Vec, [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] warning: the loop variable `i` is used to index `out` [INFO] [stderr] --> src/main.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for (i, ) in out.iter_mut().enumerate().take(6) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `b` [INFO] [stderr] --> src/main.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | for j in 0..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for (j, ) in b.iter().enumerate().take(6) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | mut testband: &mut Band, [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | let mut state_vector_float = vbool_to_vf32(&state_vector); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | let mut new_state = Mat6::matpro(&mat, state_vector_float); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | zahl = zahl / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `zahl /= 2` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | let mut direction: bool; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | let mut new_state_bool: Vec; [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let mut terminated = testband.mover(direction); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | let mut new_state_return: Vec; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | if (v[0] == true) | (v[1] == true) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `v[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print` [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn print(self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | if (v[0] == true) | (v[1] == true) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `v[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | if (v[0] == true) | (v[2] == true) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `v[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | if (v[0] == true) | (v[2] == true) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `v[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | fn vbool_to_vf32(v: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `dot` [INFO] [stderr] --> src/main.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | fn dot(u1: Vec, u2: Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `overwrite` [INFO] [stderr] --> src/main.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn overwrite(&mut self, new_value: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / let mut right: bool; [INFO] [stderr] 100 | | if v[0] > 0.5 { [INFO] [stderr] 101 | | right = true; [INFO] [stderr] 102 | | } else { [INFO] [stderr] 103 | | right = false; [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let right = if v[0] > 0.5 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | mut state_vector: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:22:11 [INFO] [stderr] | [INFO] [stderr] 22 | while terminated == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!terminated` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / let mut new_state_return: Vec; [INFO] [stderr] 144 | | if terminated == true { [INFO] [stderr] 145 | | print!("The final states are: "); [INFO] [stderr] 146 | | println!("{:?}", new_state_bool); [INFO] [stderr] ... | [INFO] [stderr] 155 | | new_state_return = logic(vec); [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let new_state_return = if terminated == true { ..; new_state_bool } else { ..; logic(vec) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:144:8 [INFO] [stderr] | [INFO] [stderr] 144 | if terminated == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `terminated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | / if self.position < self.band.len() { [INFO] [stderr] 177 | | false [INFO] [stderr] 178 | | } else { [INFO] [stderr] 179 | | true [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(self.position < self.band.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `out` [INFO] [stderr] --> src/main.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for (i, ) in out.iter_mut().enumerate().take(6) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `b` [INFO] [stderr] --> src/main.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | for j in 0..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for (j, ) in b.iter().enumerate().take(6) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | zahl = zahl / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `zahl /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | if (v[0] == true) | (v[1] == true) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `v[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | if (v[0] == true) | (v[1] == true) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `v[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | if (v[0] == true) | (v[2] == true) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `v[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | if (v[0] == true) | (v[2] == true) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `v[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | fn vbool_to_vf32(v: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / let mut right: bool; [INFO] [stderr] 100 | | if v[0] > 0.5 { [INFO] [stderr] 101 | | right = true; [INFO] [stderr] 102 | | } else { [INFO] [stderr] 103 | | right = false; [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let right = if v[0] > 0.5 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | mut state_vector: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / let mut new_state_return: Vec; [INFO] [stderr] 144 | | if terminated == true { [INFO] [stderr] 145 | | print!("The final states are: "); [INFO] [stderr] 146 | | println!("{:?}", new_state_bool); [INFO] [stderr] ... | [INFO] [stderr] 155 | | new_state_return = logic(vec); [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let new_state_return = if terminated == true { ..; new_state_bool } else { ..; logic(vec) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:144:8 [INFO] [stderr] | [INFO] [stderr] 144 | if terminated == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `terminated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | / if self.position < self.band.len() { [INFO] [stderr] 177 | | false [INFO] [stderr] 178 | | } else { [INFO] [stderr] 179 | | true [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(self.position < self.band.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "59c2bb822996ff7db47d343b504850d12bfc24028bdec89557037ada1878dd35"` [INFO] running `"docker" "rm" "-f" "59c2bb822996ff7db47d343b504850d12bfc24028bdec89557037ada1878dd35"` [INFO] [stdout] 59c2bb822996ff7db47d343b504850d12bfc24028bdec89557037ada1878dd35