[INFO] updating cached repository themasch/advent_of_code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/themasch/advent_of_code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/themasch/advent_of_code" "work/ex/clippy-test-run/sources/stable/gh/themasch/advent_of_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/themasch/advent_of_code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/themasch/advent_of_code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/themasch/advent_of_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/themasch/advent_of_code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 006d982fb511f2845f2c4bf476d3210e1a3d98df [INFO] sha for GitHub repo themasch/advent_of_code: 006d982fb511f2845f2c4bf476d3210e1a3d98df [INFO] validating manifest of themasch/advent_of_code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of themasch/advent_of_code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing themasch/advent_of_code [INFO] finished frobbing themasch/advent_of_code [INFO] frobbed toml for themasch/advent_of_code written to work/ex/clippy-test-run/sources/stable/gh/themasch/advent_of_code/Cargo.toml [INFO] started frobbing themasch/advent_of_code [INFO] finished frobbing themasch/advent_of_code [INFO] frobbed toml for themasch/advent_of_code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/themasch/advent_of_code/Cargo.toml [INFO] crate themasch/advent_of_code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting themasch/advent_of_code against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/themasch/advent_of_code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 95795af58a1be9808851e91679b515ce58d111a653a12b6fc11c0befbcd18483 [INFO] running `"docker" "start" "-a" "95795af58a1be9808851e91679b515ce58d111a653a12b6fc11c0befbcd18483"` [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking num_cpus v1.9.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking aoc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/year_2018/day_02.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("../../input/2018/day02.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_02.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return counts.0 * counts.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `counts.0 * counts.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_02.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return (acc.0 + twos, acc.1 + threes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(acc.0 + twos, acc.1 + threes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/year_2018/day_03.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | const INPUT: &'static str = include_str!("../../input/2018/day03.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/year_2018/day_03.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | let offset = ((self.pos.1 + y) as usize * COLUMNS + (x + self.pos.0) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_03.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/year_2018/day_05.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("../../input/2018/day05.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_05.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return reduced; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `reduced` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_05.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return reduced.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reduced.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/year_2018/day_02.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("../../input/2018/day02.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_02.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return counts.0 * counts.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `counts.0 * counts.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_02.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return (acc.0 + twos, acc.1 + threes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(acc.0 + twos, acc.1 + threes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/year_2018/day_03.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | const INPUT: &'static str = include_str!("../../input/2018/day03.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/year_2018/day_03.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | let offset = ((self.pos.1 + y) as usize * COLUMNS + (x + self.pos.0) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_03.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/year_2018/day_05.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("../../input/2018/day05.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_05.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return reduced; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `reduced` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/year_2018/day_05.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return reduced.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reduced.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INPUT` [INFO] [stderr] --> src/year_2018/day_01.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &str = include_str!("../../input/2018/day01.txt"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_input` [INFO] [stderr] --> src/year_2018/day_01.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | fn parse_input(input: &str) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_part1` [INFO] [stderr] --> src/year_2018/day_01.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | fn solve_part1(input: &[i32]) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_part2` [INFO] [stderr] --> src/year_2018/day_01.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | fn solve_part2(input: &[i32]) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run` [INFO] [stderr] --> src/year_2018/day_01.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn run() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INPUT` [INFO] [stderr] --> src/year_2018/day_02.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("../../input/2018/day02.txt"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_input` [INFO] [stderr] --> src/year_2018/day_02.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | fn parse_input(input: &str) -> Vec<&str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_part1` [INFO] [stderr] --> src/year_2018/day_02.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn solve_part1(input: &[&str]) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_part2` [INFO] [stderr] --> src/year_2018/day_02.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | fn solve_part2(input: &[&str]) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run` [INFO] [stderr] --> src/year_2018/day_02.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn run() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `COLUMNS` [INFO] [stderr] --> src/year_2018/day_03.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | const COLUMNS: usize = 1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ROWS` [INFO] [stderr] --> src/year_2018/day_03.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | const ROWS: usize = 1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INPUT` [INFO] [stderr] --> src/year_2018/day_03.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const INPUT: &'static str = include_str!("../../input/2018/day03.txt"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `end` [INFO] [stderr] --> src/year_2018/day_03.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | fn end(&self) -> (u16, u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_to_field` [INFO] [stderr] --> src/year_2018/day_03.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn add_to_field(&self, field: &mut [u8]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `overlaps` [INFO] [stderr] --> src/year_2018/day_03.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn overlaps(&self, other: &Claim) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_input` [INFO] [stderr] --> src/year_2018/day_03.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | fn read_input(input: &str) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_part1` [INFO] [stderr] --> src/year_2018/day_03.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn solve_part1(input: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_part2` [INFO] [stderr] --> src/year_2018/day_03.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | fn solve_part2(input: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run` [INFO] [stderr] --> src/year_2018/day_03.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn run() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/year_2018/day_01.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | accu = accu + *number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accu += *number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/year_2018/day_02.rs:12:40 [INFO] [stderr] | [INFO] [stderr] 12 | let idx = (chr as u8 - 'a' as u8) as usize; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/year_2018/day_02.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | counts[idx] = counts[idx] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counts[idx] += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_03.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | fn solve_part1(input: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_03.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | fn solve_part2(input: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/year_2018/day_05.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / self.iter().filter( | &&poly | match poly { [INFO] [stderr] 65 | | Polymer::Lowercase(x) if x == chr => false, [INFO] [stderr] 66 | | Polymer::Uppercase(x) if x == chr => false, [INFO] [stderr] 67 | | _ => true [INFO] [stderr] 68 | | }).map(| c | c.clone()).collect() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 64 | self.iter().filter( | &&poly | match poly { [INFO] [stderr] 65 | Polymer::Lowercase(x) if x == chr => false, [INFO] [stderr] 66 | Polymer::Uppercase(x) if x == chr => false, [INFO] [stderr] 67 | _ => true [INFO] [stderr] 68 | }).cloned().collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/year_2018/day_05.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | }).map(| c | c.clone()).collect() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_05.rs:83:26 [INFO] [stderr] | [INFO] [stderr] 83 | fn solve_part1(polymers: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Polymer]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_05.rs:89:26 [INFO] [stderr] | [INFO] [stderr] 89 | fn solve_part2(polymers: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Polymer]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run` [INFO] [stderr] --> src/year_2018/day_01.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn run() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run` [INFO] [stderr] --> src/year_2018/day_02.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn run() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run` [INFO] [stderr] --> src/year_2018/day_03.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn run() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/year_2018/day_01.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | accu = accu + *number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accu += *number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/year_2018/day_02.rs:12:40 [INFO] [stderr] | [INFO] [stderr] 12 | let idx = (chr as u8 - 'a' as u8) as usize; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/year_2018/day_02.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | counts[idx] = counts[idx] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counts[idx] += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_03.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | fn solve_part1(input: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_03.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | fn solve_part2(input: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/year_2018/day_05.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / self.iter().filter( | &&poly | match poly { [INFO] [stderr] 65 | | Polymer::Lowercase(x) if x == chr => false, [INFO] [stderr] 66 | | Polymer::Uppercase(x) if x == chr => false, [INFO] [stderr] 67 | | _ => true [INFO] [stderr] 68 | | }).map(| c | c.clone()).collect() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 64 | self.iter().filter( | &&poly | match poly { [INFO] [stderr] 65 | Polymer::Lowercase(x) if x == chr => false, [INFO] [stderr] 66 | Polymer::Uppercase(x) if x == chr => false, [INFO] [stderr] 67 | _ => true [INFO] [stderr] 68 | }).cloned().collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/year_2018/day_05.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | }).map(| c | c.clone()).collect() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_05.rs:83:26 [INFO] [stderr] | [INFO] [stderr] 83 | fn solve_part1(polymers: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Polymer]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/year_2018/day_05.rs:89:26 [INFO] [stderr] | [INFO] [stderr] 89 | fn solve_part2(polymers: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Polymer]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.70s [INFO] running `"docker" "inspect" "95795af58a1be9808851e91679b515ce58d111a653a12b6fc11c0befbcd18483"` [INFO] running `"docker" "rm" "-f" "95795af58a1be9808851e91679b515ce58d111a653a12b6fc11c0befbcd18483"` [INFO] [stdout] 95795af58a1be9808851e91679b515ce58d111a653a12b6fc11c0befbcd18483