[INFO] updating cached repository thecreamedcorn/peg_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/thecreamedcorn/peg_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/thecreamedcorn/peg_rs" "work/ex/clippy-test-run/sources/stable/gh/thecreamedcorn/peg_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/thecreamedcorn/peg_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/thecreamedcorn/peg_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thecreamedcorn/peg_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thecreamedcorn/peg_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 446114320b5baa4cb9ebcab14215fb3871a8ed76 [INFO] sha for GitHub repo thecreamedcorn/peg_rs: 446114320b5baa4cb9ebcab14215fb3871a8ed76 [INFO] validating manifest of thecreamedcorn/peg_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thecreamedcorn/peg_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thecreamedcorn/peg_rs [INFO] finished frobbing thecreamedcorn/peg_rs [INFO] frobbed toml for thecreamedcorn/peg_rs written to work/ex/clippy-test-run/sources/stable/gh/thecreamedcorn/peg_rs/Cargo.toml [INFO] started frobbing thecreamedcorn/peg_rs [INFO] finished frobbing thecreamedcorn/peg_rs [INFO] frobbed toml for thecreamedcorn/peg_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thecreamedcorn/peg_rs/Cargo.toml [INFO] crate thecreamedcorn/peg_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thecreamedcorn/peg_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/thecreamedcorn/peg_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85ca3d5dd44f5f412f5f39697f15f4bf1b87e66a5550a4e69d806d95ba067cd3 [INFO] running `"docker" "start" "-a" "85ca3d5dd44f5f412f5f39697f15f4bf1b87e66a5550a4e69d806d95ba067cd3"` [INFO] [stderr] Checking peg_rs v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/peg_rs/grammar_nodes/and.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new(child: Box) -> Box { [INFO] [stderr] 8 | | Not::new(Not::new(child)) [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `peg_rs::grammar_nodes::anything::Anything` [INFO] [stderr] --> src/peg_rs/grammar_nodes/anything.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Anything { [INFO] [stderr] 11 | | Anything {} [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/peg_rs/grammar_nodes/char_class.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | for ref tester in &self.char_testers { [INFO] [stderr] | ^^^^^^^^^^ ------------------ help: try: `let tester = &&self.char_testers;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/peg_rs/grammar_nodes/char_class.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | fn parse_char(chars: &Vec, loc: usize) -> Option<(char, usize)> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/peg_rs/grammar_nodes/one_or_more.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / loop { [INFO] [stderr] 33 | | match self.child.run(input) { [INFO] [stderr] 34 | | ParseResult::Success(mut parse_data) => { [INFO] [stderr] 35 | | match_data.add(parse_data.match_data); [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ help: try: `while let ParseResult::Success(mut parse_data) = self.child.run(input) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/peg_rs/grammar_nodes/zero_or_more.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / loop { [INFO] [stderr] 24 | | match self.child.run(input) { [INFO] [stderr] 25 | | ParseResult::Success(mut parse_data) => { [INFO] [stderr] 26 | | match_data.add(parse_data.match_data); [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: try: `while let ParseResult::Success(mut parse_data) = self.child.run(input) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/peg_rs/utils/grammar_builder.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | match self.productions.get(&self.root_prod).unwrap().build(&mut productions, &self.productions) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.productions[&self.root_prod]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/peg_rs/utils/parsable.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 33 | | let cur = self.peek(); [INFO] [stderr] 34 | | if cur != Option::None { [INFO] [stderr] 35 | | self.cur += 1 [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | cur [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peg_rs/utils/parse_result.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | pub call_list: Vec<(Rc, Rc)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `peg_rs::utils::match_collector::MatchCollector` [INFO] [stderr] --> src/peg_rs/utils/match_collector.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> MatchCollector { [INFO] [stderr] 13 | | MatchCollector { [INFO] [stderr] 14 | | collection: HashMap::new(), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/peg_rs/utils/match_collector.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | / if self.collection.contains_key(&key) { [INFO] [stderr] 23 | | self.collection.get_mut(&key).unwrap().append(&mut vec); [INFO] [stderr] 24 | | } else { [INFO] [stderr] 25 | | self.collection.insert(key, vec); [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.collection.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/peg_rs/utils/match_collector.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | / if self.collection.contains_key(&key) { [INFO] [stderr] 31 | | self.collection.get_mut(&key).unwrap().push(Rc::new(mc)); [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | self.collection.insert(key, vec!(Rc::new(mc))); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________________^ help: consider using: `self.collection.entry(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num` [INFO] [stderr] --> src/peg_rs/grammar_nodes/char_class.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | let num: Rc> = Rc::new(RefCell::new(5)); [INFO] [stderr] | ^^^ help: consider using `_num` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/peg_rs/grammar_nodes/and.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new(child: Box) -> Box { [INFO] [stderr] 8 | | Not::new(Not::new(child)) [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `peg_rs::grammar_nodes::anything::Anything` [INFO] [stderr] --> src/peg_rs/grammar_nodes/anything.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Anything { [INFO] [stderr] 11 | | Anything {} [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/peg_rs/grammar_nodes/capture.rs:94:55 [INFO] [stderr] | [INFO] [stderr] 94 | *(string_copy.borrow_mut()) = ct.children.get("my_cap").unwrap()[0].content.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ct.children["my_cap"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/peg_rs/grammar_nodes/char_class.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | for ref tester in &self.char_testers { [INFO] [stderr] | ^^^^^^^^^^ ------------------ help: try: `let tester = &&self.char_testers;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/peg_rs/grammar_nodes/char_class.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | fn parse_char(chars: &Vec, loc: usize) -> Option<(char, usize)> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/peg_rs/grammar_nodes/one_or_more.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / loop { [INFO] [stderr] 33 | | match self.child.run(input) { [INFO] [stderr] 34 | | ParseResult::Success(mut parse_data) => { [INFO] [stderr] 35 | | match_data.add(parse_data.match_data); [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ help: try: `while let ParseResult::Success(mut parse_data) = self.child.run(input) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/peg_rs/grammar_nodes/zero_or_more.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / loop { [INFO] [stderr] 24 | | match self.child.run(input) { [INFO] [stderr] 25 | | ParseResult::Success(mut parse_data) => { [INFO] [stderr] 26 | | match_data.add(parse_data.match_data); [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: try: `while let ParseResult::Success(mut parse_data) = self.child.run(input) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/peg_rs/utils/grammar_builder.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | match self.productions.get(&self.root_prod).unwrap().build(&mut productions, &self.productions) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.productions[&self.root_prod]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/peg_rs/utils/parsable.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 33 | | let cur = self.peek(); [INFO] [stderr] 34 | | if cur != Option::None { [INFO] [stderr] 35 | | self.cur += 1 [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | cur [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peg_rs/utils/parse_result.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | pub call_list: Vec<(Rc, Rc)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `peg_rs::utils::match_collector::MatchCollector` [INFO] [stderr] --> src/peg_rs/utils/match_collector.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> MatchCollector { [INFO] [stderr] 13 | | MatchCollector { [INFO] [stderr] 14 | | collection: HashMap::new(), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/peg_rs/utils/match_collector.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | / if self.collection.contains_key(&key) { [INFO] [stderr] 23 | | self.collection.get_mut(&key).unwrap().append(&mut vec); [INFO] [stderr] 24 | | } else { [INFO] [stderr] 25 | | self.collection.insert(key, vec); [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.collection.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/peg_rs/utils/match_collector.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | / if self.collection.contains_key(&key) { [INFO] [stderr] 31 | | self.collection.get_mut(&key).unwrap().push(Rc::new(mc)); [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | self.collection.insert(key, vec!(Rc::new(mc))); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________________^ help: consider using: `self.collection.entry(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/peg_rs/mod.rs:49:36 [INFO] [stderr] | [INFO] [stderr] 49 | if ct.children.get("op").unwrap()[0].content.to_string() == "+" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ct.children["op"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/peg_rs/mod.rs:89:40 [INFO] [stderr] | [INFO] [stderr] 89 | if ct.children.get("op").unwrap()[0].content.to_string() == "*" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ct.children["op"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/peg_rs/mod.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | assert_eq!(stack_orig.borrow()[0], 20.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/peg_rs/mod.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | assert_eq!(stack_orig.borrow()[0], 20.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `peg_rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "85ca3d5dd44f5f412f5f39697f15f4bf1b87e66a5550a4e69d806d95ba067cd3"` [INFO] running `"docker" "rm" "-f" "85ca3d5dd44f5f412f5f39697f15f4bf1b87e66a5550a4e69d806d95ba067cd3"` [INFO] [stdout] 85ca3d5dd44f5f412f5f39697f15f4bf1b87e66a5550a4e69d806d95ba067cd3