[INFO] updating cached repository theHooloovoo/Game_of_Life-Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/theHooloovoo/Game_of_Life-Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/theHooloovoo/Game_of_Life-Rust" "work/ex/clippy-test-run/sources/stable/gh/theHooloovoo/Game_of_Life-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/theHooloovoo/Game_of_Life-Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/theHooloovoo/Game_of_Life-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theHooloovoo/Game_of_Life-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theHooloovoo/Game_of_Life-Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 959f41d6a578a988c02609bc41a57a9eb598910c [INFO] sha for GitHub repo theHooloovoo/Game_of_Life-Rust: 959f41d6a578a988c02609bc41a57a9eb598910c [INFO] validating manifest of theHooloovoo/Game_of_Life-Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of theHooloovoo/Game_of_Life-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing theHooloovoo/Game_of_Life-Rust [INFO] finished frobbing theHooloovoo/Game_of_Life-Rust [INFO] frobbed toml for theHooloovoo/Game_of_Life-Rust written to work/ex/clippy-test-run/sources/stable/gh/theHooloovoo/Game_of_Life-Rust/Cargo.toml [INFO] started frobbing theHooloovoo/Game_of_Life-Rust [INFO] finished frobbing theHooloovoo/Game_of_Life-Rust [INFO] frobbed toml for theHooloovoo/Game_of_Life-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theHooloovoo/Game_of_Life-Rust/Cargo.toml [INFO] crate theHooloovoo/Game_of_Life-Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting theHooloovoo/Game_of_Life-Rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/theHooloovoo/Game_of_Life-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 92d561366af0367004045fc70be00bdb0b6fc42300d5a64a464f4b3fa3edaecd [INFO] running `"docker" "start" "-a" "92d561366af0367004045fc70be00bdb0b6fc42300d5a64a464f4b3fa3edaecd"` [INFO] [stderr] Checking conway_rs v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | return (&self.pospos1, &mut self.pospos2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&self.pospos1, &mut self.pospos2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | return (&self.pospos2, &mut self.pospos1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&self.pospos2, &mut self.pospos1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/reader.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | return (&self.pospos1, &mut self.pospos2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&self.pospos1, &mut self.pospos2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | return (&self.pospos2, &mut self.pospos1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&self.pospos2, &mut self.pospos1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/reader.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `arg_file_name` is never read [INFO] [stderr] --> src/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let mut arg_file_name = "".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `main_grid` is never read [INFO] [stderr] --> src/main.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(data) => main_grid = grid::Grid::load_from_file_data(data), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cell_count` is never read [INFO] [stderr] --> src/grid.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | let mut cell_count = 0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/grid.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / let mut mat = &self.pospos1; [INFO] [stderr] 43 | | if self.state == false { mat = &self.pospos2; } [INFO] [stderr] | |_______________________________________________________^ help: it is more idiomatic to write: `let mat = if self.state == false { &self.pospos2 } else { &self.pospos1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/grid.rs:43:12 [INFO] [stderr] | [INFO] [stderr] 43 | if self.state == false { mat = &self.pospos2; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grid.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn stamp(&mut self, data: &Vec>, x_off: usize, y_off: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/grid.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / let mut mat = &mut self.pospos1; [INFO] [stderr] 78 | | if self.state == false { mat = &mut self.pospos2; } [INFO] [stderr] | |___________________________________________________________^ help: it is more idiomatic to write: `let mat = if self.state == false { &mut self.pospos2 } else { &mut self.pospos1 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/grid.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | if self.state == false { mat = &mut self.pospos2; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/grid.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if self.state == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/grid.rs:138:40 [INFO] [stderr] | [INFO] [stderr] 138 | else { back[y][x] = '1' } // Keep dead [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/grid.rs:137:40 [INFO] [stderr] | [INFO] [stderr] 137 | if cell_count == 3 { back[y][x] = '1' } // Resserect [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/grid.rs:141:59 [INFO] [stderr] | [INFO] [stderr] 141 | else { back[y][x] = '1' } // Kill [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/grid.rs:140:59 [INFO] [stderr] | [INFO] [stderr] 140 | if cell_count == 2 || cell_count == 3 { back[y][x] = '1' } // Keep Alive [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/grid.rs:150:12 [INFO] [stderr] | [INFO] [stderr] 150 | if self.state == true { self.state == false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> src/grid.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | if self.state == true { self.state == false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/grid.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | if self.state == true { self.state == false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/grid.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | if self.state == true { self.state == false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> src/grid.rs:151:33 [INFO] [stderr] | [INFO] [stderr] 151 | else { self.state == true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/grid.rs:151:33 [INFO] [stderr] | [INFO] [stderr] 151 | else { self.state == true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/grid.rs:151:33 [INFO] [stderr] | [INFO] [stderr] 151 | else { self.state == true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reader.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match file.read_to_string(&mut s) { [INFO] [stderr] 23 | | Err(why) => return Err("Couldn't write to file"), [INFO] [stderr] 24 | | Ok(_) => {}, [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { return Err("Couldn't write to file") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `data`. [INFO] [stderr] --> src/reader.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for n in 0..data.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in &data { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `conway_rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: value assigned to `arg_file_name` is never read [INFO] [stderr] --> src/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let mut arg_file_name = "".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `main_grid` is never read [INFO] [stderr] --> src/main.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(data) => main_grid = grid::Grid::load_from_file_data(data), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cell_count` is never read [INFO] [stderr] --> src/grid.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | let mut cell_count = 0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/grid.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / let mut mat = &self.pospos1; [INFO] [stderr] 43 | | if self.state == false { mat = &self.pospos2; } [INFO] [stderr] | |_______________________________________________________^ help: it is more idiomatic to write: `let mat = if self.state == false { &self.pospos2 } else { &self.pospos1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/grid.rs:43:12 [INFO] [stderr] | [INFO] [stderr] 43 | if self.state == false { mat = &self.pospos2; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grid.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn stamp(&mut self, data: &Vec>, x_off: usize, y_off: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/grid.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / let mut mat = &mut self.pospos1; [INFO] [stderr] 78 | | if self.state == false { mat = &mut self.pospos2; } [INFO] [stderr] | |___________________________________________________________^ help: it is more idiomatic to write: `let mat = if self.state == false { &mut self.pospos2 } else { &mut self.pospos1 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/grid.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | if self.state == false { mat = &mut self.pospos2; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/grid.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if self.state == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/grid.rs:138:40 [INFO] [stderr] | [INFO] [stderr] 138 | else { back[y][x] = '1' } // Keep dead [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/grid.rs:137:40 [INFO] [stderr] | [INFO] [stderr] 137 | if cell_count == 3 { back[y][x] = '1' } // Resserect [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/grid.rs:141:59 [INFO] [stderr] | [INFO] [stderr] 141 | else { back[y][x] = '1' } // Kill [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/grid.rs:140:59 [INFO] [stderr] | [INFO] [stderr] 140 | if cell_count == 2 || cell_count == 3 { back[y][x] = '1' } // Keep Alive [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/grid.rs:150:12 [INFO] [stderr] | [INFO] [stderr] 150 | if self.state == true { self.state == false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> src/grid.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | if self.state == true { self.state == false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/grid.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | if self.state == true { self.state == false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/grid.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | if self.state == true { self.state == false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> src/grid.rs:151:33 [INFO] [stderr] | [INFO] [stderr] 151 | else { self.state == true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/grid.rs:151:33 [INFO] [stderr] | [INFO] [stderr] 151 | else { self.state == true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/grid.rs:151:33 [INFO] [stderr] | [INFO] [stderr] 151 | else { self.state == true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reader.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match file.read_to_string(&mut s) { [INFO] [stderr] 23 | | Err(why) => return Err("Couldn't write to file"), [INFO] [stderr] 24 | | Ok(_) => {}, [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { return Err("Couldn't write to file") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `data`. [INFO] [stderr] --> src/reader.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for n in 0..data.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in &data { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `conway_rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "92d561366af0367004045fc70be00bdb0b6fc42300d5a64a464f4b3fa3edaecd"` [INFO] running `"docker" "rm" "-f" "92d561366af0367004045fc70be00bdb0b6fc42300d5a64a464f4b3fa3edaecd"` [INFO] [stdout] 92d561366af0367004045fc70be00bdb0b6fc42300d5a64a464f4b3fa3edaecd