[INFO] updating cached repository the-kenny/herbstmove [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/the-kenny/herbstmove [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/the-kenny/herbstmove" "work/ex/clippy-test-run/sources/stable/gh/the-kenny/herbstmove"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/the-kenny/herbstmove'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/the-kenny/herbstmove" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/the-kenny/herbstmove"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/the-kenny/herbstmove'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8bb8bd1cc6b2b336327827039899822182749e5c [INFO] sha for GitHub repo the-kenny/herbstmove: 8bb8bd1cc6b2b336327827039899822182749e5c [INFO] validating manifest of the-kenny/herbstmove on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of the-kenny/herbstmove on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing the-kenny/herbstmove [INFO] finished frobbing the-kenny/herbstmove [INFO] frobbed toml for the-kenny/herbstmove written to work/ex/clippy-test-run/sources/stable/gh/the-kenny/herbstmove/Cargo.toml [INFO] started frobbing the-kenny/herbstmove [INFO] finished frobbing the-kenny/herbstmove [INFO] frobbed toml for the-kenny/herbstmove written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/the-kenny/herbstmove/Cargo.toml [INFO] crate the-kenny/herbstmove has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting the-kenny/herbstmove against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/the-kenny/herbstmove:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7cf093fe68927c1d74f1190f56e565a56e61d7f373a91a81d5d2876c852b129c [INFO] running `"docker" "start" "-a" "7cf093fe68927c1d74f1190f56e565a56e61d7f373a91a81d5d2876c852b129c"` [INFO] [stderr] Compiling toml v0.2.1 [INFO] [stderr] Compiling error-chain v0.7.2 [INFO] [stderr] Checking libc v0.2.20 [INFO] [stderr] Compiling metadeps v1.1.1 [INFO] [stderr] Compiling x11 v2.12.1 [INFO] [stderr] Checking herbstmove v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/main.rs:51:8 [INFO] [stderr] | [INFO] [stderr] 51 | if display == null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | mask.mask = mem::transmute::<&[u8; 4], *mut u8>(&mask1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mask1 as *const [u8; 4] as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/main.rs:51:8 [INFO] [stderr] | [INFO] [stderr] 51 | if display == null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | mask.mask = mem::transmute::<&[u8; 4], *mut u8>(&mask1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mask1 as *const [u8; 4] as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.46s [INFO] running `"docker" "inspect" "7cf093fe68927c1d74f1190f56e565a56e61d7f373a91a81d5d2876c852b129c"` [INFO] running `"docker" "rm" "-f" "7cf093fe68927c1d74f1190f56e565a56e61d7f373a91a81d5d2876c852b129c"` [INFO] [stdout] 7cf093fe68927c1d74f1190f56e565a56e61d7f373a91a81d5d2876c852b129c