[INFO] updating cached repository the-electric-computer-company/ele [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/the-electric-computer-company/ele [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/the-electric-computer-company/ele" "work/ex/clippy-test-run/sources/stable/gh/the-electric-computer-company/ele"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/the-electric-computer-company/ele'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/the-electric-computer-company/ele" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/the-electric-computer-company/ele"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/the-electric-computer-company/ele'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] db631a66a0464c4bcd93cc4bebd67e7da708b850 [INFO] sha for GitHub repo the-electric-computer-company/ele: db631a66a0464c4bcd93cc4bebd67e7da708b850 [INFO] validating manifest of the-electric-computer-company/ele on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of the-electric-computer-company/ele on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing the-electric-computer-company/ele [INFO] finished frobbing the-electric-computer-company/ele [INFO] frobbed toml for the-electric-computer-company/ele written to work/ex/clippy-test-run/sources/stable/gh/the-electric-computer-company/ele/Cargo.toml [INFO] started frobbing the-electric-computer-company/ele [INFO] finished frobbing the-electric-computer-company/ele [INFO] frobbed toml for the-electric-computer-company/ele written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/the-electric-computer-company/ele/Cargo.toml [INFO] crate the-electric-computer-company/ele has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting the-electric-computer-company/ele against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/the-electric-computer-company/ele:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa9cfec739e3cc64c85ee2cae4ad06c891a0886328273819a2b07c4043a920d3 [INFO] running `"docker" "start" "-a" "aa9cfec739e3cc64c85ee2cae4ad06c891a0886328273819a2b07c4043a920d3"` [INFO] [stderr] Compiling protobuf v2.0.4 [INFO] [stderr] Compiling byteorder v1.2.4 [INFO] [stderr] Compiling cfg-if v0.1.4 [INFO] [stderr] Checking same-file v1.0.2 [INFO] [stderr] Compiling httpbis v0.7.0 [INFO] [stderr] Compiling serde v1.0.71 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking predicates-core v0.9.0 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking unix_socket v0.5.0 [INFO] [stderr] Compiling iovec v0.1.2 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Compiling libsqlite3-sys v0.9.1 [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Compiling log v0.4.3 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking tls-api v0.1.20 [INFO] [stderr] Checking walkdir v2.2.0 [INFO] [stderr] Checking predicates-tree v0.9.0 [INFO] [stderr] Compiling quote v0.6.5 [INFO] [stderr] Checking tempfile v3.0.3 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Compiling bytes v0.4.9 [INFO] [stderr] Checking tls-api-stub v0.1.20 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Compiling protoc v2.0.4 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Checking regex v1.0.2 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Checking tokio-reactor v0.1.3 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking tls-api-native-tls v0.1.20 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking globset v0.4.1 [INFO] [stderr] Checking predicates v0.9.0 [INFO] [stderr] Checking env_logger v0.5.12 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking ignore v0.4.3 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking globwalk v0.3.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking assert_fs v0.9.0 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-uds v0.1.7 [INFO] [stderr] Checking tokio-tls-api v0.1.20 [INFO] [stderr] Compiling protobuf-codegen v2.0.4 [INFO] [stderr] Compiling grpc-compiler v0.5.0 [INFO] [stderr] Compiling protoc-rust v2.0.4 [INFO] [stderr] Checking grpc v0.5.0 [INFO] [stderr] Compiling protoc-rust-grpc v0.5.0 [INFO] [stderr] Compiling ele v0.0.0 (/opt/crater/workdir) [INFO] [stderr] Checking rusqlite v0.13.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/collection_search.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | CollectionSearchRequest { node_id: node_id } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `node_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/svc/node.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/svc/node_grpc.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/collection_search.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | CollectionSearchRequest { node_id: node_id } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `node_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/svc/node.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/svc/node_grpc.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/svc/node.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/svc/node.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/testing.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | FLAG.call_once(|| env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `env_logger::init` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/library.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | let foo = tempdir.child("foo"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/library.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | let foo = tempdir.child("foo"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/library.rs:375:9 [INFO] [stderr] | [INFO] [stderr] 375 | let bar = tempdir.child("foo/bar"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/library.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | let foo = tempdir.child("sub/foo"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 31s [INFO] running `"docker" "inspect" "aa9cfec739e3cc64c85ee2cae4ad06c891a0886328273819a2b07c4043a920d3"` [INFO] running `"docker" "rm" "-f" "aa9cfec739e3cc64c85ee2cae4ad06c891a0886328273819a2b07c4043a920d3"` [INFO] [stdout] aa9cfec739e3cc64c85ee2cae4ad06c891a0886328273819a2b07c4043a920d3