[INFO] updating cached repository the-code-innovator/snake-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/the-code-innovator/snake-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/the-code-innovator/snake-rust" "work/ex/clippy-test-run/sources/stable/gh/the-code-innovator/snake-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/the-code-innovator/snake-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/the-code-innovator/snake-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/the-code-innovator/snake-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/the-code-innovator/snake-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91a45fc11ed8150dfce4cf19d9428b1158afe1f4 [INFO] sha for GitHub repo the-code-innovator/snake-rust: 91a45fc11ed8150dfce4cf19d9428b1158afe1f4 [INFO] validating manifest of the-code-innovator/snake-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of the-code-innovator/snake-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing the-code-innovator/snake-rust [INFO] finished frobbing the-code-innovator/snake-rust [INFO] frobbed toml for the-code-innovator/snake-rust written to work/ex/clippy-test-run/sources/stable/gh/the-code-innovator/snake-rust/Cargo.toml [INFO] started frobbing the-code-innovator/snake-rust [INFO] finished frobbing the-code-innovator/snake-rust [INFO] frobbed toml for the-code-innovator/snake-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/the-code-innovator/snake-rust/Cargo.toml [INFO] crate the-code-innovator/snake-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting the-code-innovator/snake-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/the-code-innovator/snake-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d3931636f234f97ae5959f05ecab94baeb954fe80ffa8ffbfebe0438ac8c3db [INFO] running `"docker" "start" "-a" "0d3931636f234f97ae5959f05ecab94baeb954fe80ffa8ffbfebe0438ac8c3db"` [INFO] [stderr] Compiling proc-macro2 v0.4.23 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking piston-viewport v0.4.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking wayland-commons v0.21.4 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking rusttype v0.7.2 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking wayland-client v0.21.4 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking piston2d-graphics v0.27.0 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Compiling syn v0.15.20 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking wayland-protocols v0.21.4 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking smithay-client-toolkit v0.4.1 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking pistoncore-input v0.22.0 [INFO] [stderr] Checking pistoncore-window v0.33.0 [INFO] [stderr] Checking pistoncore-event_loop v0.38.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.50.0 [INFO] [stderr] Checking piston v0.38.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.53.0 [INFO] [stderr] Checking piston_window v0.84.0 [INFO] [stderr] Checking snake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:129:3 [INFO] [stderr] | [INFO] [stderr] 129 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:129:3 [INFO] [stderr] | [INFO] [stderr] 129 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:2 [INFO] [stderr] | [INFO] [stderr] 7 | (game_co_ordinate as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_co_ordinate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | BLOCK_SIZE * (width as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | BLOCK_SIZE * (height as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | match direction { [INFO] [stderr] | _________^ [INFO] [stderr] 71 | | Some(d) => self.direction = d, [INFO] [stderr] 72 | | None => () [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = direction { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:103:3 [INFO] [stderr] | [INFO] [stderr] 103 | match direction { [INFO] [stderr] | _________^ [INFO] [stderr] 104 | | Some(d) => moving_direction = d, [INFO] [stderr] 105 | | None => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = direction { moving_direction = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:2 [INFO] [stderr] | [INFO] [stderr] 7 | (game_co_ordinate as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_co_ordinate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | BLOCK_SIZE * (width as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | BLOCK_SIZE * (height as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | match direction { [INFO] [stderr] | _________^ [INFO] [stderr] 71 | | Some(d) => self.direction = d, [INFO] [stderr] 72 | | None => () [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = direction { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:103:3 [INFO] [stderr] | [INFO] [stderr] 103 | match direction { [INFO] [stderr] | _________^ [INFO] [stderr] 104 | | Some(d) => moving_direction = d, [INFO] [stderr] 105 | | None => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = direction { moving_direction = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 44s [INFO] running `"docker" "inspect" "0d3931636f234f97ae5959f05ecab94baeb954fe80ffa8ffbfebe0438ac8c3db"` [INFO] running `"docker" "rm" "-f" "0d3931636f234f97ae5959f05ecab94baeb954fe80ffa8ffbfebe0438ac8c3db"` [INFO] [stdout] 0d3931636f234f97ae5959f05ecab94baeb954fe80ffa8ffbfebe0438ac8c3db