[INFO] updating cached repository textcamp/server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/textcamp/server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/textcamp/server" "work/ex/clippy-test-run/sources/stable/gh/textcamp/server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/textcamp/server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/textcamp/server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/textcamp/server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/textcamp/server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d0f7873914b3f82fd16e699efa8415311ec6e765 [INFO] sha for GitHub repo textcamp/server: d0f7873914b3f82fd16e699efa8415311ec6e765 [INFO] validating manifest of textcamp/server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of textcamp/server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing textcamp/server [INFO] finished frobbing textcamp/server [INFO] frobbed toml for textcamp/server written to work/ex/clippy-test-run/sources/stable/gh/textcamp/server/Cargo.toml [INFO] started frobbing textcamp/server [INFO] finished frobbing textcamp/server [INFO] frobbed toml for textcamp/server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/textcamp/server/Cargo.toml [INFO] crate textcamp/server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting textcamp/server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/textcamp/server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a9170d3946e1b2af20ff11140187e773aaea734f9da2e7ef4aaf4dfee66cf862 [INFO] running `"docker" "start" "-a" "a9170d3946e1b2af20ff11140187e773aaea734f9da2e7ef4aaf4dfee66cf862"` [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking crossbeam-utils v0.6.2 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling serde_derive v1.0.81 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking tokio-timer v0.2.8 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking crossbeam-deque v0.6.2 [INFO] [stderr] Checking crossbeam-channel v0.3.3 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.14 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking trust-dns-resolver v0.10.0 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking actix v0.7.8 [INFO] [stderr] Checking actix-net v0.2.4 [INFO] [stderr] Checking actix-web v0.7.15 [INFO] [stderr] Checking text-camp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hero.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn set_current_space(&mut self, space_id: &Identifier) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hero_manager.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | hero_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hero_manager.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | space_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hero_manager.rs:41:42 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn current_space(&self, hero_id: &Identifier) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/inventory.rs:16:36 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn add(&mut self, item_id: &Identifier) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/inventory.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn remove(&mut self, item_id: &Identifier) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/inventory.rs:42:34 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn count(&self, item_id: &Identifier) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/item.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn load(id: &Identifier) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/item_manager.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn get(&mut self, item_id: &Identifier) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/item_manager.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn load(&mut self, id: &Identifier) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/persistable.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn path(id: &Identifier, suffix: &'static str) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | fn new(id: &Identifier) -> Self; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | fn load(id: &Identifier) -> Result; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:15:32 [INFO] [stderr] | [INFO] [stderr] 15 | fn get(&self, thesbian_id: &Identifier) -> Option<&T> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | fn inventory(&mut self, thesbian_id: &Identifier) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:39:34 [INFO] [stderr] | [INFO] [stderr] 39 | fn items(&self, thesbian_id: &Identifier) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | thesbian_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | item_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | thesbian_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | item_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | fn load(&mut self, id: &Identifier) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | hero_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | space_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | hero_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hero.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn set_current_space(&mut self, space_id: &Identifier) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:273:39 [INFO] [stderr] | [INFO] [stderr] 273 | fn space_for_hero(&self, hero_id: &Identifier) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:285:50 [INFO] [stderr] | [INFO] [stderr] 285 | fn item_index_for_space(&mut self, space_id: &Identifier) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:302:48 [INFO] [stderr] | [INFO] [stderr] 302 | fn item_index_for_hero(&mut self, hero_id: &Identifier) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hero_manager.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | hero_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hero_manager.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | space_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hero_manager.rs:41:42 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn current_space(&self, hero_id: &Identifier) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/inventory.rs:16:36 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn add(&mut self, item_id: &Identifier) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/inventory.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn remove(&mut self, item_id: &Identifier) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/inventory.rs:42:34 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn count(&self, item_id: &Identifier) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/item.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn load(id: &Identifier) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/item_manager.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn get(&mut self, item_id: &Identifier) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/item_manager.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn load(&mut self, id: &Identifier) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/persistable.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn path(id: &Identifier, suffix: &'static str) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | fn new(id: &Identifier) -> Self; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | fn load(id: &Identifier) -> Result; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:15:32 [INFO] [stderr] | [INFO] [stderr] 15 | fn get(&self, thesbian_id: &Identifier) -> Option<&T> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | fn inventory(&mut self, thesbian_id: &Identifier) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:39:34 [INFO] [stderr] | [INFO] [stderr] 39 | fn items(&self, thesbian_id: &Identifier) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | thesbian_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | item_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | thesbian_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | item_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/thesbian_manager.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | fn load(&mut self, id: &Identifier) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | hero_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | space_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | hero_id: &Identifier, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:273:39 [INFO] [stderr] | [INFO] [stderr] 273 | fn space_for_hero(&self, hero_id: &Identifier) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:285:50 [INFO] [stderr] | [INFO] [stderr] 285 | fn item_index_for_space(&mut self, space_id: &Identifier) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/world.rs:302:48 [INFO] [stderr] | [INFO] [stderr] 302 | fn item_index_for_hero(&mut self, hero_id: &Identifier) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `"docker" "inspect" "a9170d3946e1b2af20ff11140187e773aaea734f9da2e7ef4aaf4dfee66cf862"` [INFO] running `"docker" "rm" "-f" "a9170d3946e1b2af20ff11140187e773aaea734f9da2e7ef4aaf4dfee66cf862"` [INFO] [stdout] a9170d3946e1b2af20ff11140187e773aaea734f9da2e7ef4aaf4dfee66cf862