[INFO] updating cached repository teuron/rust-graphic-lib [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/teuron/rust-graphic-lib [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/teuron/rust-graphic-lib" "work/ex/clippy-test-run/sources/stable/gh/teuron/rust-graphic-lib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/teuron/rust-graphic-lib'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/teuron/rust-graphic-lib" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teuron/rust-graphic-lib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teuron/rust-graphic-lib'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3e55268e8551a5c6a41901fdc61bbb9716c28ba6 [INFO] sha for GitHub repo teuron/rust-graphic-lib: 3e55268e8551a5c6a41901fdc61bbb9716c28ba6 [INFO] validating manifest of teuron/rust-graphic-lib on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of teuron/rust-graphic-lib on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing teuron/rust-graphic-lib [INFO] finished frobbing teuron/rust-graphic-lib [INFO] frobbed toml for teuron/rust-graphic-lib written to work/ex/clippy-test-run/sources/stable/gh/teuron/rust-graphic-lib/Cargo.toml [INFO] started frobbing teuron/rust-graphic-lib [INFO] finished frobbing teuron/rust-graphic-lib [INFO] frobbed toml for teuron/rust-graphic-lib written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teuron/rust-graphic-lib/Cargo.toml [INFO] crate teuron/rust-graphic-lib has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting teuron/rust-graphic-lib against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/teuron/rust-graphic-lib:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89aef9a13e642ff259f91e0b2e9d90b3d984f72aaa82e3b76d5c85c9c4695183 [INFO] running `"docker" "start" "-a" "89aef9a13e642ff259f91e0b2e9d90b3d984f72aaa82e3b76d5c85c9c4695183"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `graphic_bin`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: unused manifest key: batches [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Checking num-bigint v0.1.37 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking flate2 v0.2.17 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking raster v0.1.0 [INFO] [stderr] Checking graphic_library v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/point2d.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/point2d.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/point2d.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/point2d.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | z: z, [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/point2d.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | color: color [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/line2d.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/line2d.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | to: to [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometric/line2d.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | let g = interpolate(self.from.get_color().g as f64, self.to.get_color().g as f64, dif); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geometric/line2d.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | let b = interpolate(self.from.get_color().b as f64, self.to.get_color().b as f64, dif); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/point2d.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/point2d.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | z: z, [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/point2d.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | color: color [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/line2d.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/line2d.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | to: to [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometric/line2d.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | let g = interpolate(self.from.get_color().g as f64, self.to.get_color().g as f64, dif); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geometric/line2d.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | let b = interpolate(self.from.get_color().b as f64, self.to.get_color().b as f64, dif); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/triangle2d.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/triangle2d.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/triangle2d.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | c: c [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometric/triangle2d.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | let g = interpolate_barycentric(self.a.get_color().g as f64, self.b.get_color().g as f64, self.c.get_color().g as f64, alpha, beta, gamma); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geometric/triangle2d.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | let b = interpolate_barycentric(self.a.get_color().b as f64, self.b.get_color().b as f64, self.c.get_color().b as f64, alpha, beta, gamma); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/triangle2d.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/triangle2d.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/triangle2d.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | c: c [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometric/triangle2d.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | let g = interpolate_barycentric(self.a.get_color().g as f64, self.b.get_color().g as f64, self.c.get_color().g as f64, alpha, beta, gamma); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/circle2d.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | Circle2D { r: r, m: m } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geometric/triangle2d.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | let b = interpolate_barycentric(self.a.get_color().b as f64, self.b.get_color().b as f64, self.c.get_color().b as f64, alpha, beta, gamma); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/circle2d.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | Circle2D { r: r, m: m } [INFO] [stderr] | ^^^^ help: replace it with: `m` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/circle2d.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | Circle2D { r: r, m: m } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometric/circle2d.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | Circle2D { r: r, m: m } [INFO] [stderr] | ^^^^ help: replace it with: `m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/geometric/mod.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | mod geometric; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/geometric/mod.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | mod geometric; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | x: self.x.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | y: self.y.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | z: self.z.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:136:32 [INFO] [stderr] | [INFO] [stderr] 136 | color: Color::rgba(self.color.r.clone(), self.color.g.clone(), self.color.b.clone(), self.color.a.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color.r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:136:54 [INFO] [stderr] | [INFO] [stderr] 136 | color: Color::rgba(self.color.r.clone(), self.color.g.clone(), self.color.b.clone(), self.color.a.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color.g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:136:76 [INFO] [stderr] | [INFO] [stderr] 136 | color: Color::rgba(self.color.r.clone(), self.color.g.clone(), self.color.b.clone(), self.color.a.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color.b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:136:98 [INFO] [stderr] | [INFO] [stderr] 136 | color: Color::rgba(self.color.r.clone(), self.color.g.clone(), self.color.b.clone(), self.color.a.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/geometric/line2d.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / let err_slow: f64; [INFO] [stderr] 57 | | if dx > dy { [INFO] [stderr] 58 | | ppx = sgnx; [INFO] [stderr] 59 | | err_fast = dy as f64; [INFO] [stderr] ... | [INFO] [stderr] 64 | | err_slow = dy as f64; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let err_slow = if dx > dy { ..; dx as f64 } else { ..; dy as f64 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | err_fast = dy as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dy)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:60:24 [INFO] [stderr] | [INFO] [stderr] 60 | err_slow = dx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | err_fast = dx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | err_slow = dy as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | let dif = ((x as f64) - self.from.x).abs() / (dx as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:85:58 [INFO] [stderr] | [INFO] [stderr] 85 | let dif = ((x as f64) - self.from.x).abs() / (dx as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:86:33 [INFO] [stderr] | [INFO] [stderr] 86 | let r = interpolate(self.from.get_color().r as f64, self.to.get_color().r as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.from.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:86:65 [INFO] [stderr] | [INFO] [stderr] 86 | let r = interpolate(self.from.get_color().r as f64, self.to.get_color().r as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.to.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | let g = interpolate(self.from.get_color().g as f64, self.to.get_color().g as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.from.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:87:65 [INFO] [stderr] | [INFO] [stderr] 87 | let g = interpolate(self.from.get_color().g as f64, self.to.get_color().g as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.to.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:88:33 [INFO] [stderr] | [INFO] [stderr] 88 | let b = interpolate(self.from.get_color().b as f64, self.to.get_color().b as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.from.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:88:65 [INFO] [stderr] | [INFO] [stderr] 88 | let b = interpolate(self.from.get_color().b as f64, self.to.get_color().b as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.to.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:111:50 [INFO] [stderr] | [INFO] [stderr] 111 | canvas.set_pixel(x0, y0, Color::rgb(((color.r as f32) * test) as u8, (color.g as f32 * test) as u8, (color.b as f32 * test) as u8)).unwrap();//TODO Add Color and mixing [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:111:83 [INFO] [stderr] | [INFO] [stderr] 111 | canvas.set_pixel(x0, y0, Color::rgb(((color.r as f32) * test) as u8, (color.g as f32 * test) as u8, (color.b as f32 * test) as u8)).unwrap();//TODO Add Color and mixing [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:111:114 [INFO] [stderr] | [INFO] [stderr] 111 | canvas.set_pixel(x0, y0, Color::rgb(((color.r as f32) * test) as u8, (color.g as f32 * test) as u8, (color.b as f32 * test) as u8)).unwrap();//TODO Add Color and mixing [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:119:63 [INFO] [stderr] | [INFO] [stderr] 119 | canvas.set_pixel(x0, y0 + sy, Color::rgb((color.r as f32 * tt) as u8, (color.g as f32 * tt) as u8, (color.b as f32 * tt) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:119:92 [INFO] [stderr] | [INFO] [stderr] 119 | canvas.set_pixel(x0, y0 + sy, Color::rgb((color.r as f32 * tt) as u8, (color.g as f32 * tt) as u8, (color.b as f32 * tt) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:119:121 [INFO] [stderr] | [INFO] [stderr] 119 | canvas.set_pixel(x0, y0 + sy, Color::rgb((color.r as f32 * tt) as u8, (color.g as f32 * tt) as u8, (color.b as f32 * tt) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:128:63 [INFO] [stderr] | [INFO] [stderr] 128 | canvas.set_pixel(x2 + sx, y0, Color::rgb((color.r as f32 * base) as u8, (color.g as f32 * base) as u8, (color.b as f32 * base) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:128:94 [INFO] [stderr] | [INFO] [stderr] 128 | canvas.set_pixel(x2 + sx, y0, Color::rgb((color.r as f32 * base) as u8, (color.g as f32 * base) as u8, (color.b as f32 * base) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:128:125 [INFO] [stderr] | [INFO] [stderr] 128 | canvas.set_pixel(x2 + sx, y0, Color::rgb((color.r as f32 * base) as u8, (color.g as f32 * base) as u8, (color.b as f32 * base) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `x2` and `x3` manually [INFO] [stderr] --> src/geometric/triangle2d.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | / let mut t = x2; [INFO] [stderr] 66 | | x2 = x3; [INFO] [stderr] 67 | | x3 = t; [INFO] [stderr] | |__________________^ help: try: `std::mem::swap(&mut x2, &mut x3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let x = xs as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(xs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | let y = ys as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ys)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:96:53 [INFO] [stderr] | [INFO] [stderr] 96 | let r = interpolate_barycentric(self.a.get_color().r as f64, self.b.get_color().r as f64, self.c.get_color().r as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.a.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:96:82 [INFO] [stderr] | [INFO] [stderr] 96 | let r = interpolate_barycentric(self.a.get_color().r as f64, self.b.get_color().r as f64, self.c.get_color().r as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.b.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:96:111 [INFO] [stderr] | [INFO] [stderr] 96 | let r = interpolate_barycentric(self.a.get_color().r as f64, self.b.get_color().r as f64, self.c.get_color().r as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.c.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:97:53 [INFO] [stderr] | [INFO] [stderr] 97 | let g = interpolate_barycentric(self.a.get_color().g as f64, self.b.get_color().g as f64, self.c.get_color().g as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.a.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:97:82 [INFO] [stderr] | [INFO] [stderr] 97 | let g = interpolate_barycentric(self.a.get_color().g as f64, self.b.get_color().g as f64, self.c.get_color().g as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.b.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:97:111 [INFO] [stderr] | [INFO] [stderr] 97 | let g = interpolate_barycentric(self.a.get_color().g as f64, self.b.get_color().g as f64, self.c.get_color().g as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.c.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:98:53 [INFO] [stderr] | [INFO] [stderr] 98 | let b = interpolate_barycentric(self.a.get_color().b as f64, self.b.get_color().b as f64, self.c.get_color().b as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.a.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:98:82 [INFO] [stderr] | [INFO] [stderr] 98 | let b = interpolate_barycentric(self.a.get_color().b as f64, self.b.get_color().b as f64, self.c.get_color().b as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.b.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:98:111 [INFO] [stderr] | [INFO] [stderr] 98 | let b = interpolate_barycentric(self.a.get_color().b as f64, self.b.get_color().b as f64, self.c.get_color().b as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.c.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/geometric/circle2d.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | self.r = self.r * sx; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r *= sx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | x: self.x.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | y: self.y.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | z: self.z.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:136:32 [INFO] [stderr] | [INFO] [stderr] 136 | color: Color::rgba(self.color.r.clone(), self.color.g.clone(), self.color.b.clone(), self.color.a.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color.r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:136:54 [INFO] [stderr] | [INFO] [stderr] 136 | color: Color::rgba(self.color.r.clone(), self.color.g.clone(), self.color.b.clone(), self.color.a.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color.g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:136:76 [INFO] [stderr] | [INFO] [stderr] 136 | color: Color::rgba(self.color.r.clone(), self.color.g.clone(), self.color.b.clone(), self.color.a.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color.b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometric/point2d.rs:136:98 [INFO] [stderr] | [INFO] [stderr] 136 | color: Color::rgba(self.color.r.clone(), self.color.g.clone(), self.color.b.clone(), self.color.a.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometric/point2d.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | assert_eq!(5.0, point.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometric/point2d.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | assert_eq!(5.0, point.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometric/point2d.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | assert_eq!(3.0, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometric/point2d.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | assert_eq!(3.0, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometric/point2d.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | assert_eq!(1.0, point.z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometric/point2d.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | assert_eq!(1.0, point.z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometric/point2d.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(15.0, point.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometric/point2d.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(15.0, point.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometric/point2d.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | assert_eq!(5.0, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometric/point2d.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | assert_eq!(5.0, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometric/point2d.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | assert_eq!(20.0, point.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometric/point2d.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | assert_eq!(20.0, point.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometric/point2d.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | assert_eq!(1.0, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometric/point2d.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | assert_eq!(1.0, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometric/point2d.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | assert_eq!(19.0, point.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometric/point2d.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | assert_eq!(19.0, point.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometric/point2d.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(1.8, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometric/point2d.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(1.8, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/geometric/line2d.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / let err_slow: f64; [INFO] [stderr] 57 | | if dx > dy { [INFO] [stderr] 58 | | ppx = sgnx; [INFO] [stderr] 59 | | err_fast = dy as f64; [INFO] [stderr] ... | [INFO] [stderr] 64 | | err_slow = dy as f64; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let err_slow = if dx > dy { ..; dx as f64 } else { ..; dy as f64 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | err_fast = dy as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dy)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:60:24 [INFO] [stderr] | [INFO] [stderr] 60 | err_slow = dx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | err_fast = dx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | err_slow = dy as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | let dif = ((x as f64) - self.from.x).abs() / (dx as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:85:58 [INFO] [stderr] | [INFO] [stderr] 85 | let dif = ((x as f64) - self.from.x).abs() / (dx as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:86:33 [INFO] [stderr] | [INFO] [stderr] 86 | let r = interpolate(self.from.get_color().r as f64, self.to.get_color().r as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.from.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:86:65 [INFO] [stderr] | [INFO] [stderr] 86 | let r = interpolate(self.from.get_color().r as f64, self.to.get_color().r as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.to.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | let g = interpolate(self.from.get_color().g as f64, self.to.get_color().g as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.from.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:87:65 [INFO] [stderr] | [INFO] [stderr] 87 | let g = interpolate(self.from.get_color().g as f64, self.to.get_color().g as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.to.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:88:33 [INFO] [stderr] | [INFO] [stderr] 88 | let b = interpolate(self.from.get_color().b as f64, self.to.get_color().b as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.from.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:88:65 [INFO] [stderr] | [INFO] [stderr] 88 | let b = interpolate(self.from.get_color().b as f64, self.to.get_color().b as f64, dif); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.to.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:111:50 [INFO] [stderr] | [INFO] [stderr] 111 | canvas.set_pixel(x0, y0, Color::rgb(((color.r as f32) * test) as u8, (color.g as f32 * test) as u8, (color.b as f32 * test) as u8)).unwrap();//TODO Add Color and mixing [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:111:83 [INFO] [stderr] | [INFO] [stderr] 111 | canvas.set_pixel(x0, y0, Color::rgb(((color.r as f32) * test) as u8, (color.g as f32 * test) as u8, (color.b as f32 * test) as u8)).unwrap();//TODO Add Color and mixing [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:111:114 [INFO] [stderr] | [INFO] [stderr] 111 | canvas.set_pixel(x0, y0, Color::rgb(((color.r as f32) * test) as u8, (color.g as f32 * test) as u8, (color.b as f32 * test) as u8)).unwrap();//TODO Add Color and mixing [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:119:63 [INFO] [stderr] | [INFO] [stderr] 119 | canvas.set_pixel(x0, y0 + sy, Color::rgb((color.r as f32 * tt) as u8, (color.g as f32 * tt) as u8, (color.b as f32 * tt) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:119:92 [INFO] [stderr] | [INFO] [stderr] 119 | canvas.set_pixel(x0, y0 + sy, Color::rgb((color.r as f32 * tt) as u8, (color.g as f32 * tt) as u8, (color.b as f32 * tt) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:119:121 [INFO] [stderr] | [INFO] [stderr] 119 | canvas.set_pixel(x0, y0 + sy, Color::rgb((color.r as f32 * tt) as u8, (color.g as f32 * tt) as u8, (color.b as f32 * tt) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:128:63 [INFO] [stderr] | [INFO] [stderr] 128 | canvas.set_pixel(x2 + sx, y0, Color::rgb((color.r as f32 * base) as u8, (color.g as f32 * base) as u8, (color.b as f32 * base) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:128:94 [INFO] [stderr] | [INFO] [stderr] 128 | canvas.set_pixel(x2 + sx, y0, Color::rgb((color.r as f32 * base) as u8, (color.g as f32 * base) as u8, (color.b as f32 * base) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometric/line2d.rs:128:125 [INFO] [stderr] | [INFO] [stderr] 128 | canvas.set_pixel(x2 + sx, y0, Color::rgb((color.r as f32 * base) as u8, (color.g as f32 * base) as u8, (color.b as f32 * base) as u8)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `x2` and `x3` manually [INFO] [stderr] --> src/geometric/triangle2d.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | / let mut t = x2; [INFO] [stderr] 66 | | x2 = x3; [INFO] [stderr] 67 | | x3 = t; [INFO] [stderr] | |__________________^ help: try: `std::mem::swap(&mut x2, &mut x3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let x = xs as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(xs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | let y = ys as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ys)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:96:53 [INFO] [stderr] | [INFO] [stderr] 96 | let r = interpolate_barycentric(self.a.get_color().r as f64, self.b.get_color().r as f64, self.c.get_color().r as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.a.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:96:82 [INFO] [stderr] | [INFO] [stderr] 96 | let r = interpolate_barycentric(self.a.get_color().r as f64, self.b.get_color().r as f64, self.c.get_color().r as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.b.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:96:111 [INFO] [stderr] | [INFO] [stderr] 96 | let r = interpolate_barycentric(self.a.get_color().r as f64, self.b.get_color().r as f64, self.c.get_color().r as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.c.get_color().r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:97:53 [INFO] [stderr] | [INFO] [stderr] 97 | let g = interpolate_barycentric(self.a.get_color().g as f64, self.b.get_color().g as f64, self.c.get_color().g as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.a.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:97:82 [INFO] [stderr] | [INFO] [stderr] 97 | let g = interpolate_barycentric(self.a.get_color().g as f64, self.b.get_color().g as f64, self.c.get_color().g as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.b.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:97:111 [INFO] [stderr] | [INFO] [stderr] 97 | let g = interpolate_barycentric(self.a.get_color().g as f64, self.b.get_color().g as f64, self.c.get_color().g as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.c.get_color().g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:98:53 [INFO] [stderr] | [INFO] [stderr] 98 | let b = interpolate_barycentric(self.a.get_color().b as f64, self.b.get_color().b as f64, self.c.get_color().b as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.a.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:98:82 [INFO] [stderr] | [INFO] [stderr] 98 | let b = interpolate_barycentric(self.a.get_color().b as f64, self.b.get_color().b as f64, self.c.get_color().b as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.b.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geometric/triangle2d.rs:98:111 [INFO] [stderr] | [INFO] [stderr] 98 | let b = interpolate_barycentric(self.a.get_color().b as f64, self.b.get_color().b as f64, self.c.get_color().b as f64, alpha, beta, gamma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.c.get_color().b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/geometric/circle2d.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | self.r = self.r * sx; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r *= sx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `graphic_library`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:43:77 [INFO] [stderr] | [INFO] [stderr] 43 | let sec = (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000_000_000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | let sec = (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000_000_000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:43:77 [INFO] [stderr] | [INFO] [stderr] 43 | let sec = (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000_000_000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | let sec = (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000_000_000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "89aef9a13e642ff259f91e0b2e9d90b3d984f72aaa82e3b76d5c85c9c4695183"` [INFO] running `"docker" "rm" "-f" "89aef9a13e642ff259f91e0b2e9d90b3d984f72aaa82e3b76d5c85c9c4695183"` [INFO] [stdout] 89aef9a13e642ff259f91e0b2e9d90b3d984f72aaa82e3b76d5c85c9c4695183