[INFO] updating cached repository testingcan/xlsx-csv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/testingcan/xlsx-csv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/testingcan/xlsx-csv" "work/ex/clippy-test-run/sources/stable/gh/testingcan/xlsx-csv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/testingcan/xlsx-csv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/testingcan/xlsx-csv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/testingcan/xlsx-csv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/testingcan/xlsx-csv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9219b197e9ecf2f06892a1bfd00e017b707548dc [INFO] sha for GitHub repo testingcan/xlsx-csv: 9219b197e9ecf2f06892a1bfd00e017b707548dc [INFO] validating manifest of testingcan/xlsx-csv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of testingcan/xlsx-csv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing testingcan/xlsx-csv [INFO] finished frobbing testingcan/xlsx-csv [INFO] frobbed toml for testingcan/xlsx-csv written to work/ex/clippy-test-run/sources/stable/gh/testingcan/xlsx-csv/Cargo.toml [INFO] started frobbing testingcan/xlsx-csv [INFO] finished frobbing testingcan/xlsx-csv [INFO] frobbed toml for testingcan/xlsx-csv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/testingcan/xlsx-csv/Cargo.toml [INFO] crate testingcan/xlsx-csv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting testingcan/xlsx-csv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/testingcan/xlsx-csv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a4cde5fb8de46aaed4781640ab5e1d993e08d5855b8a246d2b9fb94c6d176aec [INFO] running `"docker" "start" "-a" "a4cde5fb8de46aaed4781640ab5e1d993e08d5855b8a246d2b9fb94c6d176aec"` [INFO] [stderr] Checking podio v0.1.6 [INFO] [stderr] Checking lazy_static v1.0.2 [INFO] [stderr] Checking rust-ini v0.12.2 [INFO] [stderr] Compiling proc-macro2 v0.4.9 [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.3 [INFO] [stderr] Checking miniz_oxide v0.1.3 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Checking encoding_rs v0.8.6 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking serde_json v1.0.24 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Compiling quote v0.6.4 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Compiling syn v0.14.5 [INFO] [stderr] Checking serde-hjson v0.8.1 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking config v0.9.0 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Checking calamine v0.14.3 [INFO] [stderr] Checking xlsx-csv v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/file.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | let mut f = File::create("foo.xlsx"); [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/file.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let mut f = File::create("foo.xlsx"); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/file.rs:66:48 [INFO] [stderr] | [INFO] [stderr] 66 | DataType::String(c) => format!("{}", c), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/file.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | remove_file("foo.xlsx"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/settings.rs:37:44 [INFO] [stderr] | [INFO] [stderr] 37 | let env = env::var("RUN_MODE").unwrap_or("default".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "default".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/file.rs:66:48 [INFO] [stderr] | [INFO] [stderr] 66 | DataType::String(c) => format!("{}", c), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/settings.rs:37:44 [INFO] [stderr] | [INFO] [stderr] 37 | let env = env::var("RUN_MODE").unwrap_or("default".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "default".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.19s [INFO] running `"docker" "inspect" "a4cde5fb8de46aaed4781640ab5e1d993e08d5855b8a246d2b9fb94c6d176aec"` [INFO] running `"docker" "rm" "-f" "a4cde5fb8de46aaed4781640ab5e1d993e08d5855b8a246d2b9fb94c6d176aec"` [INFO] [stdout] a4cde5fb8de46aaed4781640ab5e1d993e08d5855b8a246d2b9fb94c6d176aec