[INFO] updating cached repository tessereth/kalaha-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tessereth/kalaha-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tessereth/kalaha-rust" "work/ex/clippy-test-run/sources/stable/gh/tessereth/kalaha-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tessereth/kalaha-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tessereth/kalaha-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tessereth/kalaha-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tessereth/kalaha-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 513b7a276828fa661b98170a5eba3a0172e3c792
[INFO] sha for GitHub repo tessereth/kalaha-rust: 513b7a276828fa661b98170a5eba3a0172e3c792
[INFO] validating manifest of tessereth/kalaha-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tessereth/kalaha-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tessereth/kalaha-rust
[INFO] finished frobbing tessereth/kalaha-rust
[INFO] frobbed toml for tessereth/kalaha-rust written to work/ex/clippy-test-run/sources/stable/gh/tessereth/kalaha-rust/Cargo.toml
[INFO] started frobbing tessereth/kalaha-rust
[INFO] finished frobbing tessereth/kalaha-rust
[INFO] frobbed toml for tessereth/kalaha-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tessereth/kalaha-rust/Cargo.toml
[INFO] crate tessereth/kalaha-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tessereth/kalaha-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tessereth/kalaha-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7fd6bafaa30fbbaf2d0d36a129455a2d5a441db3b9e22d082989a6c3d44829d4
[INFO] running `"docker" "start" "-a" "7fd6bafaa30fbbaf2d0d36a129455a2d5a441db3b9e22d082989a6c3d44829d4"`
[INFO] [stderr]     Checking atty v0.2.6
[INFO] [stderr]     Checking clap v2.29.0
[INFO] [stderr]     Checking kalaha v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `kalaha::Kalaha`
[INFO] [stderr]   --> src/kalaha/mod.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> Kalaha {
[INFO] [stderr] 20 | |         Kalaha { board: Board::new(), turn: Turn::Player(Player::A) }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | impl Default for kalaha::Kalaha {
[INFO] [stderr] 19 |     fn default() -> Self {
[INFO] [stderr] 20 |         Self::new()
[INFO] [stderr] 21 |     }
[INFO] [stderr] 22 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/kalaha/mod.rs:56:41
[INFO] [stderr]    |
[INFO] [stderr] 56 |     pub fn play(&mut self, ai_player_a: &Box<ai::AI>, ai_player_b: &Box<ai::AI>, verbose: bool) -> &GameResult
[INFO] [stderr]    |                                         ^^^^^^^^^^^^ help: try: `&ai::AI`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/kalaha/mod.rs:56:68
[INFO] [stderr]    |
[INFO] [stderr] 56 |     pub fn play(&mut self, ai_player_a: &Box<ai::AI>, ai_player_b: &Box<ai::AI>, verbose: bool) -> &GameResult
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^^ help: try: `&ai::AI`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/board/tests.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |     for ref pool in board.pools[0..6].iter() {
[INFO] [stderr]    |         ^^^^^^^^    ------------------------ help: try: `let pool = &board.pools[0..6].iter();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/board/tests.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |     for ref pool in board.pools[7..13].iter() {
[INFO] [stderr]    |         ^^^^^^^^    ------------------------- help: try: `let pool = &board.pools[7..13].iter();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `kalaha::Kalaha`
[INFO] [stderr]   --> src/kalaha/mod.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> Kalaha {
[INFO] [stderr] 20 | |         Kalaha { board: Board::new(), turn: Turn::Player(Player::A) }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | impl Default for kalaha::Kalaha {
[INFO] [stderr] 19 |     fn default() -> Self {
[INFO] [stderr] 20 |         Self::new()
[INFO] [stderr] 21 |     }
[INFO] [stderr] 22 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/kalaha/mod.rs:56:41
[INFO] [stderr]    |
[INFO] [stderr] 56 |     pub fn play(&mut self, ai_player_a: &Box<ai::AI>, ai_player_b: &Box<ai::AI>, verbose: bool) -> &GameResult
[INFO] [stderr]    |                                         ^^^^^^^^^^^^ help: try: `&ai::AI`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/kalaha/mod.rs:56:68
[INFO] [stderr]    |
[INFO] [stderr] 56 |     pub fn play(&mut self, ai_player_a: &Box<ai::AI>, ai_player_b: &Box<ai::AI>, verbose: bool) -> &GameResult
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^^ help: try: `&ai::AI`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:11:20
[INFO] [stderr]    |
[INFO] [stderr] 11 |         "first" => return Box::new(ai::FirstValid {}),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(ai::FirstValid {})`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 |         "last" => return Box::new(ai::LastValid {}),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(ai::LastValid {})`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:13:21
[INFO] [stderr]    |
[INFO] [stderr] 13 |         "minmax" => return Box::new(ai::MinMax::new(depth)),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(ai::MinMax::new(depth))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:14:24
[INFO] [stderr]    |
[INFO] [stderr] 14 |         "alphabeta" => return Box::new(ai::AlphaBeta::new(depth)),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(ai::AlphaBeta::new(depth))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:11:20
[INFO] [stderr]    |
[INFO] [stderr] 11 |         "first" => return Box::new(ai::FirstValid {}),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(ai::FirstValid {})`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 |         "last" => return Box::new(ai::LastValid {}),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(ai::LastValid {})`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:13:21
[INFO] [stderr]    |
[INFO] [stderr] 13 |         "minmax" => return Box::new(ai::MinMax::new(depth)),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(ai::MinMax::new(depth))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:14:24
[INFO] [stderr]    |
[INFO] [stderr] 14 |         "alphabeta" => return Box::new(ai::AlphaBeta::new(depth)),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(ai::AlphaBeta::new(depth))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.12s
[INFO] running `"docker" "inspect" "7fd6bafaa30fbbaf2d0d36a129455a2d5a441db3b9e22d082989a6c3d44829d4"`
[INFO] running `"docker" "rm" "-f" "7fd6bafaa30fbbaf2d0d36a129455a2d5a441db3b9e22d082989a6c3d44829d4"`
[INFO] [stdout] 7fd6bafaa30fbbaf2d0d36a129455a2d5a441db3b9e22d082989a6c3d44829d4