[INFO] updating cached repository teschty/vmtranslator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/teschty/vmtranslator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/teschty/vmtranslator" "work/ex/clippy-test-run/sources/stable/gh/teschty/vmtranslator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/teschty/vmtranslator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/teschty/vmtranslator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teschty/vmtranslator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teschty/vmtranslator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 633d189308b3b60140e5dbd40a9e9ced98f65955 [INFO] sha for GitHub repo teschty/vmtranslator: 633d189308b3b60140e5dbd40a9e9ced98f65955 [INFO] validating manifest of teschty/vmtranslator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of teschty/vmtranslator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing teschty/vmtranslator [INFO] finished frobbing teschty/vmtranslator [INFO] frobbed toml for teschty/vmtranslator written to work/ex/clippy-test-run/sources/stable/gh/teschty/vmtranslator/Cargo.toml [INFO] started frobbing teschty/vmtranslator [INFO] finished frobbing teschty/vmtranslator [INFO] frobbed toml for teschty/vmtranslator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teschty/vmtranslator/Cargo.toml [INFO] crate teschty/vmtranslator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting teschty/vmtranslator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/teschty/vmtranslator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb1a568b14dacdeb4925fde37cbdc19eb4b895345b5b35f7ad4843133d064669 [INFO] running `"docker" "start" "-a" "cb1a568b14dacdeb4925fde37cbdc19eb4b895345b5b35f7ad4843133d064669"` [INFO] [stderr] Checking vmtranslator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm_parser.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm_parser.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | file_name: file_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm_parser.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm_parser.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | file_name: file_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 29 | | if file_name.ends_with(".vm") { [INFO] [stderr] 30 | | file_name[..file_name.len() - 3].to_string() [INFO] [stderr] 31 | | } else { [INFO] [stderr] 32 | | file_name.to_string() [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } + ".asm"; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | } else if file_name.ends_with(".vm") { [INFO] [stderr] 29 | file_name[..file_name.len() - 3].to_string() [INFO] [stderr] 30 | } else { [INFO] [stderr] 31 | file_name.to_string() [INFO] [stderr] 32 | } + ".asm"; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 29 | | if file_name.ends_with(".vm") { [INFO] [stderr] 30 | | file_name[..file_name.len() - 3].to_string() [INFO] [stderr] 31 | | } else { [INFO] [stderr] 32 | | file_name.to_string() [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } + ".asm"; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | } else if file_name.ends_with(".vm") { [INFO] [stderr] 29 | file_name[..file_name.len() - 3].to_string() [INFO] [stderr] 30 | } else { [INFO] [stderr] 31 | file_name.to_string() [INFO] [stderr] 32 | } + ".asm"; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/vm_parser.rs:67:12 [INFO] [stderr] | [INFO] [stderr] 67 | if parts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/main.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | for i in 1..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 19 | for in args.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/main.rs:47:14 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 1..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for in args.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/vm_parser.rs:67:12 [INFO] [stderr] | [INFO] [stderr] 67 | if parts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/main.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | for i in 1..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 19 | for in args.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/main.rs:47:14 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 1..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for in args.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "cb1a568b14dacdeb4925fde37cbdc19eb4b895345b5b35f7ad4843133d064669"` [INFO] running `"docker" "rm" "-f" "cb1a568b14dacdeb4925fde37cbdc19eb4b895345b5b35f7ad4843133d064669"` [INFO] [stdout] cb1a568b14dacdeb4925fde37cbdc19eb4b895345b5b35f7ad4843133d064669