[INFO] updating cached repository termoshtt/rlib-parse [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/termoshtt/rlib-parse [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/termoshtt/rlib-parse" "work/ex/clippy-test-run/sources/stable/gh/termoshtt/rlib-parse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/termoshtt/rlib-parse'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/termoshtt/rlib-parse" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termoshtt/rlib-parse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termoshtt/rlib-parse'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3b49b74e35d24ffbd752a741ba88e251f1e21ad5 [INFO] sha for GitHub repo termoshtt/rlib-parse: 3b49b74e35d24ffbd752a741ba88e251f1e21ad5 [INFO] validating manifest of termoshtt/rlib-parse on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of termoshtt/rlib-parse on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing termoshtt/rlib-parse [INFO] finished frobbing termoshtt/rlib-parse [INFO] frobbed toml for termoshtt/rlib-parse written to work/ex/clippy-test-run/sources/stable/gh/termoshtt/rlib-parse/Cargo.toml [INFO] started frobbing termoshtt/rlib-parse [INFO] finished frobbing termoshtt/rlib-parse [INFO] frobbed toml for termoshtt/rlib-parse written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termoshtt/rlib-parse/Cargo.toml [INFO] crate termoshtt/rlib-parse has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting termoshtt/rlib-parse against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/termoshtt/rlib-parse:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e5f1cbd803d7e359b8446062cbb128980fc757ef6c0329e0ab4051eaa5ab5fe [INFO] running `"docker" "start" "-a" "8e5f1cbd803d7e359b8446062cbb128980fc757ef6c0329e0ab4051eaa5ab5fe"` [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking rlib-parse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | pub const RLIB_BYTECODE_OBJECT_MAGIC: &'static [u8] = b"RUST_OBJECT"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bytecode.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return encoded; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `encoded` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bytecode.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | pub const RLIB_BYTECODE_OBJECT_MAGIC: &'static [u8] = b"RUST_OBJECT"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bytecode.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return encoded; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `encoded` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bytecode.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `identifier_len` [INFO] [stderr] --> src/bytecode.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | (identifier_len >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bytecode_len` [INFO] [stderr] --> src/bytecode.rs:89:38 [INFO] [stderr] | [INFO] [stderr] 89 | encoded[deflated_size_pos + 0] = (bytecode_len >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `deflated_size_pos` [INFO] [stderr] --> src/bytecode.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | encoded[deflated_size_pos + 0] = (bytecode_len >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:116:24 [INFO] [stderr] | [INFO] [stderr] 116 | return Err(format!("magic bytecode prefix not found")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"magic bytecode prefix not found".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(format!("wrong version prefix found in bytecode")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"wrong version prefix found in bytecode".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | return Err(format!("bytecode corrupted")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/bytecode.rs:127:55 [INFO] [stderr] | [INFO] [stderr] 127 | unsafe { u32::from_le(ptr::read_unaligned(data.as_ptr() as *const u32)) as usize }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | return Err(format!("bytecode corrupted")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:134:34 [INFO] [stderr] | [INFO] [stderr] 134 | Err(_) => return Err(format!("bytecode corrupted")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | return Err(format!("bytecode corrupted")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/bytecode.rs:141:55 [INFO] [stderr] | [INFO] [stderr] 141 | unsafe { u64::from_le(ptr::read_unaligned(data.as_ptr() as *const u64)) as usize }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:144:24 [INFO] [stderr] | [INFO] [stderr] 144 | return Err(format!("bytecode corrupted")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rlib-parse`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `identifier_len` [INFO] [stderr] --> src/bytecode.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | (identifier_len >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bytecode_len` [INFO] [stderr] --> src/bytecode.rs:89:38 [INFO] [stderr] | [INFO] [stderr] 89 | encoded[deflated_size_pos + 0] = (bytecode_len >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `deflated_size_pos` [INFO] [stderr] --> src/bytecode.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | encoded[deflated_size_pos + 0] = (bytecode_len >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:116:24 [INFO] [stderr] | [INFO] [stderr] 116 | return Err(format!("magic bytecode prefix not found")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"magic bytecode prefix not found".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(format!("wrong version prefix found in bytecode")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"wrong version prefix found in bytecode".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | return Err(format!("bytecode corrupted")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/bytecode.rs:127:55 [INFO] [stderr] | [INFO] [stderr] 127 | unsafe { u32::from_le(ptr::read_unaligned(data.as_ptr() as *const u32)) as usize }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | return Err(format!("bytecode corrupted")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:134:34 [INFO] [stderr] | [INFO] [stderr] 134 | Err(_) => return Err(format!("bytecode corrupted")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | return Err(format!("bytecode corrupted")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/bytecode.rs:141:55 [INFO] [stderr] | [INFO] [stderr] 141 | unsafe { u64::from_le(ptr::read_unaligned(data.as_ptr() as *const u64)) as usize }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bytecode.rs:144:24 [INFO] [stderr] | [INFO] [stderr] 144 | return Err(format!("bytecode corrupted")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytecode corrupted".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rlib-parse`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8e5f1cbd803d7e359b8446062cbb128980fc757ef6c0329e0ab4051eaa5ab5fe"` [INFO] running `"docker" "rm" "-f" "8e5f1cbd803d7e359b8446062cbb128980fc757ef6c0329e0ab4051eaa5ab5fe"` [INFO] [stdout] 8e5f1cbd803d7e359b8446062cbb128980fc757ef6c0329e0ab4051eaa5ab5fe