[INFO] updating cached repository termoshtt/llvmenv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/termoshtt/llvmenv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/termoshtt/llvmenv" "work/ex/clippy-test-run/sources/stable/gh/termoshtt/llvmenv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/termoshtt/llvmenv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/termoshtt/llvmenv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termoshtt/llvmenv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termoshtt/llvmenv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 27e3c90b3c26a0ba27553d659cffcd4bb9725a9f [INFO] sha for GitHub repo termoshtt/llvmenv: 27e3c90b3c26a0ba27553d659cffcd4bb9725a9f [INFO] validating manifest of termoshtt/llvmenv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of termoshtt/llvmenv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing termoshtt/llvmenv [INFO] finished frobbing termoshtt/llvmenv [INFO] frobbed toml for termoshtt/llvmenv written to work/ex/clippy-test-run/sources/stable/gh/termoshtt/llvmenv/Cargo.toml [INFO] started frobbing termoshtt/llvmenv [INFO] finished frobbing termoshtt/llvmenv [INFO] frobbed toml for termoshtt/llvmenv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termoshtt/llvmenv/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting termoshtt/llvmenv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/termoshtt/llvmenv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9a3ed3fe074e9607c992f16d6f23693ee2966fc5fa2bbe5538a93a3e571633d [INFO] running `"docker" "start" "-a" "e9a3ed3fe074e9607c992f16d6f23693ee2966fc5fa2bbe5538a93a3e571633d"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Compiling openssl v0.10.16 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking string v0.1.3 [INFO] [stderr] Compiling crc32fast v1.1.2 [INFO] [stderr] Compiling encoding_rs v0.8.14 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking rustc-demangle v0.1.13 [INFO] [stderr] Checking fs_extra v1.1.0 [INFO] [stderr] Checking crossbeam-utils v0.6.4 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_jitter v0.1.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Compiling openssl-sys v0.9.40 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Checking tokio-executor v0.1.6 [INFO] [stderr] Checking crossbeam-channel v0.3.7 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking rand_os v0.1.1 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking num_cpus v1.9.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking mime v0.3.13 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking tokio-timer v0.2.9 [INFO] [stderr] Checking libflate v0.1.19 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking rand_pcg v0.1.1 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking http v0.1.15 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking h2 v0.1.16 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking llvmenv v0.2.1-alpha.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/build.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const LLVMENV_FN: &'static str = ".llvmenv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | pub const APP_NAME: &'static str = "llvmenv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub const ENTRY_TOML: &'static str = "entry.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/build.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const LLVMENV_FN: &'static str = ".llvmenv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | pub const APP_NAME: &'static str = "llvmenv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub const ENTRY_TOML: &'static str = "entry.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/build.rs:125:10 [INFO] [stderr] | [INFO] [stderr] 125 | .ok_or(err_msg("Failed to parse $(clang --version) output"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Failed to parse $(clang --version) output"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | .ok_or(err_msg("Unsupported OS"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Unsupported OS"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:27:10 [INFO] [stderr] | [INFO] [stderr] 27 | .ok_or(err_msg("Unsupported OS"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Unsupported OS"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | .ok_or(err_msg("Unsupported OS"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Unsupported OS"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/config.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | f.write(LLVM_MIRROR.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/entry.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn from_str(builder: &str) -> Result { [INFO] [stderr] 41 | | Ok(match builder.to_ascii_lowercase().as_str() { [INFO] [stderr] 42 | | "makefile" => CMakeGenerator::Makefile, [INFO] [stderr] 43 | | "ninja" => CMakeGenerator::Ninja, [INFO] [stderr] ... | [INFO] [stderr] 46 | | }) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/entry.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | if setting.tools.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!setting.tools.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/entry.rs:194:6 [INFO] [stderr] | [INFO] [stderr] 194 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/entry.rs:366:12 [INFO] [stderr] | [INFO] [stderr] 366 | if setting.target.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!setting.target.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/resource.rs:222:35 [INFO] [stderr] | [INFO] [stderr] 222 | let seg = url.path_segments().ok_or(err_msg("URL parse failed"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("URL parse failed"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/resource.rs:223:31 [INFO] [stderr] | [INFO] [stderr] 223 | let filename = seg.last().ok_or(err_msg("URL is invalid"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("URL is invalid"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `llvmenv`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/build.rs:125:10 [INFO] [stderr] | [INFO] [stderr] 125 | .ok_or(err_msg("Failed to parse $(clang --version) output"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Failed to parse $(clang --version) output"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | .ok_or(err_msg("Unsupported OS"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Unsupported OS"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:27:10 [INFO] [stderr] | [INFO] [stderr] 27 | .ok_or(err_msg("Unsupported OS"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Unsupported OS"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | .ok_or(err_msg("Unsupported OS"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Unsupported OS"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/config.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | f.write(LLVM_MIRROR.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/entry.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn from_str(builder: &str) -> Result { [INFO] [stderr] 41 | | Ok(match builder.to_ascii_lowercase().as_str() { [INFO] [stderr] 42 | | "makefile" => CMakeGenerator::Makefile, [INFO] [stderr] 43 | | "ninja" => CMakeGenerator::Ninja, [INFO] [stderr] ... | [INFO] [stderr] 46 | | }) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/entry.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | if setting.tools.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!setting.tools.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/entry.rs:194:6 [INFO] [stderr] | [INFO] [stderr] 194 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/entry.rs:366:12 [INFO] [stderr] | [INFO] [stderr] 366 | if setting.target.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!setting.target.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/resource.rs:222:35 [INFO] [stderr] | [INFO] [stderr] 222 | let seg = url.path_segments().ok_or(err_msg("URL parse failed"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("URL parse failed"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/resource.rs:223:31 [INFO] [stderr] | [INFO] [stderr] 223 | let filename = seg.last().ok_or(err_msg("URL is invalid"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("URL is invalid"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `llvmenv`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e9a3ed3fe074e9607c992f16d6f23693ee2966fc5fa2bbe5538a93a3e571633d"` [INFO] running `"docker" "rm" "-f" "e9a3ed3fe074e9607c992f16d6f23693ee2966fc5fa2bbe5538a93a3e571633d"` [INFO] [stdout] e9a3ed3fe074e9607c992f16d6f23693ee2966fc5fa2bbe5538a93a3e571633d