[INFO] updating cached repository termhn/rust-toh [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/termhn/rust-toh [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/termhn/rust-toh" "work/ex/clippy-test-run/sources/stable/gh/termhn/rust-toh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/termhn/rust-toh'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/termhn/rust-toh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termhn/rust-toh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termhn/rust-toh'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d7c03a32dff30f51ed64f3750b02a6c57e49fe07 [INFO] sha for GitHub repo termhn/rust-toh: d7c03a32dff30f51ed64f3750b02a6c57e49fe07 [INFO] validating manifest of termhn/rust-toh on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of termhn/rust-toh on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing termhn/rust-toh [INFO] finished frobbing termhn/rust-toh [INFO] frobbed toml for termhn/rust-toh written to work/ex/clippy-test-run/sources/stable/gh/termhn/rust-toh/Cargo.toml [INFO] started frobbing termhn/rust-toh [INFO] finished frobbing termhn/rust-toh [INFO] frobbed toml for termhn/rust-toh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termhn/rust-toh/Cargo.toml [INFO] crate termhn/rust-toh has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting termhn/rust-toh against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/termhn/rust-toh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b24ea242f1bd14f58fc27cc2cbd764597cb5de484fa5270e4fe55d1316ff80aa [INFO] running `"docker" "start" "-a" "b24ea242f1bd14f58fc27cc2cbd764597cb5de484fa5270e4fe55d1316ff80aa"` [INFO] [stderr] Checking toh v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | for layer in (0..height + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(0..=height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:112:14 [INFO] [stderr] | [INFO] [stderr] 112 | for i in (1..n + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | for layer in (0..height + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(0..=height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:112:14 [INFO] [stderr] | [INFO] [stderr] 112 | for i in (1..n + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "b24ea242f1bd14f58fc27cc2cbd764597cb5de484fa5270e4fe55d1316ff80aa"` [INFO] running `"docker" "rm" "-f" "b24ea242f1bd14f58fc27cc2cbd764597cb5de484fa5270e4fe55d1316ff80aa"` [INFO] [stdout] b24ea242f1bd14f58fc27cc2cbd764597cb5de484fa5270e4fe55d1316ff80aa