[INFO] updating cached repository termhn/nanopow-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/termhn/nanopow-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/termhn/nanopow-rs" "work/ex/clippy-test-run/sources/stable/gh/termhn/nanopow-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/termhn/nanopow-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/termhn/nanopow-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termhn/nanopow-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termhn/nanopow-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b3a8a84e5f3a2c6028c306e55091f09a03205082 [INFO] sha for GitHub repo termhn/nanopow-rs: b3a8a84e5f3a2c6028c306e55091f09a03205082 [INFO] validating manifest of termhn/nanopow-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of termhn/nanopow-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing termhn/nanopow-rs [INFO] finished frobbing termhn/nanopow-rs [INFO] frobbed toml for termhn/nanopow-rs written to work/ex/clippy-test-run/sources/stable/gh/termhn/nanopow-rs/Cargo.toml [INFO] started frobbing termhn/nanopow-rs [INFO] finished frobbing termhn/nanopow-rs [INFO] frobbed toml for termhn/nanopow-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/termhn/nanopow-rs/Cargo.toml [INFO] crate termhn/nanopow-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting termhn/nanopow-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/termhn/nanopow-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12c9d4751276a4df7eedc4172d92ac1323244a1173b4c0392d0cbe786391497b [INFO] running `"docker" "start" "-a" "12c9d4751276a4df7eedc4172d92ac1323244a1173b4c0392d0cbe786391497b"` [INFO] [stderr] Compiling cc v1.0.5 [INFO] [stderr] Compiling typenum v1.9.0 [INFO] [stderr] Checking hex v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.2.11 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking crossbeam-channel v0.1.2 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking digest v0.7.2 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking blake2 v0.7.0 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking nanopow-rs v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `buf[..8].clone_from_slice(&bytes[..8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `buf[..32].clone_from_slice(&bytes[..32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:120:37 [INFO] [stderr] | [INFO] [stderr] 120 | let first = (&hash[5..8]).iter().fold(true, |acc, &byte| { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 121 | | acc && byte == 255 [INFO] [stderr] 122 | | }); [INFO] [stderr] | |______^ help: try: `.all(|byte| byte == 255)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:260:17 [INFO] [stderr] | [INFO] [stderr] 260 | assert!(valid == false); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!valid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `buf[..8].clone_from_slice(&bytes[..8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `buf[..32].clone_from_slice(&bytes[..32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:120:37 [INFO] [stderr] | [INFO] [stderr] 120 | let first = (&hash[5..8]).iter().fold(true, |acc, &byte| { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 121 | | acc && byte == 255 [INFO] [stderr] 122 | | }); [INFO] [stderr] | |______^ help: try: `.all(|byte| byte == 255)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.97s [INFO] running `"docker" "inspect" "12c9d4751276a4df7eedc4172d92ac1323244a1173b4c0392d0cbe786391497b"` [INFO] running `"docker" "rm" "-f" "12c9d4751276a4df7eedc4172d92ac1323244a1173b4c0392d0cbe786391497b"` [INFO] [stdout] 12c9d4751276a4df7eedc4172d92ac1323244a1173b4c0392d0cbe786391497b