[INFO] updating cached repository terakun/typed_lambda
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/terakun/typed_lambda
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/terakun/typed_lambda" "work/ex/clippy-test-run/sources/stable/gh/terakun/typed_lambda"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/terakun/typed_lambda'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/terakun/typed_lambda" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/typed_lambda"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/typed_lambda'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6f158b555366960e8fe045c14d88dbb48e88552c
[INFO] sha for GitHub repo terakun/typed_lambda: 6f158b555366960e8fe045c14d88dbb48e88552c
[INFO] validating manifest of terakun/typed_lambda on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of terakun/typed_lambda on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing terakun/typed_lambda
[INFO] finished frobbing terakun/typed_lambda
[INFO] frobbed toml for terakun/typed_lambda written to work/ex/clippy-test-run/sources/stable/gh/terakun/typed_lambda/Cargo.toml
[INFO] started frobbing terakun/typed_lambda
[INFO] finished frobbing terakun/typed_lambda
[INFO] frobbed toml for terakun/typed_lambda written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/typed_lambda/Cargo.toml
[INFO] crate terakun/typed_lambda has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting terakun/typed_lambda against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/terakun/typed_lambda:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8f296c4aa8c0d37a19b1d0b741944cd019d084d101043a5517f0dc1ef2ab5979
[INFO] running `"docker" "start" "-a" "8f296c4aa8c0d37a19b1d0b741944cd019d084d101043a5517f0dc1ef2ab5979"`
[INFO] [stderr]     Checking typed_lambda v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ast.rs:93:24
[INFO] [stderr]     |
[INFO] [stderr] 93  |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 94  | |                     if e.free(v2) {
[INFO] [stderr] 95  | |                         let new_v = e.new_variable().expect("pig flying");
[INFO] [stderr] 96  | |                         AST::Abs(
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |                     }
[INFO] [stderr] 103 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 93  |                 } else if e.free(v2) {
[INFO] [stderr] 94  |     let new_v = e.new_variable().expect("pig flying");
[INFO] [stderr] 95  |     AST::Abs(
[INFO] [stderr] 96  |         new_v.clone(),
[INFO] [stderr] 97  |         Box::new(e2.assign(&AST::Var(new_v), v2).assign(e, v)),
[INFO] [stderr] 98  |     )
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ast.rs:114:24
[INFO] [stderr]     |
[INFO] [stderr] 114 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 115 | |                     if e1.reductive() {
[INFO] [stderr] 116 | |                         AST::App(Box::new(e1.step()), Box::new(*e2.clone()))
[INFO] [stderr] 117 | |                     } else {
[INFO] [stderr] 118 | |                         AST::App(Box::new(*e1.clone()), Box::new(e2.step()))
[INFO] [stderr] 119 | |                     }
[INFO] [stderr] 120 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 114 |                 } else if e1.reductive() {
[INFO] [stderr] 115 |     AST::App(Box::new(e1.step()), Box::new(*e2.clone()))
[INFO] [stderr] 116 | } else {
[INFO] [stderr] 117 |     AST::App(Box::new(*e1.clone()), Box::new(e2.step()))
[INFO] [stderr] 118 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/typing.rs:268:5
[INFO] [stderr]     |
[INFO] [stderr] 268 |     return unified_constraints;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unified_constraints`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ast.rs:93:24
[INFO] [stderr]     |
[INFO] [stderr] 93  |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 94  | |                     if e.free(v2) {
[INFO] [stderr] 95  | |                         let new_v = e.new_variable().expect("pig flying");
[INFO] [stderr] 96  | |                         AST::Abs(
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |                     }
[INFO] [stderr] 103 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 93  |                 } else if e.free(v2) {
[INFO] [stderr] 94  |     let new_v = e.new_variable().expect("pig flying");
[INFO] [stderr] 95  |     AST::Abs(
[INFO] [stderr] 96  |         new_v.clone(),
[INFO] [stderr] 97  |         Box::new(e2.assign(&AST::Var(new_v), v2).assign(e, v)),
[INFO] [stderr] 98  |     )
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ast.rs:114:24
[INFO] [stderr]     |
[INFO] [stderr] 114 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 115 | |                     if e1.reductive() {
[INFO] [stderr] 116 | |                         AST::App(Box::new(e1.step()), Box::new(*e2.clone()))
[INFO] [stderr] 117 | |                     } else {
[INFO] [stderr] 118 | |                         AST::App(Box::new(*e1.clone()), Box::new(e2.step()))
[INFO] [stderr] 119 | |                     }
[INFO] [stderr] 120 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 114 |                 } else if e1.reductive() {
[INFO] [stderr] 115 |     AST::App(Box::new(e1.step()), Box::new(*e2.clone()))
[INFO] [stderr] 116 | } else {
[INFO] [stderr] 117 |     AST::App(Box::new(*e1.clone()), Box::new(e2.step()))
[INFO] [stderr] 118 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/typing.rs:268:5
[INFO] [stderr]     |
[INFO] [stderr] 268 |     return unified_constraints;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unified_constraints`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ast.rs:33:23
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn free(&self, v: &String) -> bool {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ast.rs:80:39
[INFO] [stderr]    |
[INFO] [stderr] 80 |     pub fn assign(&self, e: &Self, v: &String) -> Self {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:32:29
[INFO] [stderr]    |
[INFO] [stderr] 32 | pub fn error_message(input: &String, err: TokenErr) -> String {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:43:24
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub fn tokenize(input: &String) -> Result<Vec<Token>, String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:46:5
[INFO] [stderr]     |
[INFO] [stderr] 46  | /     loop {
[INFO] [stderr] 47  | |         match it.peek() {
[INFO] [stderr] 48  | |             Some(&ch) => match ch {
[INFO] [stderr] 49  | |                 '\\' => {
[INFO] [stderr] ...   |
[INFO] [stderr] 116 | |         }
[INFO] [stderr] 117 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(&ch) = it.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:55:28
[INFO] [stderr]    |
[INFO] [stderr] 55 |                         if var.len() == 0 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `var.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/parser.rs:58:34
[INFO] [stderr]    |
[INFO] [stderr] 58 |                                 (format!("variable must be at least 1 character"), it.count()),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"variable must be at least 1 character".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/parser.rs:76:34
[INFO] [stderr]    |
[INFO] [stderr] 76 |                                 (format!("expected '.',found EOF"), it.count()),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"expected '.',found EOF".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::Parser`
[INFO] [stderr]    --> src/parser.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     pub fn new() -> Self {
[INFO] [stderr] 129 | |         Parser {
[INFO] [stderr] 130 | |             cur: 0,
[INFO] [stderr] 131 | |             len: 0,
[INFO] [stderr] 132 | |             tokens: Vec::new(),
[INFO] [stderr] 133 | |         }
[INFO] [stderr] 134 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 121 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/parser.rs:135:36
[INFO] [stderr]     |
[INFO] [stderr] 135 |     pub fn parse(&mut self, input: &String) -> Option<AST> {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:154:21
[INFO] [stderr]     |
[INFO] [stderr] 154 |                     self.cur = self.cur + 1;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/parser.rs:155:31
[INFO] [stderr]     |
[INFO] [stderr] 155 |                       let exp = match &self.read_expression() {
[INFO] [stderr]     |  _______________________________^
[INFO] [stderr] 156 | |                         &Some(ref exp) => exp.clone(),
[INFO] [stderr] 157 | |                         &None => {
[INFO] [stderr] 158 | |                             return None;
[INFO] [stderr] 159 | |                         }
[INFO] [stderr] 160 | |                     };
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 155 |                     let exp = match self.read_expression() {
[INFO] [stderr] 156 |                         Some(ref exp) => exp.clone(),
[INFO] [stderr] 157 |                         None => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 self.cur = self.cur + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/parser.rs:185:27
[INFO] [stderr]     |
[INFO] [stderr] 185 |                   let exp = match &self.read_expression() {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 186 | |                     &Some(ref exp) => exp.clone(),
[INFO] [stderr] 187 | |                     &None => {
[INFO] [stderr] 188 | |                         return None;
[INFO] [stderr] 189 | |                     }
[INFO] [stderr] 190 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 185 |                 let exp = match self.read_expression() {
[INFO] [stderr] 186 |                     Some(ref exp) => exp.clone(),
[INFO] [stderr] 187 |                     None => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:195:17
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 self.cur = self.cur + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:200:17
[INFO] [stderr]     |
[INFO] [stderr] 200 |                 self.cur = self.cur + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/typing.rs:163:34
[INFO] [stderr]     |
[INFO] [stderr] 163 |     pub fn unify(&self, unifier: &Unifier) -> Self {
[INFO] [stderr]     |                                  ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `typing::TypeInf`
[INFO] [stderr]    --> src/typing.rs:192:5
[INFO] [stderr]     |
[INFO] [stderr] 192 | /     pub fn new() -> Self {
[INFO] [stderr] 193 | |         TypeInf { cnt: 0 }
[INFO] [stderr] 194 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 187 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/typing.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 |         self.cnt = self.cnt + 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cnt += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/typing.rs:253:29
[INFO] [stderr]     |
[INFO] [stderr] 253 |     pub fn appear(&self, x: &String) -> bool {
[INFO] [stderr]     |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ast.rs:33:23
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn free(&self, v: &String) -> bool {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ast.rs:80:39
[INFO] [stderr]    |
[INFO] [stderr] 80 |     pub fn assign(&self, e: &Self, v: &String) -> Self {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:21:12
[INFO] [stderr]    |
[INFO] [stderr] 21 |         if input.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:32:29
[INFO] [stderr]    |
[INFO] [stderr] 32 | pub fn error_message(input: &String, err: TokenErr) -> String {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:43:24
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub fn tokenize(input: &String) -> Result<Vec<Token>, String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:46:5
[INFO] [stderr]     |
[INFO] [stderr] 46  | /     loop {
[INFO] [stderr] 47  | |         match it.peek() {
[INFO] [stderr] 48  | |             Some(&ch) => match ch {
[INFO] [stderr] 49  | |                 '\\' => {
[INFO] [stderr] ...   |
[INFO] [stderr] 116 | |         }
[INFO] [stderr] 117 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(&ch) = it.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:55:28
[INFO] [stderr]    |
[INFO] [stderr] 55 |                         if var.len() == 0 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `var.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/parser.rs:58:34
[INFO] [stderr]    |
[INFO] [stderr] 58 |                                 (format!("variable must be at least 1 character"), it.count()),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"variable must be at least 1 character".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/parser.rs:76:34
[INFO] [stderr]    |
[INFO] [stderr] 76 |                                 (format!("expected '.',found EOF"), it.count()),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"expected '.',found EOF".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::Parser`
[INFO] [stderr]    --> src/parser.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     pub fn new() -> Self {
[INFO] [stderr] 129 | |         Parser {
[INFO] [stderr] 130 | |             cur: 0,
[INFO] [stderr] 131 | |             len: 0,
[INFO] [stderr] 132 | |             tokens: Vec::new(),
[INFO] [stderr] 133 | |         }
[INFO] [stderr] 134 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 121 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/parser.rs:135:36
[INFO] [stderr]     |
[INFO] [stderr] 135 |     pub fn parse(&mut self, input: &String) -> Option<AST> {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:154:21
[INFO] [stderr]     |
[INFO] [stderr] 154 |                     self.cur = self.cur + 1;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/parser.rs:155:31
[INFO] [stderr]     |
[INFO] [stderr] 155 |                       let exp = match &self.read_expression() {
[INFO] [stderr]     |  _______________________________^
[INFO] [stderr] 156 | |                         &Some(ref exp) => exp.clone(),
[INFO] [stderr] 157 | |                         &None => {
[INFO] [stderr] 158 | |                             return None;
[INFO] [stderr] 159 | |                         }
[INFO] [stderr] 160 | |                     };
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 155 |                     let exp = match self.read_expression() {
[INFO] [stderr] 156 |                         Some(ref exp) => exp.clone(),
[INFO] [stderr] 157 |                         None => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 self.cur = self.cur + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/parser.rs:185:27
[INFO] [stderr]     |
[INFO] [stderr] 185 |                   let exp = match &self.read_expression() {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 186 | |                     &Some(ref exp) => exp.clone(),
[INFO] [stderr] 187 | |                     &None => {
[INFO] [stderr] 188 | |                         return None;
[INFO] [stderr] 189 | |                     }
[INFO] [stderr] 190 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 185 |                 let exp = match self.read_expression() {
[INFO] [stderr] 186 |                     Some(ref exp) => exp.clone(),
[INFO] [stderr] 187 |                     None => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:195:17
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 self.cur = self.cur + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:200:17
[INFO] [stderr]     |
[INFO] [stderr] 200 |                 self.cur = self.cur + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/typing.rs:163:34
[INFO] [stderr]     |
[INFO] [stderr] 163 |     pub fn unify(&self, unifier: &Unifier) -> Self {
[INFO] [stderr]     |                                  ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `typing::TypeInf`
[INFO] [stderr]    --> src/typing.rs:192:5
[INFO] [stderr]     |
[INFO] [stderr] 192 | /     pub fn new() -> Self {
[INFO] [stderr] 193 | |         TypeInf { cnt: 0 }
[INFO] [stderr] 194 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 187 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/typing.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 |         self.cnt = self.cnt + 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cnt += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/typing.rs:253:29
[INFO] [stderr]     |
[INFO] [stderr] 253 |     pub fn appear(&self, x: &String) -> bool {
[INFO] [stderr]     |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:21:12
[INFO] [stderr]    |
[INFO] [stderr] 21 |         if input.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.05s
[INFO] running `"docker" "inspect" "8f296c4aa8c0d37a19b1d0b741944cd019d084d101043a5517f0dc1ef2ab5979"`
[INFO] running `"docker" "rm" "-f" "8f296c4aa8c0d37a19b1d0b741944cd019d084d101043a5517f0dc1ef2ab5979"`
[INFO] [stdout] 8f296c4aa8c0d37a19b1d0b741944cd019d084d101043a5517f0dc1ef2ab5979