[INFO] updating cached repository terakun/type_inference
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/terakun/type_inference
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/terakun/type_inference" "work/ex/clippy-test-run/sources/stable/gh/terakun/type_inference"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/terakun/type_inference'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/terakun/type_inference" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/type_inference"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/type_inference'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 076e33d711085981661e2995f1be376a1c367077
[INFO] sha for GitHub repo terakun/type_inference: 076e33d711085981661e2995f1be376a1c367077
[INFO] validating manifest of terakun/type_inference on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of terakun/type_inference on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing terakun/type_inference
[INFO] finished frobbing terakun/type_inference
[INFO] frobbed toml for terakun/type_inference written to work/ex/clippy-test-run/sources/stable/gh/terakun/type_inference/Cargo.toml
[INFO] started frobbing terakun/type_inference
[INFO] finished frobbing terakun/type_inference
[INFO] frobbed toml for terakun/type_inference written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/type_inference/Cargo.toml
[INFO] crate terakun/type_inference has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting terakun/type_inference against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/terakun/type_inference:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 92646f9a34f032371ee16efd1685db9b2238ad3b905afe26a71b476f62fee08c
[INFO] running `"docker" "start" "-a" "92646f9a34f032371ee16efd1685db9b2238ad3b905afe26a71b476f62fee08c"`
[INFO] [stderr]     Checking type_inference v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/typing.rs:219:5
[INFO] [stderr]     |
[INFO] [stderr] 219 |     return unified_constraints;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unified_constraints`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/typing.rs:219:5
[INFO] [stderr]     |
[INFO] [stderr] 219 |     return unified_constraints;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unified_constraints`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Bool`
[INFO] [stderr]   --> src/ast.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     Bool(bool),
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Bool`
[INFO] [stderr]   --> src/ast.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     Bool(bool),
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/typing.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 |         self.cnt = self.cnt + 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cnt += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/typing.rs:196:29
[INFO] [stderr]     |
[INFO] [stderr] 196 |     pub fn appear(&self, x: &String) -> bool {
[INFO] [stderr]     |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/typing.rs:240:30
[INFO] [stderr]     |
[INFO] [stderr] 240 |                     for e in ops1.iter().map(|t| t.clone()).zip(ops2) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ops1.iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/typing.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 |         self.cnt = self.cnt + 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cnt += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/typing.rs:196:29
[INFO] [stderr]     |
[INFO] [stderr] 196 |     pub fn appear(&self, x: &String) -> bool {
[INFO] [stderr]     |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/typing.rs:240:30
[INFO] [stderr]     |
[INFO] [stderr] 240 |                     for e in ops1.iter().map(|t| t.clone()).zip(ops2) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ops1.iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.99s
[INFO] running `"docker" "inspect" "92646f9a34f032371ee16efd1685db9b2238ad3b905afe26a71b476f62fee08c"`
[INFO] running `"docker" "rm" "-f" "92646f9a34f032371ee16efd1685db9b2238ad3b905afe26a71b476f62fee08c"`
[INFO] [stdout] 92646f9a34f032371ee16efd1685db9b2238ad3b905afe26a71b476f62fee08c