[INFO] updating cached repository terakun/quoridor_judge [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/terakun/quoridor_judge [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/terakun/quoridor_judge" "work/ex/clippy-test-run/sources/stable/gh/terakun/quoridor_judge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/terakun/quoridor_judge'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/terakun/quoridor_judge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/quoridor_judge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/quoridor_judge'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8018ec5c8825a77af2e39e2833e750e4869cb9b7 [INFO] sha for GitHub repo terakun/quoridor_judge: 8018ec5c8825a77af2e39e2833e750e4869cb9b7 [INFO] validating manifest of terakun/quoridor_judge on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of terakun/quoridor_judge on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing terakun/quoridor_judge [INFO] finished frobbing terakun/quoridor_judge [INFO] frobbed toml for terakun/quoridor_judge written to work/ex/clippy-test-run/sources/stable/gh/terakun/quoridor_judge/Cargo.toml [INFO] started frobbing terakun/quoridor_judge [INFO] finished frobbing terakun/quoridor_judge [INFO] frobbed toml for terakun/quoridor_judge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/quoridor_judge/Cargo.toml [INFO] crate terakun/quoridor_judge has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting terakun/quoridor_judge against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/terakun/quoridor_judge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb9316f8cd2669369b25563af9f257864864335092f64a09b109fbcb5f214bfd [INFO] running `"docker" "start" "-a" "fb9316f8cd2669369b25563af9f257864864335092f64a09b109fbcb5f214bfd"` [INFO] [stderr] Checking bit-vec v0.5.0 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking ws v0.7.9 [INFO] [stderr] Checking quoridor_judge v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/websocket.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:766:9 [INFO] [stderr] | [INFO] [stderr] 766 | broadcaster: broadcaster, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `broadcaster` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/websocket.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:766:9 [INFO] [stderr] | [INFO] [stderr] 766 | broadcaster: broadcaster, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `broadcaster` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufRead`, `BufReader` [INFO] [stderr] --> src/websocket.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{BufRead, BufReader}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `CloseCode`, `Factory`, `Handler`, `Message` [INFO] [stderr] --> src/main.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | use ws::{CloseCode, Factory, Handler, Message, Sender}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^ ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:122:16 [INFO] [stderr] | [INFO] [stderr] 122 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 123 | | if dy == 1 { [INFO] [stderr] 124 | | (y, x, y, x - 1, Dir::Horizontal) [INFO] [stderr] 125 | | } else { [INFO] [stderr] 126 | | (y - 1, x, y - 1, x - 1, Dir::Horizontal) [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | } else if dy == 1 { [INFO] [stderr] 123 | (y, x, y, x - 1, Dir::Horizontal) [INFO] [stderr] 124 | } else { [INFO] [stderr] 125 | (y - 1, x, y - 1, x - 1, Dir::Horizontal) [INFO] [stderr] 126 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | / if !visited[ny as usize][nx as usize] { [INFO] [stderr] 141 | | if self.dfs(ny, nx, gy, visited) { [INFO] [stderr] 142 | | return true; [INFO] [stderr] 143 | | } [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | if !visited[ny as usize][nx as usize] && self.dfs(ny, nx, gy, visited) { [INFO] [stderr] 141 | return true; [INFO] [stderr] 142 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufRead`, `BufReader` [INFO] [stderr] --> src/websocket.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{BufRead, BufReader}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `CloseCode`, `Factory`, `Handler`, `Message` [INFO] [stderr] --> src/main.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | use ws::{CloseCode, Factory, Handler, Message, Sender}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^ ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:122:16 [INFO] [stderr] | [INFO] [stderr] 122 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 123 | | if dy == 1 { [INFO] [stderr] 124 | | (y, x, y, x - 1, Dir::Horizontal) [INFO] [stderr] 125 | | } else { [INFO] [stderr] 126 | | (y - 1, x, y - 1, x - 1, Dir::Horizontal) [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | } else if dy == 1 { [INFO] [stderr] 123 | (y, x, y, x - 1, Dir::Horizontal) [INFO] [stderr] 124 | } else { [INFO] [stderr] 125 | (y - 1, x, y - 1, x - 1, Dir::Horizontal) [INFO] [stderr] 126 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | / if !visited[ny as usize][nx as usize] { [INFO] [stderr] 141 | | if self.dfs(ny, nx, gy, visited) { [INFO] [stderr] 142 | | return true; [INFO] [stderr] 143 | | } [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | if !visited[ny as usize][nx as usize] && self.dfs(ny, nx, gy, visited) { [INFO] [stderr] 141 | return true; [INFO] [stderr] 142 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `out` [INFO] [stderr] --> src/websocket.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | out: Sender, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/main.rs:476:5 [INFO] [stderr] | [INFO] [stderr] 476 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/base64.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | n if n < 26 => ('A' as u8 + n) as char, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/base64.rs:27:38 [INFO] [stderr] | [INFO] [stderr] 27 | n if (26 <= n && n < 52) => ('a' as u8 + (n - 26)) as char, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/base64.rs:28:38 [INFO] [stderr] | [INFO] [stderr] 28 | n if (52 <= n && n < 62) => ('0' as u8 + (n - 52)) as char, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/base64.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | n = n * 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/websocket.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | writer.write(txt.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/websocket.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn new(ip: &String) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 39 | pub fn new(ip: &str) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `ip.clone()` to [INFO] [stderr] | [INFO] [stderr] 42 | ip: ip.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | fn parse(input: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:182:12 [INFO] [stderr] | [INFO] [stderr] 182 | if self.record.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.record.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:188:51 [INFO] [stderr] | [INFO] [stderr] 188 | let (dy, dx) = Record::to_dydx(d).expect(&format!("illegal record:{}", d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("illegal record:{}", d))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:353:15 [INFO] [stderr] | [INFO] [stderr] 353 | s += &(0..(2 * W + 1)).map(|_| "#").collect::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=2 * W)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/main.rs:355:18 [INFO] [stderr] | [INFO] [stderr] 355 | for i in 0..2 * H - 1 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 355 | for in table.iter().take(2 * H - 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:359:15 [INFO] [stderr] | [INFO] [stderr] 359 | s += &(0..(2 * W + 1)).map(|_| "#").collect::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=2 * W)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:430:16 [INFO] [stderr] | [INFO] [stderr] 430 | fn to_dydx(d: u8) -> Option<(i8, i8)> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: field is never used: `out` [INFO] [stderr] --> src/websocket.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | out: Sender, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/main.rs:476:5 [INFO] [stderr] | [INFO] [stderr] 476 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/base64.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | n if n < 26 => ('A' as u8 + n) as char, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/base64.rs:27:38 [INFO] [stderr] | [INFO] [stderr] 27 | n if (26 <= n && n < 52) => ('a' as u8 + (n - 26)) as char, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/base64.rs:28:38 [INFO] [stderr] | [INFO] [stderr] 28 | n if (52 <= n && n < 62) => ('0' as u8 + (n - 52)) as char, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/base64.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | n = n * 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/websocket.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | writer.write(txt.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/websocket.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn new(ip: &String) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 39 | pub fn new(ip: &str) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `ip.clone()` to [INFO] [stderr] | [INFO] [stderr] 42 | ip: ip.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:631:48 [INFO] [stderr] | [INFO] [stderr] 631 | let message: Vec = b.iter() [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 632 | | .take_while(|&c| *c != 13 && *c != 0) [INFO] [stderr] 633 | | .map(|c| *c) [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 631 | let message: Vec = b.iter() [INFO] [stderr] 632 | .take_while(|&c| *c != 13 && *c != 0).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:646:37 [INFO] [stderr] | [INFO] [stderr] 646 | .send(ws::Message::Text(format!("mesg:Game Start"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"mesg:Game Start".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] [INFO] [stderr] --> src/main.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | fn parse(input: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:650:13 [INFO] [stderr] | [INFO] [stderr] 650 | stream.write(&format!("{}\n", id).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:654:9 [INFO] [stderr] | [INFO] [stderr] 654 | self.streams[0].write(&socketmsg.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:659:50 [INFO] [stderr] | [INFO] [stderr] 659 | let s: Vec<&str> = message.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:667:57 [INFO] [stderr] | [INFO] [stderr] 667 | .send(ws::Message::Text(format!("mesg:undo"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"mesg:undo".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:706:21 [INFO] [stderr] | [INFO] [stderr] 706 | stream.write(&socketmsg.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:182:12 [INFO] [stderr] | [INFO] [stderr] 182 | if self.record.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.record.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:188:51 [INFO] [stderr] | [INFO] [stderr] 188 | let (dy, dx) = Record::to_dydx(d).expect(&format!("illegal record:{}", d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("illegal record:{}", d))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:353:15 [INFO] [stderr] | [INFO] [stderr] 353 | s += &(0..(2 * W + 1)).map(|_| "#").collect::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=2 * W)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/main.rs:355:18 [INFO] [stderr] | [INFO] [stderr] 355 | for i in 0..2 * H - 1 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 355 | for in table.iter().take(2 * H - 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:359:15 [INFO] [stderr] | [INFO] [stderr] 359 | s += &(0..(2 * W + 1)).map(|_| "#").collect::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=2 * W)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: Could not compile `quoridor_judge`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:430:16 [INFO] [stderr] | [INFO] [stderr] 430 | fn to_dydx(d: u8) -> Option<(i8, i8)> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:631:48 [INFO] [stderr] | [INFO] [stderr] 631 | let message: Vec = b.iter() [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 632 | | .take_while(|&c| *c != 13 && *c != 0) [INFO] [stderr] 633 | | .map(|c| *c) [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 631 | let message: Vec = b.iter() [INFO] [stderr] 632 | .take_while(|&c| *c != 13 && *c != 0).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:646:37 [INFO] [stderr] | [INFO] [stderr] 646 | .send(ws::Message::Text(format!("mesg:Game Start"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"mesg:Game Start".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:650:13 [INFO] [stderr] | [INFO] [stderr] 650 | stream.write(&format!("{}\n", id).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:654:9 [INFO] [stderr] | [INFO] [stderr] 654 | self.streams[0].write(&socketmsg.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:659:50 [INFO] [stderr] | [INFO] [stderr] 659 | let s: Vec<&str> = message.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:667:57 [INFO] [stderr] | [INFO] [stderr] 667 | .send(ws::Message::Text(format!("mesg:undo"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"mesg:undo".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:706:21 [INFO] [stderr] | [INFO] [stderr] 706 | stream.write(&socketmsg.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `quoridor_judge`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fb9316f8cd2669369b25563af9f257864864335092f64a09b109fbcb5f214bfd"` [INFO] running `"docker" "rm" "-f" "fb9316f8cd2669369b25563af9f257864864335092f64a09b109fbcb5f214bfd"` [INFO] [stdout] fb9316f8cd2669369b25563af9f257864864335092f64a09b109fbcb5f214bfd