[INFO] updating cached repository temporenc/temporenc-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/temporenc/temporenc-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/temporenc/temporenc-rust" "work/ex/clippy-test-run/sources/stable/gh/temporenc/temporenc-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/temporenc/temporenc-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/temporenc/temporenc-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/temporenc/temporenc-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/temporenc/temporenc-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] df6cbf104064379488bde629386a89856520e6e8 [INFO] sha for GitHub repo temporenc/temporenc-rust: df6cbf104064379488bde629386a89856520e6e8 [INFO] validating manifest of temporenc/temporenc-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of temporenc/temporenc-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing temporenc/temporenc-rust [INFO] finished frobbing temporenc/temporenc-rust [INFO] frobbed toml for temporenc/temporenc-rust written to work/ex/clippy-test-run/sources/stable/gh/temporenc/temporenc-rust/Cargo.toml [INFO] started frobbing temporenc/temporenc-rust [INFO] finished frobbing temporenc/temporenc-rust [INFO] frobbed toml for temporenc/temporenc-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/temporenc/temporenc-rust/Cargo.toml [INFO] crate temporenc/temporenc-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting temporenc/temporenc-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/temporenc/temporenc-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9654c87e19c96ce8f1576e690cc6dfe47641ee677feccd315da035666acc43b7 [INFO] running `"docker" "start" "-a" "9654c87e19c96ce8f1576e690cc6dfe47641ee677feccd315da035666acc43b7"` [INFO] [stderr] Checking temporenc v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/date_time_subsecond.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | frac_second_fw: frac_second_fw [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frac_second_fw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/date_time_subsecond_offset.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | frac_second_fw: frac_second_fw, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frac_second_fw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/date_time_subsecond.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | frac_second_fw: frac_second_fw [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frac_second_fw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/date_time_subsecond_offset.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | frac_second_fw: frac_second_fw, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frac_second_fw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_only.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | let mut raw_year = ((byte0 & 0x1F) as u16) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_only.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | raw_year |= (byte1 as u16) >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | let mut raw_year = ((byte0 & 0x3F) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | raw_year |= (byte1 >> 2) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte1 >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_offset.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | x => OffsetValue::UtcOffset(((x as i16) - 64) * 15) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_offset.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | let mut raw_year = ((byte0 & 0x1F) as u16) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_offset.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | raw_year |= (byte1 as u16) >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_only.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | let mut raw_year = ((byte0 & 0x1F) as u16) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_only.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | raw_year |= (byte1 as u16) >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | let mut raw_year = ((byte0 & 0x0F) as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x0F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:177:21 [INFO] [stderr] | [INFO] [stderr] 177 | raw_year |= byte1 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/date_time_subsecond.rs:196:45 [INFO] [stderr] | [INFO] [stderr] 196 | read_exact(reader, &mut buf[MIN_SERIALIZED_SIZE..(MIN_SERIALIZED_SIZE + 1)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `MIN_SERIALIZED_SIZE..=MIN_SERIALIZED_SIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:197:30 [INFO] [stderr] | [INFO] [stderr] 197 | let mut ms = ((byte5 & 0x3F) as u16) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte5 & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:198:23 [INFO] [stderr] | [INFO] [stderr] 198 | ms |= (buf[6] >> 4) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[6] >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:206:30 [INFO] [stderr] | [INFO] [stderr] 206 | let mut us = ((byte5 & 0x3F) as u32) << 14; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte5 & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:207:23 [INFO] [stderr] | [INFO] [stderr] 207 | us |= (buf[6] as u32) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:208:23 [INFO] [stderr] | [INFO] [stderr] 208 | us |= (buf[7] >> 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[7] >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:216:30 [INFO] [stderr] | [INFO] [stderr] 216 | let mut ns = ((byte5 & 0x3F) as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte5 & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | ns |= (buf[6] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:218:23 [INFO] [stderr] | [INFO] [stderr] 218 | ns |= (buf[7] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:219:23 [INFO] [stderr] | [INFO] [stderr] 219 | ns |= buf[8] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/date_time_subsecond_offset.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new(year: Option, month: Option, day: Option, hour: Option, [INFO] [stderr] 24 | | minute: Option, second: Option, frac_second: FractionalSecond, [INFO] [stderr] 25 | | offset: OffsetValue) -> Result { [INFO] [stderr] 26 | | check_frac_second(frac_second)?; [INFO] [stderr] ... | [INFO] [stderr] 37 | | }) [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | x => OffsetValue::UtcOffset(((x as i16) - 64) * 15) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | let mut raw_year = ((byte0 & 0x3F) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | raw_year |= (byte1 >> 2) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte1 >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:196:28 [INFO] [stderr] | [INFO] [stderr] 196 | let mut raw_year = ((byte0 & 0x07) as u16) << 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x07)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:197:21 [INFO] [stderr] | [INFO] [stderr] 197 | raw_year |= (byte1 as u16) << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:198:22 [INFO] [stderr] | [INFO] [stderr] 198 | raw_year |= ((byte2 as u16) & 0x80) >> 7; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/date_time_subsecond_offset.rs:215:45 [INFO] [stderr] | [INFO] [stderr] 215 | read_exact(reader, &mut buf[MIN_SERIALIZED_SIZE..(MIN_SERIALIZED_SIZE + 1)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `MIN_SERIALIZED_SIZE..=MIN_SERIALIZED_SIZE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:216:30 [INFO] [stderr] | [INFO] [stderr] 216 | let mut ms = ((byte5 & 0x1F) as u16) << 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte5 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:218:23 [INFO] [stderr] | [INFO] [stderr] 218 | ms |= (byte6 >> 3) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte6 >> 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:228:30 [INFO] [stderr] | [INFO] [stderr] 228 | let mut us = ((byte5 & 0x1F) as u32) << 15; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte5 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_offset.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | x => OffsetValue::UtcOffset(((x as i16) - 64) * 15) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:229:23 [INFO] [stderr] | [INFO] [stderr] 229 | us |= (buf[6] as u32) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:231:23 [INFO] [stderr] | [INFO] [stderr] 231 | us |= (byte7 >> 1) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte7 >> 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:242:30 [INFO] [stderr] | [INFO] [stderr] 242 | let mut ns = ((byte5 & 0x1F) as u32) << 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte5 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:243:23 [INFO] [stderr] | [INFO] [stderr] 243 | ns |= (buf[6] as u32) << 17; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | ns |= (buf[7] as u32) << 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:245:23 [INFO] [stderr] | [INFO] [stderr] 245 | ns |= (buf[8] as u32) << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:247:23 [INFO] [stderr] | [INFO] [stderr] 247 | ns |= (byte9 >> 7) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte9 >> 7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_offset.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | let mut raw_year = ((byte0 & 0x1F) as u16) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_offset.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | raw_year |= (byte1 as u16) >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/frac_second.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn encode_fixed_width(f: &FractionalSecond) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `FractionalSecond` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/frac_second.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match f { [INFO] [stderr] 11 | | &FractionalSecond::Milliseconds(x) => encode_millis(x), [INFO] [stderr] 12 | | &FractionalSecond::Microseconds(x) => encode_micros(x), [INFO] [stderr] 13 | | &FractionalSecond::Nanoseconds(x) => encode_nanos(x), [INFO] [stderr] 14 | | &FractionalSecond::None => FRAC_SECOND_FIXED_WIDTH_NONE [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | match *f { [INFO] [stderr] 11 | FractionalSecond::Milliseconds(x) => encode_millis(x), [INFO] [stderr] 12 | FractionalSecond::Microseconds(x) => encode_micros(x), [INFO] [stderr] 13 | FractionalSecond::Nanoseconds(x) => encode_nanos(x), [INFO] [stderr] 14 | FractionalSecond::None => FRAC_SECOND_FIXED_WIDTH_NONE [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frac_second.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | FRAC_SECOND_FIXED_WIDTH_MILLI | (millis as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(millis)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | let mut raw_year = ((byte0 & 0x0F) as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x0F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:177:21 [INFO] [stderr] | [INFO] [stderr] 177 | raw_year |= byte1 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/date_time_subsecond.rs:196:45 [INFO] [stderr] | [INFO] [stderr] 196 | read_exact(reader, &mut buf[MIN_SERIALIZED_SIZE..(MIN_SERIALIZED_SIZE + 1)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `MIN_SERIALIZED_SIZE..=MIN_SERIALIZED_SIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:197:30 [INFO] [stderr] | [INFO] [stderr] 197 | let mut ms = ((byte5 & 0x3F) as u16) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte5 & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:198:23 [INFO] [stderr] | [INFO] [stderr] 198 | ms |= (buf[6] >> 4) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[6] >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:206:30 [INFO] [stderr] | [INFO] [stderr] 206 | let mut us = ((byte5 & 0x3F) as u32) << 14; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte5 & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:207:23 [INFO] [stderr] | [INFO] [stderr] 207 | us |= (buf[6] as u32) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:208:23 [INFO] [stderr] | [INFO] [stderr] 208 | us |= (buf[7] >> 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[7] >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:216:30 [INFO] [stderr] | [INFO] [stderr] 216 | let mut ns = ((byte5 & 0x3F) as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte5 & 0x3F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | ns |= (buf[6] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:218:23 [INFO] [stderr] | [INFO] [stderr] 218 | ns |= (buf[7] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond.rs:219:23 [INFO] [stderr] | [INFO] [stderr] 219 | ns |= buf[8] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/date_time_subsecond_offset.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new(year: Option, month: Option, day: Option, hour: Option, [INFO] [stderr] 24 | | minute: Option, second: Option, frac_second: FractionalSecond, [INFO] [stderr] 25 | | offset: OffsetValue) -> Result { [INFO] [stderr] 26 | | check_frac_second(frac_second)?; [INFO] [stderr] ... | [INFO] [stderr] 37 | | }) [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | x => OffsetValue::UtcOffset(((x as i16) - 64) * 15) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:196:28 [INFO] [stderr] | [INFO] [stderr] 196 | let mut raw_year = ((byte0 & 0x07) as u16) << 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte0 & 0x07)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:197:21 [INFO] [stderr] | [INFO] [stderr] 197 | raw_year |= (byte1 as u16) << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:198:22 [INFO] [stderr] | [INFO] [stderr] 198 | raw_year |= ((byte2 as u16) & 0x80) >> 7; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/date_time_subsecond_offset.rs:215:45 [INFO] [stderr] | [INFO] [stderr] 215 | read_exact(reader, &mut buf[MIN_SERIALIZED_SIZE..(MIN_SERIALIZED_SIZE + 1)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `MIN_SERIALIZED_SIZE..=MIN_SERIALIZED_SIZE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:216:30 [INFO] [stderr] | [INFO] [stderr] 216 | let mut ms = ((byte5 & 0x1F) as u16) << 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte5 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:218:23 [INFO] [stderr] | [INFO] [stderr] 218 | ms |= (byte6 >> 3) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(byte6 >> 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:228:30 [INFO] [stderr] | [INFO] [stderr] 228 | let mut us = ((byte5 & 0x1F) as u32) << 15; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte5 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:229:23 [INFO] [stderr] | [INFO] [stderr] 229 | us |= (buf[6] as u32) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:231:23 [INFO] [stderr] | [INFO] [stderr] 231 | us |= (byte7 >> 1) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte7 >> 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:242:30 [INFO] [stderr] | [INFO] [stderr] 242 | let mut ns = ((byte5 & 0x1F) as u32) << 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte5 & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:243:23 [INFO] [stderr] | [INFO] [stderr] 243 | ns |= (buf[6] as u32) << 17; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | ns |= (buf[7] as u32) << 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:245:23 [INFO] [stderr] | [INFO] [stderr] 245 | ns |= (buf[8] as u32) << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time_subsecond_offset.rs:247:23 [INFO] [stderr] | [INFO] [stderr] 247 | ns |= (byte9 >> 7) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte9 >> 7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/frac_second.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn encode_fixed_width(f: &FractionalSecond) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `FractionalSecond` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/frac_second.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match f { [INFO] [stderr] 11 | | &FractionalSecond::Milliseconds(x) => encode_millis(x), [INFO] [stderr] 12 | | &FractionalSecond::Microseconds(x) => encode_micros(x), [INFO] [stderr] 13 | | &FractionalSecond::Nanoseconds(x) => encode_nanos(x), [INFO] [stderr] 14 | | &FractionalSecond::None => FRAC_SECOND_FIXED_WIDTH_NONE [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | match *f { [INFO] [stderr] 11 | FractionalSecond::Milliseconds(x) => encode_millis(x), [INFO] [stderr] 12 | FractionalSecond::Microseconds(x) => encode_micros(x), [INFO] [stderr] 13 | FractionalSecond::Nanoseconds(x) => encode_nanos(x), [INFO] [stderr] 14 | FractionalSecond::None => FRAC_SECOND_FIXED_WIDTH_NONE [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frac_second.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | FRAC_SECOND_FIXED_WIDTH_MILLI | (millis as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(millis)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> benches/common/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | rng: rng [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/mod.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | rng: rng [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> benches/common/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | rng: rng [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> benches/common/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | rng: rng [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/mod.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | rng: rng [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> benches/common/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | rng: rng [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/mod.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | rng: rng [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/single_caller_deserialize_fixed.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `temporenc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/single_caller_deserialize_random.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `temporenc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/single_caller_serialize_struct_random.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `temporenc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/single_caller_deserialize_subsecond_ms.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `temporenc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/date_time_subsecond.rs:76:47 [INFO] [stderr] | [INFO] [stderr] 76 | assert_eq!(FractionalSecond::Microseconds(123456), d.fractional_second()); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/date_time_subsecond.rs:94:46 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(FractionalSecond::Nanoseconds(123456789), d.fractional_second()); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/date_time_subsecond_offset.rs:80:47 [INFO] [stderr] | [INFO] [stderr] 80 | assert_eq!(FractionalSecond::Microseconds(123456), d.fractional_second()); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/date_time_subsecond_offset.rs:99:46 [INFO] [stderr] | [INFO] [stderr] 99 | assert_eq!(FractionalSecond::Nanoseconds(123456789), d.fractional_second()); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_only.rs:54:65 [INFO] [stderr] | [INFO] [stderr] 54 | for year in once(None).chain((YEAR_MIN..(YEAR_MAX + 1)).map(|y| Some(y))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_only.rs:54:34 [INFO] [stderr] | [INFO] [stderr] 54 | for year in once(None).chain((YEAR_MIN..(YEAR_MAX + 1)).map(|y| Some(y))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(YEAR_MIN..=YEAR_MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_only.rs:55:72 [INFO] [stderr] | [INFO] [stderr] 55 | for month in once(None).chain((MONTH_MIN..(MONTH_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_only.rs:55:39 [INFO] [stderr] | [INFO] [stderr] 55 | for month in once(None).chain((MONTH_MIN..(MONTH_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(MONTH_MIN..=MONTH_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_only.rs:56:70 [INFO] [stderr] | [INFO] [stderr] 56 | for day in once(None).chain((DAY_MIN..(DAY_MAX + 1)).map(|d| Some(d))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_only.rs:56:41 [INFO] [stderr] | [INFO] [stderr] 56 | for day in once(None).chain((DAY_MIN..(DAY_MAX + 1)).map(|d| Some(d))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(DAY_MIN..=DAY_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_offset.rs:66:65 [INFO] [stderr] | [INFO] [stderr] 66 | for year in once(None).chain((YEAR_MIN..(YEAR_MAX + 1)).map(|y| Some(y))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_offset.rs:66:34 [INFO] [stderr] | [INFO] [stderr] 66 | for year in once(None).chain((YEAR_MIN..(YEAR_MAX + 1)).map(|y| Some(y))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(YEAR_MIN..=YEAR_MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_offset.rs:67:72 [INFO] [stderr] | [INFO] [stderr] 67 | for month in once(None).chain((MONTH_MIN..(MONTH_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_offset.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | for month in once(None).chain((MONTH_MIN..(MONTH_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(MONTH_MIN..=MONTH_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_offset.rs:68:70 [INFO] [stderr] | [INFO] [stderr] 68 | for day in once(None).chain((DAY_MIN..(DAY_MAX + 1)).map(|d| Some(d))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_offset.rs:68:41 [INFO] [stderr] | [INFO] [stderr] 68 | for day in once(None).chain((DAY_MIN..(DAY_MAX + 1)).map(|d| Some(d))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(DAY_MIN..=DAY_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> tests/date_time_offset.rs:116:1 [INFO] [stderr] | [INFO] [stderr] 116 | / fn serialize_struct_and_check(year: Option, month: Option, day: Option, hour: Option, [INFO] [stderr] 117 | | minute: Option, second: Option, offset: OffsetValue, [INFO] [stderr] 118 | | vec: &mut Vec) { [INFO] [stderr] 119 | | vec.clear(); [INFO] [stderr] ... | [INFO] [stderr] 137 | | assert_eq!(new, deser); [INFO] [stderr] 138 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_subsecond.rs:121:65 [INFO] [stderr] | [INFO] [stderr] 121 | for year in once(None).chain((YEAR_MIN..(YEAR_MAX + 1)).map(|y| Some(y))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_subsecond.rs:121:34 [INFO] [stderr] | [INFO] [stderr] 121 | for year in once(None).chain((YEAR_MIN..(YEAR_MAX + 1)).map(|y| Some(y))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(YEAR_MIN..=YEAR_MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_subsecond.rs:122:72 [INFO] [stderr] | [INFO] [stderr] 122 | for month in once(None).chain((MONTH_MIN..(MONTH_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_subsecond.rs:122:39 [INFO] [stderr] | [INFO] [stderr] 122 | for month in once(None).chain((MONTH_MIN..(MONTH_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(MONTH_MIN..=MONTH_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_subsecond.rs:123:70 [INFO] [stderr] | [INFO] [stderr] 123 | for day in once(None).chain((DAY_MIN..(DAY_MAX + 1)).map(|d| Some(d))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_subsecond.rs:123:41 [INFO] [stderr] | [INFO] [stderr] 123 | for day in once(None).chain((DAY_MIN..(DAY_MAX + 1)).map(|d| Some(d))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(DAY_MIN..=DAY_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_subsecond.rs:145:65 [INFO] [stderr] | [INFO] [stderr] 145 | for hour in once(None).chain((HOUR_MIN..(HOUR_MAX + 1)).map(|h| Some(h))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_subsecond.rs:145:34 [INFO] [stderr] | [INFO] [stderr] 145 | for hour in once(None).chain((HOUR_MIN..(HOUR_MAX + 1)).map(|h| Some(h))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(HOUR_MIN..=HOUR_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_subsecond.rs:146:75 [INFO] [stderr] | [INFO] [stderr] 146 | for minute in once(None).chain((MINUTE_MIN..(MINUTE_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_subsecond.rs:146:40 [INFO] [stderr] | [INFO] [stderr] 146 | for minute in once(None).chain((MINUTE_MIN..(MINUTE_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(MINUTE_MIN..=MINUTE_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_subsecond.rs:147:79 [INFO] [stderr] | [INFO] [stderr] 147 | for second in once(None).chain((SECOND_MIN..(SECOND_MAX + 1)).map(|s| Some(s))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_subsecond.rs:147:44 [INFO] [stderr] | [INFO] [stderr] 147 | for second in once(None).chain((SECOND_MIN..(SECOND_MAX + 1)).map(|s| Some(s))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(SECOND_MIN..=SECOND_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> tests/date_time_subsecond.rs:172:1 [INFO] [stderr] | [INFO] [stderr] 172 | / fn serialize_struct_and_check(year: Option, month: Option, day: Option, hour: Option, [INFO] [stderr] 173 | | minute: Option, second: Option, frac_second: FractionalSecond, [INFO] [stderr] 174 | | vec: &mut Vec) { [INFO] [stderr] 175 | | [INFO] [stderr] ... | [INFO] [stderr] 194 | | assert_eq!(new, deser); [INFO] [stderr] 195 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_subsecond_offset.rs:126:65 [INFO] [stderr] | [INFO] [stderr] 126 | for year in once(None).chain((YEAR_MIN..(YEAR_MAX + 1)).map(|y| Some(y))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_subsecond_offset.rs:126:34 [INFO] [stderr] | [INFO] [stderr] 126 | for year in once(None).chain((YEAR_MIN..(YEAR_MAX + 1)).map(|y| Some(y))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(YEAR_MIN..=YEAR_MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_subsecond_offset.rs:127:72 [INFO] [stderr] | [INFO] [stderr] 127 | for month in once(None).chain((MONTH_MIN..(MONTH_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_subsecond_offset.rs:127:39 [INFO] [stderr] | [INFO] [stderr] 127 | for month in once(None).chain((MONTH_MIN..(MONTH_MAX + 1)).map(|m| Some(m))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(MONTH_MIN..=MONTH_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/date_time_subsecond_offset.rs:128:70 [INFO] [stderr] | [INFO] [stderr] 128 | for day in once(None).chain((DAY_MIN..(DAY_MAX + 1)).map(|d| Some(d))) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/date_time_subsecond_offset.rs:128:41 [INFO] [stderr] | [INFO] [stderr] 128 | for day in once(None).chain((DAY_MIN..(DAY_MAX + 1)).map(|d| Some(d))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(DAY_MIN..=DAY_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> tests/date_time_subsecond_offset.rs:161:1 [INFO] [stderr] | [INFO] [stderr] 161 | / fn serialize_struct_and_check(year: Option, month: Option, day: Option, hour: Option, [INFO] [stderr] 162 | | minute: Option, second: Option, frac_second: FractionalSecond, [INFO] [stderr] 163 | | offset: OffsetValue, vec: &mut Vec) { [INFO] [stderr] 164 | | vec.clear(); [INFO] [stderr] ... | [INFO] [stderr] 184 | | assert_eq!(new, deser); [INFO] [stderr] 185 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "9654c87e19c96ce8f1576e690cc6dfe47641ee677feccd315da035666acc43b7"` [INFO] running `"docker" "rm" "-f" "9654c87e19c96ce8f1576e690cc6dfe47641ee677feccd315da035666acc43b7"` [INFO] [stdout] 9654c87e19c96ce8f1576e690cc6dfe47641ee677feccd315da035666acc43b7