[INFO] updating cached repository tekjar/mqtt311
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tekjar/mqtt311
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tekjar/mqtt311" "work/ex/clippy-test-run/sources/stable/gh/tekjar/mqtt311"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tekjar/mqtt311'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tekjar/mqtt311" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tekjar/mqtt311"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tekjar/mqtt311'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 07f16de6e5085941f3bba750a59abae4bfd39b64
[INFO] sha for GitHub repo tekjar/mqtt311: 07f16de6e5085941f3bba750a59abae4bfd39b64
[INFO] validating manifest of tekjar/mqtt311 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tekjar/mqtt311 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tekjar/mqtt311
[INFO] finished frobbing tekjar/mqtt311
[INFO] frobbed toml for tekjar/mqtt311 written to work/ex/clippy-test-run/sources/stable/gh/tekjar/mqtt311/Cargo.toml
[INFO] started frobbing tekjar/mqtt311
[INFO] finished frobbing tekjar/mqtt311
[INFO] frobbed toml for tekjar/mqtt311 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tekjar/mqtt311/Cargo.toml
[INFO] crate tekjar/mqtt311 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tekjar/mqtt311 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tekjar/mqtt311:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3c77e054b0e0b40b0fbf55317aa7bb2f7fd5f969daf0fe5f6a7c5b57db3b1796
[INFO] running `"docker" "start" "-a" "3c77e054b0e0b40b0fbf55317aa7bb2f7fd5f969daf0fe5f6a7c5b57db3b1796"`
[INFO] [stderr]    Compiling syn v0.15.21
[INFO] [stderr]    Compiling synstructure v0.10.1
[INFO] [stderr]    Compiling derive_more v0.13.0
[INFO] [stderr]    Compiling failure_derive v0.1.3
[INFO] [stderr]     Checking failure v0.1.3
[INFO] [stderr]     Checking mqtt311 v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 |             pkid: pkid,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `pkid`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/msg.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             pkid: pkid,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `pkid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:275:13
[INFO] [stderr]     |
[INFO] [stderr] 275 |             hd: hd,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `hd`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 |             pkid: pkid,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `pkid`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/msg.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             pkid: pkid,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `pkid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:275:13
[INFO] [stderr]     |
[INFO] [stderr] 275 |             hd: hd,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `hd`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:110:37
[INFO] [stderr]     |
[INFO] [stderr] 110 |                 if (connect_flags & 0b00111000) != 0 {
[INFO] [stderr]     |                                     ^^^^^^^^^^ help: consider: `0b0011_1000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:123:46
[INFO] [stderr]     |
[INFO] [stderr] 123 |                     retain: (connect_flags & 0b00100000) != 0
[INFO] [stderr]     |                                              ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:128:46
[INFO] [stderr]     |
[INFO] [stderr] 128 |         let username = match connect_flags & 0b10000000 {
[INFO] [stderr]     |                                              ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:133:46
[INFO] [stderr]     |
[INFO] [stderr] 133 |         let password = match connect_flags & 0b01000000 {
[INFO] [stderr]     |                                              ^^^^^^^^^^ help: consider: `0b0100_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:301:13
[INFO] [stderr]     |
[INFO] [stderr] 301 |             0b11001110, // +username, +password, -will retain, will qos=1, +last_will, +clean_session
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b1100_1110`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:334:13
[INFO] [stderr]     |
[INFO] [stderr] 334 |             0b00000000, // -username, -password, -will retain, will qos=0, -last_will, -clean_session
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:354:43
[INFO] [stderr]     |
[INFO] [stderr] 354 |         let mut stream = Cursor::new(vec![0b00100000, 0x02, 0x01, 0x00]);
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:366:13
[INFO] [stderr]     |
[INFO] [stderr] 366 |             0b00110010, 11,
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b0011_0010`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:387:13
[INFO] [stderr]     |
[INFO] [stderr] 387 |             0b00110000, 7,
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b0011_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:406:43
[INFO] [stderr]     |
[INFO] [stderr] 406 |         let mut stream = Cursor::new(vec![0b01000000, 0x02, 0x00, 0x0A]);
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b0100_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:415:13
[INFO] [stderr]     |
[INFO] [stderr] 415 |             0b10000010, 20,
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b1000_0010`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:440:13
[INFO] [stderr]     |
[INFO] [stderr] 440 |             0b10100010, 17,
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b1010_0010`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/write.rs:10:31
[INFO] [stderr]    |
[INFO] [stderr] 10 |                 self.write_u8(0b00010000)?;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/write.rs:64:31
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 self.write_u8(0b00110000 | publish.retain as u8 | (publish.qos.to_u8() << 1) | ((publish.dup as u8) << 3))?;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `0b0011_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/write.rs:225:13
[INFO] [stderr]     |
[INFO] [stderr] 225 |             0b11001110, // +username, +password, -will retain, will qos=1, +last_will, +clean_session
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b1100_1110`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/write.rs:253:13
[INFO] [stderr]     |
[INFO] [stderr] 253 |             0b00000000, // -username, -password, -will retain, will qos=0, -last_will, -clean_session
[INFO] [stderr]     |             ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/write.rs:269:51
[INFO] [stderr]     |
[INFO] [stderr] 269 |         assert_eq!(stream.get_ref().clone(), vec![0b00100000, 0x02, 0x01, 0x00]);
[INFO] [stderr]     |                                                   ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/write.rs:286:51
[INFO] [stderr]     |
[INFO] [stderr] 286 |         assert_eq!(stream.get_ref().clone(), vec![0b00110010, 11, 0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, 0x00, 0x0a, 0xF1, 0xF2, 0xF3, 0xF4]);
[INFO] [stderr]     |                                                   ^^^^^^^^^^ help: consider: `0b0011_0010`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/write.rs:303:51
[INFO] [stderr]     |
[INFO] [stderr] 303 |         assert_eq!(stream.get_ref().clone(), vec![0b00110000, 9, 0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, 0xE1, 0xE2, 0xE3, 0xE4]);
[INFO] [stderr]     |                                                   ^^^^^^^^^^ help: consider: `0b0011_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/write.rs:320:50
[INFO] [stderr]     |
[INFO] [stderr] 320 |         assert_eq!(stream.get_ref().clone(),vec![0b10000010, 20,
[INFO] [stderr]     |                                                  ^^^^^^^^^^ help: consider: `0b1000_0010`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 | const MAX_PAYLOAD_SIZE: usize = 268435455;
[INFO] [stderr]    |                                 ^^^^^^^^^ help: consider: `268_435_455`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:110:37
[INFO] [stderr]     |
[INFO] [stderr] 110 |                 if (connect_flags & 0b00111000) != 0 {
[INFO] [stderr]     |                                     ^^^^^^^^^^ help: consider: `0b0011_1000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:123:46
[INFO] [stderr]     |
[INFO] [stderr] 123 |                     retain: (connect_flags & 0b00100000) != 0
[INFO] [stderr]     |                                              ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:128:46
[INFO] [stderr]     |
[INFO] [stderr] 128 |         let username = match connect_flags & 0b10000000 {
[INFO] [stderr]     |                                              ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read.rs:133:46
[INFO] [stderr]     |
[INFO] [stderr] 133 |         let password = match connect_flags & 0b01000000 {
[INFO] [stderr]     |                                              ^^^^^^^^^^ help: consider: `0b0100_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/write.rs:10:31
[INFO] [stderr]    |
[INFO] [stderr] 10 |                 self.write_u8(0b00010000)?;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/write.rs:64:31
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 self.write_u8(0b00110000 | publish.retain as u8 | (publish.qos.to_u8() << 1) | ((publish.dup as u8) << 3))?;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `0b0011_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 | const MAX_PAYLOAD_SIZE: usize = 268435455;
[INFO] [stderr]    |                                 ^^^^^^^^^ help: consider: `268_435_455`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]    --> src/read.rs:240:54
[INFO] [stderr]     |
[INFO] [stderr] 240 |     fn read_payload(&mut self, len: usize) -> Result<Box<Vec<u8>>> {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::box_vec)] on by default
[INFO] [stderr]     = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]    --> src/read.rs:240:54
[INFO] [stderr]     |
[INFO] [stderr] 240 |     fn read_payload(&mut self, len: usize) -> Result<Box<Vec<u8>>> {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/write.rs:8:9
[INFO] [stderr]     |
[INFO] [stderr] 8   | /         match packet {
[INFO] [stderr] 9   | |             &Packet::Connect(ref connect) => {
[INFO] [stderr] 10  | |                 self.write_u8(0b00010000)?;
[INFO] [stderr] 11  | |                 let prot_name = connect.protocol.name();
[INFO] [stderr] ...   |
[INFO] [stderr] 152 | |             }
[INFO] [stderr] 153 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 8   |         match *packet {
[INFO] [stderr] 9   |             Packet::Connect(ref connect) => {
[INFO] [stderr] 10  |                 self.write_u8(0b00010000)?;
[INFO] [stderr] 11  |                 let prot_name = connect.protocol.name();
[INFO] [stderr] 12  |                 let mut len = 8 + prot_name.len() + connect.client_id.len();
[INFO] [stderr] 13  |                 if let Some(ref last_will) = connect.last_will {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/write.rs:36:24
[INFO] [stderr]    |
[INFO] [stderr] 36 |                   if let Some(_) = connect.password {
[INFO] [stderr]    |  _________________-      ^^^^^^^
[INFO] [stderr] 37 | |                     connect_flags |= 0x40;
[INFO] [stderr] 38 | |                 }
[INFO] [stderr]    | |_________________- help: try this: `if connect.password.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/write.rs:39:24
[INFO] [stderr]    |
[INFO] [stderr] 39 |                   if let Some(_) = connect.username {
[INFO] [stderr]    |  _________________-      ^^^^^^^
[INFO] [stderr] 40 | |                     connect_flags |= 0x80;
[INFO] [stderr] 41 | |                 }
[INFO] [stderr]    | |_________________- help: try this: `if connect.username.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/write.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             x = x / 128;
[INFO] [stderr]     |             ^^^^^^^^^^^ help: replace it with: `x /= 128`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/write.rs:174:17
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 byte = byte | 128;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `byte |= 128`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/write.rs:177:20
[INFO] [stderr]     |
[INFO] [stderr] 177 |             done = x <= 0;
[INFO] [stderr]     |                    ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using x == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/topic.rs:39:35
[INFO] [stderr]    |
[INFO] [stderr] 39 |             _ => !(topic.contains("+") || topic.contains("#"))
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/topic.rs:39:58
[INFO] [stderr]    |
[INFO] [stderr] 39 |             _ => !(topic.contains("+") || topic.contains("#"))
[INFO] [stderr]    |                                                          ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: item `topic::TopicPath` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/topic.rs:88:1
[INFO] [stderr]     |
[INFO] [stderr] 88  | / impl TopicPath {
[INFO] [stderr] 89  | |     pub fn path(&self) -> String {
[INFO] [stderr] 90  | |         self.path.clone()
[INFO] [stderr] 91  | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 153 | |     }
[INFO] [stderr] 154 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/topic.rs:117:5
[INFO] [stderr]     |
[INFO] [stderr] 117 | /     pub fn from_str<T: AsRef<str>>(path: T) -> Result<TopicPath> {
[INFO] [stderr] 118 | |         let mut valid = true;
[INFO] [stderr] 119 | |         let topics: Vec<Topic> = path.as_ref().split(TOPIC_PATH_DELIMITER).map( |topic| {
[INFO] [stderr] 120 | |             match topic {
[INFO] [stderr] ...   |
[INFO] [stderr] 152 | |         })
[INFO] [stderr] 153 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/topic.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 | /         match topic_name.wildcards {
[INFO] [stderr] 188 | |             false => Ok(topic_name),
[INFO] [stderr] 189 | |             true => Err(Error::TopicNameMustNotContainWildcard)
[INFO] [stderr] 190 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if topic_name.wildcards { Err(Error::TopicNameMustNotContainWildcard) } else { Ok(topic_name) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: local variable doesn't need to be boxed here
[INFO] [stderr]   --> src/msg.rs:16:21
[INFO] [stderr]    |
[INFO] [stderr] 16 |     pub fn from_pub(publish: Box<Publish>) -> Result<Box<Message>> {
[INFO] [stderr]    |                     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::boxed_local)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:71:17
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn name(&self) -> &'static str {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 | /         match self {
[INFO] [stderr] 73 | |             &Protocol::MQIsdp(_) => "MQIsdp",
[INFO] [stderr] 74 | |             &Protocol::MQTT(_) => "MQTT"
[INFO] [stderr] 75 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 72 |         match *self {
[INFO] [stderr] 73 |             Protocol::MQIsdp(_) => "MQIsdp",
[INFO] [stderr] 74 |             Protocol::MQTT(_) => "MQTT"
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:78:18
[INFO] [stderr]    |
[INFO] [stderr] 78 |     pub fn level(&self) -> u8 {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:79:9
[INFO] [stderr]    |
[INFO] [stderr] 79 | /         match self {
[INFO] [stderr] 80 | |             &Protocol::MQIsdp(level) => level,
[INFO] [stderr] 81 | |             &Protocol::MQTT(level) => level
[INFO] [stderr] 82 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 79 |         match *self {
[INFO] [stderr] 80 |             Protocol::MQIsdp(level) => level,
[INFO] [stderr] 81 |             Protocol::MQTT(level) => level
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:108:18
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:116:16
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn min(&self, other: QoS) -> QoS {
[INFO] [stderr]     |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:150:18
[INFO] [stderr]     |
[INFO] [stderr] 150 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:198:41
[INFO] [stderr]     |
[INFO] [stderr] 198 |         let first_space = str.find(' ').unwrap_or(str.len());
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| str.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:215:18
[INFO] [stderr]     |
[INFO] [stderr] 215 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:247:17
[INFO] [stderr]     |
[INFO] [stderr] 247 |     pub fn next(&self) -> PacketIdentifier {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: item `Header` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:272:1
[INFO] [stderr]     |
[INFO] [stderr] 272 | / impl Header {
[INFO] [stderr] 273 | |     pub fn new(hd: u8, len: usize) -> Result<Header> {
[INFO] [stderr] 274 | |         Ok(Header {
[INFO] [stderr] 275 | |             hd: hd,
[INFO] [stderr] ...   |
[INFO] [stderr] 311 | |     }
[INFO] [stderr] 312 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mqtt311`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]    --> src/read.rs:240:54
[INFO] [stderr]     |
[INFO] [stderr] 240 |     fn read_payload(&mut self, len: usize) -> Result<Box<Vec<u8>>> {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::box_vec)] on by default
[INFO] [stderr]     = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]    --> src/read.rs:240:54
[INFO] [stderr]     |
[INFO] [stderr] 240 |     fn read_payload(&mut self, len: usize) -> Result<Box<Vec<u8>>> {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:299:25
[INFO] [stderr]     |
[INFO] [stderr] 299 |             0x00, 0x04, 'M' as u8, 'Q' as u8, 'T' as u8, 'T' as u8,
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'M'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:299:36
[INFO] [stderr]     |
[INFO] [stderr] 299 |             0x00, 0x04, 'M' as u8, 'Q' as u8, 'T' as u8, 'T' as u8,
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'Q'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:299:47
[INFO] [stderr]     |
[INFO] [stderr] 299 |             0x00, 0x04, 'M' as u8, 'Q' as u8, 'T' as u8, 'T' as u8,
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'T'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:299:58
[INFO] [stderr]     |
[INFO] [stderr] 299 |             0x00, 0x04, 'M' as u8, 'Q' as u8, 'T' as u8, 'T' as u8,
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'T'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:303:25
[INFO] [stderr]     |
[INFO] [stderr] 303 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8, // client_id
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:303:36
[INFO] [stderr]     |
[INFO] [stderr] 303 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8, // client_id
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'e'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:303:47
[INFO] [stderr]     |
[INFO] [stderr] 303 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8, // client_id
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b's'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:303:58
[INFO] [stderr]     |
[INFO] [stderr] 303 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8, // client_id
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:304:25
[INFO] [stderr]     |
[INFO] [stderr] 304 |             0x00, 0x02, '/' as u8, 'a' as u8, // will topic = '/a'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:304:36
[INFO] [stderr]     |
[INFO] [stderr] 304 |             0x00, 0x02, '/' as u8, 'a' as u8, // will topic = '/a'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:305:25
[INFO] [stderr]     |
[INFO] [stderr] 305 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'o'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:305:36
[INFO] [stderr]     |
[INFO] [stderr] 305 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'f'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:305:47
[INFO] [stderr]     |
[INFO] [stderr] 305 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'f'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:305:58
[INFO] [stderr]     |
[INFO] [stderr] 305 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'l'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:305:69
[INFO] [stderr]     |
[INFO] [stderr] 305 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'i'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:305:80
[INFO] [stderr]     |
[INFO] [stderr] 305 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                                                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'n'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:305:91
[INFO] [stderr]     |
[INFO] [stderr] 305 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                                                                           ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'e'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:306:25
[INFO] [stderr]     |
[INFO] [stderr] 306 |             0x00, 0x04, 'r' as u8, 'u' as u8, 's' as u8, 't' as u8, // username = 'rust'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'r'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:306:36
[INFO] [stderr]     |
[INFO] [stderr] 306 |             0x00, 0x04, 'r' as u8, 'u' as u8, 's' as u8, 't' as u8, // username = 'rust'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'u'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:306:47
[INFO] [stderr]     |
[INFO] [stderr] 306 |             0x00, 0x04, 'r' as u8, 'u' as u8, 's' as u8, 't' as u8, // username = 'rust'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b's'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:306:58
[INFO] [stderr]     |
[INFO] [stderr] 306 |             0x00, 0x04, 'r' as u8, 'u' as u8, 's' as u8, 't' as u8, // username = 'rust'
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:307:25
[INFO] [stderr]     |
[INFO] [stderr] 307 |             0x00, 0x02, 'm' as u8, 'q' as u8 // password = 'mq'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'm'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:307:36
[INFO] [stderr]     |
[INFO] [stderr] 307 |             0x00, 0x02, 'm' as u8, 'q' as u8 // password = 'mq'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'q'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:332:25
[INFO] [stderr]     |
[INFO] [stderr] 332 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'M'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:332:36
[INFO] [stderr]     |
[INFO] [stderr] 332 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'Q'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:332:47
[INFO] [stderr]     |
[INFO] [stderr] 332 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'I'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:332:58
[INFO] [stderr]     |
[INFO] [stderr] 332 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b's'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:332:69
[INFO] [stderr]     |
[INFO] [stderr] 332 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'd'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:332:80
[INFO] [stderr]     |
[INFO] [stderr] 332 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                                                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'p'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:336:25
[INFO] [stderr]     |
[INFO] [stderr] 336 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8 // client_id
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:336:36
[INFO] [stderr]     |
[INFO] [stderr] 336 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8 // client_id
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'e'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:336:47
[INFO] [stderr]     |
[INFO] [stderr] 336 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8 // client_id
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b's'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:336:58
[INFO] [stderr]     |
[INFO] [stderr] 336 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8 // client_id
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:367:25
[INFO] [stderr]     |
[INFO] [stderr] 367 |             0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, // topic name = 'a/b'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:367:36
[INFO] [stderr]     |
[INFO] [stderr] 367 |             0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, // topic name = 'a/b'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:367:47
[INFO] [stderr]     |
[INFO] [stderr] 367 |             0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, // topic name = 'a/b'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'b'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:388:25
[INFO] [stderr]     |
[INFO] [stderr] 388 |             0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, // topic name = 'a/b'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:388:36
[INFO] [stderr]     |
[INFO] [stderr] 388 |             0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, // topic name = 'a/b'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:388:47
[INFO] [stderr]     |
[INFO] [stderr] 388 |             0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, // topic name = 'a/b'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'b'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:417:25
[INFO] [stderr]     |
[INFO] [stderr] 417 |             0x00, 0x03, 'a' as u8, '/' as u8, '+' as u8, // topic filter = 'a/+'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:417:36
[INFO] [stderr]     |
[INFO] [stderr] 417 |             0x00, 0x03, 'a' as u8, '/' as u8, '+' as u8, // topic filter = 'a/+'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:417:47
[INFO] [stderr]     |
[INFO] [stderr] 417 |             0x00, 0x03, 'a' as u8, '/' as u8, '+' as u8, // topic filter = 'a/+'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'+'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:419:25
[INFO] [stderr]     |
[INFO] [stderr] 419 |             0x00, 0x01, '#' as u8, // topic filter = '#'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'#'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:421:25
[INFO] [stderr]     |
[INFO] [stderr] 421 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:421:36
[INFO] [stderr]     |
[INFO] [stderr] 421 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:421:47
[INFO] [stderr]     |
[INFO] [stderr] 421 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'b'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:421:58
[INFO] [stderr]     |
[INFO] [stderr] 421 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:421:69
[INFO] [stderr]     |
[INFO] [stderr] 421 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'c'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:442:25
[INFO] [stderr]     |
[INFO] [stderr] 442 |             0x00, 0x03, 'a' as u8, '/' as u8, '+' as u8, // topic filter = 'a/+'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:442:36
[INFO] [stderr]     |
[INFO] [stderr] 442 |             0x00, 0x03, 'a' as u8, '/' as u8, '+' as u8, // topic filter = 'a/+'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:442:47
[INFO] [stderr]     |
[INFO] [stderr] 442 |             0x00, 0x03, 'a' as u8, '/' as u8, '+' as u8, // topic filter = 'a/+'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'+'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:443:25
[INFO] [stderr]     |
[INFO] [stderr] 443 |             0x00, 0x01, '#' as u8, // topic filter = '#'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'#'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:444:25
[INFO] [stderr]     |
[INFO] [stderr] 444 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:444:36
[INFO] [stderr]     |
[INFO] [stderr] 444 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:444:47
[INFO] [stderr]     |
[INFO] [stderr] 444 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'b'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:444:58
[INFO] [stderr]     |
[INFO] [stderr] 444 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/read.rs:444:69
[INFO] [stderr]     |
[INFO] [stderr] 444 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'c'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/write.rs:8:9
[INFO] [stderr]     |
[INFO] [stderr] 8   | /         match packet {
[INFO] [stderr] 9   | |             &Packet::Connect(ref connect) => {
[INFO] [stderr] 10  | |                 self.write_u8(0b00010000)?;
[INFO] [stderr] 11  | |                 let prot_name = connect.protocol.name();
[INFO] [stderr] ...   |
[INFO] [stderr] 152 | |             }
[INFO] [stderr] 153 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 8   |         match *packet {
[INFO] [stderr] 9   |             Packet::Connect(ref connect) => {
[INFO] [stderr] 10  |                 self.write_u8(0b00010000)?;
[INFO] [stderr] 11  |                 let prot_name = connect.protocol.name();
[INFO] [stderr] 12  |                 let mut len = 8 + prot_name.len() + connect.client_id.len();
[INFO] [stderr] 13  |                 if let Some(ref last_will) = connect.last_will {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/write.rs:36:24
[INFO] [stderr]    |
[INFO] [stderr] 36 |                   if let Some(_) = connect.password {
[INFO] [stderr]    |  _________________-      ^^^^^^^
[INFO] [stderr] 37 | |                     connect_flags |= 0x40;
[INFO] [stderr] 38 | |                 }
[INFO] [stderr]    | |_________________- help: try this: `if connect.password.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/write.rs:39:24
[INFO] [stderr]    |
[INFO] [stderr] 39 |                   if let Some(_) = connect.username {
[INFO] [stderr]    |  _________________-      ^^^^^^^
[INFO] [stderr] 40 | |                     connect_flags |= 0x80;
[INFO] [stderr] 41 | |                 }
[INFO] [stderr]    | |_________________- help: try this: `if connect.username.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/write.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             x = x / 128;
[INFO] [stderr]     |             ^^^^^^^^^^^ help: replace it with: `x /= 128`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/write.rs:174:17
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 byte = byte | 128;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `byte |= 128`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/write.rs:177:20
[INFO] [stderr]     |
[INFO] [stderr] 177 |             done = x <= 0;
[INFO] [stderr]     |                    ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using x == 0 instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:223:25
[INFO] [stderr]     |
[INFO] [stderr] 223 |             0x00, 0x04, 'M' as u8, 'Q' as u8, 'T' as u8, 'T' as u8,
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'M'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:223:36
[INFO] [stderr]     |
[INFO] [stderr] 223 |             0x00, 0x04, 'M' as u8, 'Q' as u8, 'T' as u8, 'T' as u8,
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'Q'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:223:47
[INFO] [stderr]     |
[INFO] [stderr] 223 |             0x00, 0x04, 'M' as u8, 'Q' as u8, 'T' as u8, 'T' as u8,
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'T'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:223:58
[INFO] [stderr]     |
[INFO] [stderr] 223 |             0x00, 0x04, 'M' as u8, 'Q' as u8, 'T' as u8, 'T' as u8,
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'T'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:227:25
[INFO] [stderr]     |
[INFO] [stderr] 227 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8, // client_id
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:227:36
[INFO] [stderr]     |
[INFO] [stderr] 227 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8, // client_id
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'e'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:227:47
[INFO] [stderr]     |
[INFO] [stderr] 227 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8, // client_id
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b's'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:227:58
[INFO] [stderr]     |
[INFO] [stderr] 227 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8, // client_id
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:228:25
[INFO] [stderr]     |
[INFO] [stderr] 228 |             0x00, 0x02, '/' as u8, 'a' as u8, // will topic = '/a'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:228:36
[INFO] [stderr]     |
[INFO] [stderr] 228 |             0x00, 0x02, '/' as u8, 'a' as u8, // will topic = '/a'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:229:25
[INFO] [stderr]     |
[INFO] [stderr] 229 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'o'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:229:36
[INFO] [stderr]     |
[INFO] [stderr] 229 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'f'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:229:47
[INFO] [stderr]     |
[INFO] [stderr] 229 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'f'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:229:58
[INFO] [stderr]     |
[INFO] [stderr] 229 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'l'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:229:69
[INFO] [stderr]     |
[INFO] [stderr] 229 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'i'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:229:80
[INFO] [stderr]     |
[INFO] [stderr] 229 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                                                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'n'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:229:91
[INFO] [stderr]     |
[INFO] [stderr] 229 |             0x00, 0x07, 'o' as u8, 'f' as u8, 'f' as u8, 'l' as u8, 'i' as u8, 'n' as u8, 'e' as u8, // will msg = 'offline'
[INFO] [stderr]     |                                                                                           ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'e'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:230:25
[INFO] [stderr]     |
[INFO] [stderr] 230 |             0x00, 0x04, 'r' as u8, 'u' as u8, 's' as u8, 't' as u8, // username = 'rust'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'r'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:230:36
[INFO] [stderr]     |
[INFO] [stderr] 230 |             0x00, 0x04, 'r' as u8, 'u' as u8, 's' as u8, 't' as u8, // username = 'rust'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'u'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:230:47
[INFO] [stderr]     |
[INFO] [stderr] 230 |             0x00, 0x04, 'r' as u8, 'u' as u8, 's' as u8, 't' as u8, // username = 'rust'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b's'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:230:58
[INFO] [stderr]     |
[INFO] [stderr] 230 |             0x00, 0x04, 'r' as u8, 'u' as u8, 's' as u8, 't' as u8, // username = 'rust'
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:231:25
[INFO] [stderr]     |
[INFO] [stderr] 231 |             0x00, 0x02, 'm' as u8, 'q' as u8 // password = 'mq'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'm'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:231:36
[INFO] [stderr]     |
[INFO] [stderr] 231 |             0x00, 0x02, 'm' as u8, 'q' as u8 // password = 'mq'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'q'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:251:25
[INFO] [stderr]     |
[INFO] [stderr] 251 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'M'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:251:36
[INFO] [stderr]     |
[INFO] [stderr] 251 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'Q'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:251:47
[INFO] [stderr]     |
[INFO] [stderr] 251 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'I'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:251:58
[INFO] [stderr]     |
[INFO] [stderr] 251 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b's'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:251:69
[INFO] [stderr]     |
[INFO] [stderr] 251 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'd'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:251:80
[INFO] [stderr]     |
[INFO] [stderr] 251 |             0x00, 0x06, 'M' as u8, 'Q' as u8, 'I' as u8, 's' as u8, 'd' as u8, 'p' as u8,
[INFO] [stderr]     |                                                                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'p'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:255:25
[INFO] [stderr]     |
[INFO] [stderr] 255 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8 // client_id
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:255:36
[INFO] [stderr]     |
[INFO] [stderr] 255 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8 // client_id
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'e'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:255:47
[INFO] [stderr]     |
[INFO] [stderr] 255 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8 // client_id
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b's'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:255:58
[INFO] [stderr]     |
[INFO] [stderr] 255 |             0x00, 0x04, 't' as u8, 'e' as u8, 's' as u8, 't' as u8 // client_id
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b't'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:286:79
[INFO] [stderr]     |
[INFO] [stderr] 286 |         assert_eq!(stream.get_ref().clone(), vec![0b00110010, 11, 0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, 0x00, 0x0a, 0xF1, 0xF2, 0xF3, 0xF4]);
[INFO] [stderr]     |                                                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:286:90
[INFO] [stderr]     |
[INFO] [stderr] 286 |         assert_eq!(stream.get_ref().clone(), vec![0b00110010, 11, 0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, 0x00, 0x0a, 0xF1, 0xF2, 0xF3, 0xF4]);
[INFO] [stderr]     |                                                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:286:101
[INFO] [stderr]     |
[INFO] [stderr] 286 |         assert_eq!(stream.get_ref().clone(), vec![0b00110010, 11, 0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, 0x00, 0x0a, 0xF1, 0xF2, 0xF3, 0xF4]);
[INFO] [stderr]     |                                                                                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'b'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:303:78
[INFO] [stderr]     |
[INFO] [stderr] 303 |         assert_eq!(stream.get_ref().clone(), vec![0b00110000, 9, 0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, 0xE1, 0xE2, 0xE3, 0xE4]);
[INFO] [stderr]     |                                                                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:303:89
[INFO] [stderr]     |
[INFO] [stderr] 303 |         assert_eq!(stream.get_ref().clone(), vec![0b00110000, 9, 0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, 0xE1, 0xE2, 0xE3, 0xE4]);
[INFO] [stderr]     |                                                                                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:303:100
[INFO] [stderr]     |
[INFO] [stderr] 303 |         assert_eq!(stream.get_ref().clone(), vec![0b00110000, 9, 0x00, 0x03, 'a' as u8, '/' as u8, 'b' as u8, 0xE1, 0xE2, 0xE3, 0xE4]);
[INFO] [stderr]     |                                                                                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'b'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:322:25
[INFO] [stderr]     |
[INFO] [stderr] 322 |             0x00, 0x03, 'a' as u8, '/' as u8, '+' as u8, // topic filter = 'a/+'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:322:36
[INFO] [stderr]     |
[INFO] [stderr] 322 |             0x00, 0x03, 'a' as u8, '/' as u8, '+' as u8, // topic filter = 'a/+'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:322:47
[INFO] [stderr]     |
[INFO] [stderr] 322 |             0x00, 0x03, 'a' as u8, '/' as u8, '+' as u8, // topic filter = 'a/+'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'+'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:324:25
[INFO] [stderr]     |
[INFO] [stderr] 324 |             0x00, 0x01, '#' as u8, // topic filter = '#'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'#'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:326:25
[INFO] [stderr]     |
[INFO] [stderr] 326 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:326:36
[INFO] [stderr]     |
[INFO] [stderr] 326 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:326:47
[INFO] [stderr]     |
[INFO] [stderr] 326 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'b'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:326:58
[INFO] [stderr]     |
[INFO] [stderr] 326 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'/'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/write.rs:326:69
[INFO] [stderr]     |
[INFO] [stderr] 326 |             0x00, 0x05, 'a' as u8, '/' as u8, 'b' as u8, '/' as u8, 'c' as u8, // topic filter = 'a/b/c'
[INFO] [stderr]     |                                                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'c'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/topic.rs:39:35
[INFO] [stderr]    |
[INFO] [stderr] 39 |             _ => !(topic.contains("+") || topic.contains("#"))
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/topic.rs:39:58
[INFO] [stderr]    |
[INFO] [stderr] 39 |             _ => !(topic.contains("+") || topic.contains("#"))
[INFO] [stderr]    |                                                          ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: item `topic::TopicPath` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/topic.rs:88:1
[INFO] [stderr]     |
[INFO] [stderr] 88  | / impl TopicPath {
[INFO] [stderr] 89  | |     pub fn path(&self) -> String {
[INFO] [stderr] 90  | |         self.path.clone()
[INFO] [stderr] 91  | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 153 | |     }
[INFO] [stderr] 154 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/topic.rs:117:5
[INFO] [stderr]     |
[INFO] [stderr] 117 | /     pub fn from_str<T: AsRef<str>>(path: T) -> Result<TopicPath> {
[INFO] [stderr] 118 | |         let mut valid = true;
[INFO] [stderr] 119 | |         let topics: Vec<Topic> = path.as_ref().split(TOPIC_PATH_DELIMITER).map( |topic| {
[INFO] [stderr] 120 | |             match topic {
[INFO] [stderr] ...   |
[INFO] [stderr] 152 | |         })
[INFO] [stderr] 153 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/topic.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 | /         match topic_name.wildcards {
[INFO] [stderr] 188 | |             false => Ok(topic_name),
[INFO] [stderr] 189 | |             true => Err(Error::TopicNameMustNotContainWildcard)
[INFO] [stderr] 190 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if topic_name.wildcards { Err(Error::TopicNameMustNotContainWildcard) } else { Ok(topic_name) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: local variable doesn't need to be boxed here
[INFO] [stderr]   --> src/msg.rs:16:21
[INFO] [stderr]    |
[INFO] [stderr] 16 |     pub fn from_pub(publish: Box<Publish>) -> Result<Box<Message>> {
[INFO] [stderr]    |                     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::boxed_local)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:71:17
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn name(&self) -> &'static str {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 | /         match self {
[INFO] [stderr] 73 | |             &Protocol::MQIsdp(_) => "MQIsdp",
[INFO] [stderr] 74 | |             &Protocol::MQTT(_) => "MQTT"
[INFO] [stderr] 75 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 72 |         match *self {
[INFO] [stderr] 73 |             Protocol::MQIsdp(_) => "MQIsdp",
[INFO] [stderr] 74 |             Protocol::MQTT(_) => "MQTT"
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:78:18
[INFO] [stderr]    |
[INFO] [stderr] 78 |     pub fn level(&self) -> u8 {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:79:9
[INFO] [stderr]    |
[INFO] [stderr] 79 | /         match self {
[INFO] [stderr] 80 | |             &Protocol::MQIsdp(level) => level,
[INFO] [stderr] 81 | |             &Protocol::MQTT(level) => level
[INFO] [stderr] 82 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 79 |         match *self {
[INFO] [stderr] 80 |             Protocol::MQIsdp(level) => level,
[INFO] [stderr] 81 |             Protocol::MQTT(level) => level
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:108:18
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:116:16
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn min(&self, other: QoS) -> QoS {
[INFO] [stderr]     |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:150:18
[INFO] [stderr]     |
[INFO] [stderr] 150 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:198:41
[INFO] [stderr]     |
[INFO] [stderr] 198 |         let first_space = str.find(' ').unwrap_or(str.len());
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| str.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:215:18
[INFO] [stderr]     |
[INFO] [stderr] 215 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:247:17
[INFO] [stderr]     |
[INFO] [stderr] 247 |     pub fn next(&self) -> PacketIdentifier {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: item `Header` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:272:1
[INFO] [stderr]     |
[INFO] [stderr] 272 | / impl Header {
[INFO] [stderr] 273 | |     pub fn new(hd: u8, len: usize) -> Result<Header> {
[INFO] [stderr] 274 | |         Ok(Header {
[INFO] [stderr] 275 | |             hd: hd,
[INFO] [stderr] ...   |
[INFO] [stderr] 311 | |     }
[INFO] [stderr] 312 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mqtt311`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "3c77e054b0e0b40b0fbf55317aa7bb2f7fd5f969daf0fe5f6a7c5b57db3b1796"`
[INFO] running `"docker" "rm" "-f" "3c77e054b0e0b40b0fbf55317aa7bb2f7fd5f969daf0fe5f6a7c5b57db3b1796"`
[INFO] [stdout] 3c77e054b0e0b40b0fbf55317aa7bb2f7fd5f969daf0fe5f6a7c5b57db3b1796