[INFO] updating cached repository tehzz/facevtxdump [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tehzz/facevtxdump [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tehzz/facevtxdump" "work/ex/clippy-test-run/sources/stable/gh/tehzz/facevtxdump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tehzz/facevtxdump'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tehzz/facevtxdump" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tehzz/facevtxdump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tehzz/facevtxdump'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ee4f26bb4fd6f9662f272a2ffa4f9c45e7ac55f1 [INFO] sha for GitHub repo tehzz/facevtxdump: ee4f26bb4fd6f9662f272a2ffa4f9c45e7ac55f1 [INFO] validating manifest of tehzz/facevtxdump on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tehzz/facevtxdump on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tehzz/facevtxdump [INFO] finished frobbing tehzz/facevtxdump [INFO] frobbed toml for tehzz/facevtxdump written to work/ex/clippy-test-run/sources/stable/gh/tehzz/facevtxdump/Cargo.toml [INFO] started frobbing tehzz/facevtxdump [INFO] finished frobbing tehzz/facevtxdump [INFO] frobbed toml for tehzz/facevtxdump written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tehzz/facevtxdump/Cargo.toml [INFO] crate tehzz/facevtxdump has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tehzz/facevtxdump against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tehzz/facevtxdump:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f685d83d2b0a85bff32bdf7042659a6a4e8f3b85277d26c6623e2187ec878031 [INFO] running `"docker" "start" "-a" "f685d83d2b0a85bff32bdf7042659a6a4e8f3b85277d26c6623e2187ec878031"` [INFO] [stderr] Compiling structopt-derive v0.2.12 [INFO] [stderr] Checking structopt v0.2.12 [INFO] [stderr] Checking facevtxdump v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vtx.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | const DATA_ARR: &'static str = "vtxdata"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vtx.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | const INFO_VAR: &'static str = "verts"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vtx.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const SZ_DEFINE: &'static str = "VTX_NUM"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vtx.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const INDENT: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/faces.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | const DATA_ARR: &'static str = "facedata"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/faces.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | const INFO_VAR: &'static str = "faces"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/faces.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const SZ_DEFINE: &'static str = "FACE_NUM"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/faces.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const INDENT: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/anims/mod.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | const DATA_ARR: &'static str = "animdata"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/anims/mod.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | const INFO_VAR: &'static str = "anim"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/anims/mod.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | const INDENT: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/anims/mod.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | const SEPARATOR: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vtx.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | const DATA_ARR: &'static str = "vtxdata"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vtx.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | const INFO_VAR: &'static str = "verts"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vtx.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const SZ_DEFINE: &'static str = "VTX_NUM"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vtx.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const INDENT: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/faces.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | const DATA_ARR: &'static str = "facedata"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/faces.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | const INFO_VAR: &'static str = "faces"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/faces.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const SZ_DEFINE: &'static str = "FACE_NUM"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/faces.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const INDENT: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/anims/mod.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | const DATA_ARR: &'static str = "animdata"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/anims/mod.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | const INFO_VAR: &'static str = "anim"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/anims/mod.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | const INDENT: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/anims/mod.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | const SEPARATOR: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/vtx.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | Some(o) => o as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(o)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/vtx.rs:56:36 [INFO] [stderr] | [INFO] [stderr] 56 | let data_start = data_offset + vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/vtx.rs:57:31 [INFO] [stderr] | [INFO] [stderr] 57 | let info_addr = offset + vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vtx.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | writeln!(wtr, "#undef {}", SZ_DEFINE); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/faces.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | Some(o) => o as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/faces.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | let data_start = data_offset + vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/faces.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | let info_addr = offset + vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/faces.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | writeln!(wtr, "#define {} {}", SZ_DEFINE, info.count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/faces.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | writeln!(wtr, "#undef {}", SZ_DEFINE); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/anims/iter.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | return Some(Err(e.into())); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/anims/mod.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | let vram = vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/anims/mod.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / writeln!(&mut info_str, "{}{{ {}, {}, NULL }},", [INFO] [stderr] 51 | | INDENT, info.count, info.kind [INFO] [stderr] 52 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/anims/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / writeln!(&mut info_str, "{}{{ {}, {}, {}_{:08X} }},", [INFO] [stderr] 55 | | INDENT, info.count, info.kind, DATA_ARR, info.data_ptr [INFO] [stderr] 56 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/anims/mod.rs:84:63 [INFO] [stderr] | [INFO] [stderr] 84 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| AnimDumpErr::Tlb(info.data_ptr, ram))` [INFO] [stderr] | [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/vtx.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | Some(o) => o as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(o)` [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/anims/mod.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.data_ptr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/anims/mod.rs:109:63 [INFO] [stderr] | [INFO] [stderr] 109 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| AnimDumpErr::Tlb(info.data_ptr, ram))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/vtx.rs:56:36 [INFO] [stderr] | [INFO] [stderr] 56 | let data_start = data_offset + vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/vtx.rs:57:31 [INFO] [stderr] | [INFO] [stderr] 57 | let info_addr = offset + vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/anims/mod.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.data_ptr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vtx.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | writeln!(wtr, "#undef {}", SZ_DEFINE); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/anims/mod.rs:134:63 [INFO] [stderr] | [INFO] [stderr] 134 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| AnimDumpErr::Tlb(info.data_ptr, ram))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/anims/mod.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.data_ptr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/faces.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | Some(o) => o as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/faces.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | let data_start = data_offset + vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/faces.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | let info_addr = offset + vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/faces.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | writeln!(wtr, "#define {} {}", SZ_DEFINE, info.count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/faces.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | writeln!(wtr, "#undef {}", SZ_DEFINE); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/anims/iter.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | return Some(Err(e.into())); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/anims/mod.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | let vram = vram as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(vram)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/anims/mod.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / writeln!(&mut info_str, "{}{{ {}, {}, NULL }},", [INFO] [stderr] 51 | | INDENT, info.count, info.kind [INFO] [stderr] 52 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/anims/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / writeln!(&mut info_str, "{}{{ {}, {}, {}_{:08X} }},", [INFO] [stderr] 55 | | INDENT, info.count, info.kind, DATA_ARR, info.data_ptr [INFO] [stderr] 56 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/anims/mod.rs:84:63 [INFO] [stderr] | [INFO] [stderr] 84 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| AnimDumpErr::Tlb(info.data_ptr, ram))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/anims/mod.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.data_ptr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/anims/mod.rs:109:63 [INFO] [stderr] | [INFO] [stderr] 109 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| AnimDumpErr::Tlb(info.data_ptr, ram))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/anims/mod.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.data_ptr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/anims/mod.rs:134:63 [INFO] [stderr] | [INFO] [stderr] 134 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| AnimDumpErr::Tlb(info.data_ptr, ram))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/anims/mod.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | let data_offset = (info.data_ptr as u64).checked_sub(ram).ok_or(AnimDumpErr::Tlb(info.data_ptr, ram))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.data_ptr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.59s [INFO] running `"docker" "inspect" "f685d83d2b0a85bff32bdf7042659a6a4e8f3b85277d26c6623e2187ec878031"` [INFO] running `"docker" "rm" "-f" "f685d83d2b0a85bff32bdf7042659a6a4e8f3b85277d26c6623e2187ec878031"` [INFO] [stdout] f685d83d2b0a85bff32bdf7042659a6a4e8f3b85277d26c6623e2187ec878031