[INFO] updating cached repository teddywing/mutt-alias-auto-add [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/teddywing/mutt-alias-auto-add [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/teddywing/mutt-alias-auto-add" "work/ex/clippy-test-run/sources/stable/gh/teddywing/mutt-alias-auto-add"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/teddywing/mutt-alias-auto-add'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/teddywing/mutt-alias-auto-add" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teddywing/mutt-alias-auto-add"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teddywing/mutt-alias-auto-add'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3193e4dd20ea0c01f1ab8195548280914d84c4bd [INFO] sha for GitHub repo teddywing/mutt-alias-auto-add: 3193e4dd20ea0c01f1ab8195548280914d84c4bd [INFO] validating manifest of teddywing/mutt-alias-auto-add on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of teddywing/mutt-alias-auto-add on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing teddywing/mutt-alias-auto-add [INFO] finished frobbing teddywing/mutt-alias-auto-add [INFO] frobbed toml for teddywing/mutt-alias-auto-add written to work/ex/clippy-test-run/sources/stable/gh/teddywing/mutt-alias-auto-add/Cargo.toml [INFO] started frobbing teddywing/mutt-alias-auto-add [INFO] finished frobbing teddywing/mutt-alias-auto-add [INFO] frobbed toml for teddywing/mutt-alias-auto-add written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teddywing/mutt-alias-auto-add/Cargo.toml [INFO] crate teddywing/mutt-alias-auto-add has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting teddywing/mutt-alias-auto-add against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/teddywing/mutt-alias-auto-add:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a648a4b9d1978f6a2955cc1be171b3b9ac616ef1e1e4ce7cf1f5031f2950e9a2 [INFO] running `"docker" "start" "-a" "a648a4b9d1978f6a2955cc1be171b3b9ac616ef1e1e4ce7cf1f5031f2950e9a2"` [INFO] [stderr] Checking alias-auto-add v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | Alias { alias: alias, name: name, email: email } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | Alias { alias: alias, name: name, email: email } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:42:43 [INFO] [stderr] | [INFO] [stderr] 42 | Alias { alias: alias, name: name, email: email } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | Alias { alias: alias, name: name, email: email } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | Alias { alias: alias, name: name, email: email } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:42:43 [INFO] [stderr] | [INFO] [stderr] 42 | Alias { alias: alias, name: name, email: email } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests.rs:93:42 [INFO] [stderr] | [INFO] [stderr] 93 | const UPDATE_ALIAS_ID_ALIAS_IDENTIFIER: &'static str = "hooves-derpy"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/alias.rs:99:22 [INFO] [stderr] | [INFO] [stderr] 99 | s.iter().map(|c| c.clone() as char).collect() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/alias.rs:99:22 [INFO] [stderr] | [INFO] [stderr] 99 | s.iter().map(|c| c.clone() as char).collect() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "a648a4b9d1978f6a2955cc1be171b3b9ac616ef1e1e4ce7cf1f5031f2950e9a2"` [INFO] running `"docker" "rm" "-f" "a648a4b9d1978f6a2955cc1be171b3b9ac616ef1e1e4ce7cf1f5031f2950e9a2"` [INFO] [stdout] a648a4b9d1978f6a2955cc1be171b3b9ac616ef1e1e4ce7cf1f5031f2950e9a2