[INFO] updating cached repository team-rust/mailbox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/team-rust/mailbox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/team-rust/mailbox" "work/ex/clippy-test-run/sources/stable/gh/team-rust/mailbox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/team-rust/mailbox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/team-rust/mailbox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/team-rust/mailbox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/team-rust/mailbox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1080ebc5bb1e9af9033169e806b52b05718376b7 [INFO] sha for GitHub repo team-rust/mailbox: 1080ebc5bb1e9af9033169e806b52b05718376b7 [INFO] validating manifest of team-rust/mailbox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of team-rust/mailbox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing team-rust/mailbox [INFO] finished frobbing team-rust/mailbox [INFO] frobbed toml for team-rust/mailbox written to work/ex/clippy-test-run/sources/stable/gh/team-rust/mailbox/Cargo.toml [INFO] started frobbing team-rust/mailbox [INFO] finished frobbing team-rust/mailbox [INFO] frobbed toml for team-rust/mailbox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/team-rust/mailbox/Cargo.toml [INFO] crate team-rust/mailbox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting team-rust/mailbox against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/team-rust/mailbox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6414482c3821c6a81a8d79bd3637e6a25957fe46102121ccc007ac2fedbc6b8c [INFO] running `"docker" "start" "-a" "6414482c3821c6a81a8d79bd3637e6a25957fe46102121ccc007ac2fedbc6b8c"` [INFO] [stderr] Checking mailbox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mailbox.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | Message{sender: sender, receiver: receiver, body: body} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mailbox.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | Message{sender: sender, receiver: receiver, body: body} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mailbox.rs:10:53 [INFO] [stderr] | [INFO] [stderr] 10 | Message{sender: sender, receiver: receiver, body: body} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/syncedmailbox.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | SyncedMailbox{inner: inner} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mailbox.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | Message{sender: sender, receiver: receiver, body: body} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mailbox.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | Message{sender: sender, receiver: receiver, body: body} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mailbox.rs:10:53 [INFO] [stderr] | [INFO] [stderr] 10 | Message{sender: sender, receiver: receiver, body: body} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/syncedmailbox.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | SyncedMailbox{inner: inner} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/mailbox.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn new(sender: String, receiver: String, body: String) -> Message { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/mailbox.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new() -> Mailbox { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `store` [INFO] [stderr] --> src/mailbox.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn store(&mut self, m: Message) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fetch` [INFO] [stderr] --> src/mailbox.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn fetch(&mut self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SyncedMailbox` [INFO] [stderr] --> src/syncedmailbox.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | struct SyncedMailbox { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/syncedmailbox.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | fn new() -> SyncedMailbox { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `store` [INFO] [stderr] --> src/syncedmailbox.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | fn store(&self, m: mailbox::Message) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fetch` [INFO] [stderr] --> src/syncedmailbox.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | fn fetch(&self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/syncedmailbox.rs:16:35 [INFO] [stderr] | [INFO] [stderr] 16 | Ok(mut mailbox) => Ok(mailbox.store(m)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 16 | Ok(mut mailbox) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/syncedmailbox.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | mailbox.fetch().ok_or("hans".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "hans".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/syncedmailbox.rs:16:35 [INFO] [stderr] | [INFO] [stderr] 16 | Ok(mut mailbox) => Ok(mailbox.store(m)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 16 | Ok(mut mailbox) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/syncedmailbox.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | mailbox.fetch().ok_or("hans".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "hans".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "6414482c3821c6a81a8d79bd3637e6a25957fe46102121ccc007ac2fedbc6b8c"` [INFO] running `"docker" "rm" "-f" "6414482c3821c6a81a8d79bd3637e6a25957fe46102121ccc007ac2fedbc6b8c"` [INFO] [stdout] 6414482c3821c6a81a8d79bd3637e6a25957fe46102121ccc007ac2fedbc6b8c