[INFO] updating cached repository te0ys/rusty-enigma
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/te0ys/rusty-enigma
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/te0ys/rusty-enigma" "work/ex/clippy-test-run/sources/stable/gh/te0ys/rusty-enigma"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/te0ys/rusty-enigma'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/te0ys/rusty-enigma" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/te0ys/rusty-enigma"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/te0ys/rusty-enigma'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] af9f2f6a2ccd258076580065585341738fdcca22
[INFO] sha for GitHub repo te0ys/rusty-enigma: af9f2f6a2ccd258076580065585341738fdcca22
[INFO] validating manifest of te0ys/rusty-enigma on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of te0ys/rusty-enigma on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing te0ys/rusty-enigma
[INFO] finished frobbing te0ys/rusty-enigma
[INFO] frobbed toml for te0ys/rusty-enigma written to work/ex/clippy-test-run/sources/stable/gh/te0ys/rusty-enigma/Cargo.toml
[INFO] started frobbing te0ys/rusty-enigma
[INFO] finished frobbing te0ys/rusty-enigma
[INFO] frobbed toml for te0ys/rusty-enigma written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/te0ys/rusty-enigma/Cargo.toml
[INFO] crate te0ys/rusty-enigma has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting te0ys/rusty-enigma against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/te0ys/rusty-enigma:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 62a90566c3603e2ec4483ae279bfb1a14dc417b08008e8d1e47cc015d4bdc706
[INFO] running `"docker" "start" "-a" "62a90566c3603e2ec4483ae279bfb1a14dc417b08008e8d1e47cc015d4bdc706"`
[INFO] [stderr]     Checking enigma_simulator v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rotor.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             leftalph: leftalph,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `leftalph`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rotor.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             notch: notch,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `notch`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             order: order,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `order`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             rotations: rotations,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rotations`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             indicators: indicators,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indicators`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             plugboard: plugboard,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plugboard`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             reflector: reflector,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflector`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rotor.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             leftalph: leftalph,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `leftalph`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rotor.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             notch: notch,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `notch`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             order: order,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `order`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             rotations: rotations,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rotations`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             indicators: indicators,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indicators`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             plugboard: plugboard,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plugboard`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logic.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             reflector: reflector,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflector`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/logic.rs:135:18
[INFO] [stderr]     |
[INFO] [stderr] 135 |               else if u >= 97 {
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 136 | |                 if u <= 122{
[INFO] [stderr] 137 | |                     output.push((u -32) as char );
[INFO] [stderr] 138 | |                 }
[INFO] [stderr] 139 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 135 |             else if u >= 97 && u <= 122 {
[INFO] [stderr] 136 |     output.push((u -32) as char );
[INFO] [stderr] 137 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/logic.rs:135:18
[INFO] [stderr]     |
[INFO] [stderr] 135 |               else if u >= 97 {
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 136 | |                 if u <= 122{
[INFO] [stderr] 137 | |                     output.push((u -32) as char );
[INFO] [stderr] 138 | |                 }
[INFO] [stderr] 139 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 135 |             else if u >= 97 && u <= 122 {
[INFO] [stderr] 136 |     output.push((u -32) as char );
[INFO] [stderr] 137 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/setup.rs:36:11
[INFO] [stderr]    |
[INFO] [stderr] 36 |     match env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/setup.rs:36:11
[INFO] [stderr]    |
[INFO] [stderr] 36 |     match env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `config_dir`
[INFO] [stderr]   --> src/gen.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn rotorgen(config_dir:String) ->String{
[INFO] [stderr]    |                 ^^^^^^^^^^ help: consider using `_config_dir` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `config_dir`
[INFO] [stderr]   --> src/gen.rs:33:15
[INFO] [stderr]    |
[INFO] [stderr] 33 | pub fn keygen(config_dir: String) -> String {
[INFO] [stderr]    |               ^^^^^^^^^^ help: consider using `_config_dir` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `config_dir`
[INFO] [stderr]   --> src/gen.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn rotorgen(config_dir:String) ->String{
[INFO] [stderr]    |                 ^^^^^^^^^^ help: consider using `_config_dir` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `config_dir`
[INFO] [stderr]   --> src/gen.rs:33:15
[INFO] [stderr]    |
[INFO] [stderr] 33 | pub fn keygen(config_dir: String) -> String {
[INFO] [stderr]    |               ^^^^^^^^^^ help: consider using `_config_dir` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `as_string`
[INFO] [stderr]   --> src/rotor.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     pub fn as_string(&self) -> String{
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `as_string`
[INFO] [stderr]   --> src/rotor.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     pub fn as_string(&self) -> String{
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/setup.rs:15:24
[INFO] [stderr]    |
[INFO] [stderr] 15 |         let mut file = File::create(&config_dir).ok().expect("failed to open dailies file");
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/setup.rs:15:24
[INFO] [stderr]    |
[INFO] [stderr] 15 |         let mut file = File::create(&config_dir).ok().expect("failed to open dailies file");
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/setup.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |         file.write_all(key.as_ref()).ok().expect("failed to write dailies file");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/setup.rs:23:24
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let mut file = File::create(&rotor_dir.clone()).ok().expect("failed to open dailies file");
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/setup.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         file.write_all(rotor.as_ref()).ok().expect("failed to write dailies file");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `raw`.
[INFO] [stderr]   --> src/setup.rs:75:14
[INFO] [stderr]    |
[INFO] [stderr] 75 |     for i in 0 .. raw.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 75 |     for <item> in &raw {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `alphraw`.
[INFO] [stderr]   --> src/rotor.rs:20:18
[INFO] [stderr]    |
[INFO] [stderr] 20 |         for i in ring as usize .. alphraw.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 20 |         for <item> in alphraw.iter().skip(ring as usize) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `alphraw`.
[INFO] [stderr]   --> src/rotor.rs:23:18
[INFO] [stderr]    |
[INFO] [stderr] 23 |         for i in 0 .. ring as usize {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 23 |         for <item> in alphraw.iter().take(ring as usize) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/rotor.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 1..26 {
[INFO] [stderr]    |                  ^^^^^ help: try replacing the loop by: `self.leftalph[1..26].clone_from_slice(&x[0..(26 - 1)])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/setup.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |         file.write_all(key.as_ref()).ok().expect("failed to write dailies file");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/gen.rs:24:11
[INFO] [stderr]    |
[INFO] [stderr] 24 |     while basealph.len() > 0 {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!basealph.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/setup.rs:23:24
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let mut file = File::create(&rotor_dir.clone()).ok().expect("failed to open dailies file");
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/setup.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         file.write_all(rotor.as_ref()).ok().expect("failed to write dailies file");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `raw`.
[INFO] [stderr]   --> src/setup.rs:75:14
[INFO] [stderr]    |
[INFO] [stderr] 75 |     for i in 0 .. raw.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/logic.rs:113:16
[INFO] [stderr]     |
[INFO] [stderr] 113 |             if x == false {
[INFO] [stderr]     |                ^^^^^^^^^^ help: try simplifying it as shown: `!x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 75 |     for <item> in &raw {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `alphraw`.
[INFO] [stderr]   --> src/rotor.rs:20:18
[INFO] [stderr]    |
[INFO] [stderr] 20 |         for i in ring as usize .. alphraw.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 20 |         for <item> in alphraw.iter().skip(ring as usize) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `alphraw`.
[INFO] [stderr]   --> src/rotor.rs:23:18
[INFO] [stderr]    |
[INFO] [stderr] 23 |         for i in 0 .. ring as usize {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 23 |         for <item> in alphraw.iter().take(ring as usize) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/rotor.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 1..26 {
[INFO] [stderr]    |                  ^^^^^ help: try replacing the loop by: `self.leftalph[1..26].clone_from_slice(&x[0..(26 - 1)])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/gen.rs:24:11
[INFO] [stderr]    |
[INFO] [stderr] 24 |     while basealph.len() > 0 {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!basealph.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/logic.rs:113:16
[INFO] [stderr]     |
[INFO] [stderr] 113 |             if x == false {
[INFO] [stderr]     |                ^^^^^^^^^^ help: try simplifying it as shown: `!x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.39s
[INFO] running `"docker" "inspect" "62a90566c3603e2ec4483ae279bfb1a14dc417b08008e8d1e47cc015d4bdc706"`
[INFO] running `"docker" "rm" "-f" "62a90566c3603e2ec4483ae279bfb1a14dc417b08008e8d1e47cc015d4bdc706"`
[INFO] [stdout] 62a90566c3603e2ec4483ae279bfb1a14dc417b08008e8d1e47cc015d4bdc706