[INFO] updating cached repository tdgroot/timpack-cli
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tdgroot/timpack-cli
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tdgroot/timpack-cli" "work/ex/clippy-test-run/sources/stable/gh/tdgroot/timpack-cli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tdgroot/timpack-cli'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tdgroot/timpack-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tdgroot/timpack-cli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tdgroot/timpack-cli'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 534accfc49a33da97861d8b9da00c62be6082b26
[INFO] sha for GitHub repo tdgroot/timpack-cli: 534accfc49a33da97861d8b9da00c62be6082b26
[INFO] validating manifest of tdgroot/timpack-cli on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tdgroot/timpack-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tdgroot/timpack-cli
[INFO] finished frobbing tdgroot/timpack-cli
[INFO] frobbed toml for tdgroot/timpack-cli written to work/ex/clippy-test-run/sources/stable/gh/tdgroot/timpack-cli/Cargo.toml
[INFO] started frobbing tdgroot/timpack-cli
[INFO] finished frobbing tdgroot/timpack-cli
[INFO] frobbed toml for tdgroot/timpack-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tdgroot/timpack-cli/Cargo.toml
[INFO] crate tdgroot/timpack-cli has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tdgroot/timpack-cli against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tdgroot/timpack-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5382ee9668cf259df0d65dcb9b2ff46aadead9c30b91590bbd69419bd893b1d7
[INFO] running `"docker" "start" "-a" "5382ee9668cf259df0d65dcb9b2ff46aadead9c30b91590bbd69419bd893b1d7"`
[INFO] [stderr]     Checking timpack-cli v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:95:5
[INFO] [stderr]    |
[INFO] [stderr] 95 |     return value.to_owned();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value.to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 |     return String::from_utf8(output.stdout).unwrap().trim().to_string();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(output.stdout).unwrap().trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:95:5
[INFO] [stderr]    |
[INFO] [stderr] 95 |     return value.to_owned();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value.to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 |     return String::from_utf8(output.stdout).unwrap().trim().to_string();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(output.stdout).unwrap().trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:43:18
[INFO] [stderr]    |
[INFO] [stderr] 43 |         binary = aliases.get(&binary).unwrap().to_string();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&aliases[&binary]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `input_arguments`.
[INFO] [stderr]   --> src/main.rs:64:14
[INFO] [stderr]    |
[INFO] [stderr] 64 |     for i in command_arguments_index..input_arguments.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 64 |     for <item> in input_arguments.iter().skip(command_arguments_index) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]   --> src/main.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         &command_arguments.push(input_arguments[i].to_owned());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_arguments.push(input_arguments[i].to_owned());`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:84:48
[INFO] [stderr]    |
[INFO] [stderr] 84 | fn fail_if_no_input_arguments(input_arguments: &Vec<String>) {
[INFO] [stderr]    |                                                ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:43:18
[INFO] [stderr]    |
[INFO] [stderr] 43 |         binary = aliases.get(&binary).unwrap().to_string();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&aliases[&binary]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `input_arguments`.
[INFO] [stderr]   --> src/main.rs:64:14
[INFO] [stderr]    |
[INFO] [stderr] 64 |     for i in command_arguments_index..input_arguments.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 64 |     for <item> in input_arguments.iter().skip(command_arguments_index) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]   --> src/main.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         &command_arguments.push(input_arguments[i].to_owned());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_arguments.push(input_arguments[i].to_owned());`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:84:48
[INFO] [stderr]    |
[INFO] [stderr] 84 | fn fail_if_no_input_arguments(input_arguments: &Vec<String>) {
[INFO] [stderr]    |                                                ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.90s
[INFO] running `"docker" "inspect" "5382ee9668cf259df0d65dcb9b2ff46aadead9c30b91590bbd69419bd893b1d7"`
[INFO] running `"docker" "rm" "-f" "5382ee9668cf259df0d65dcb9b2ff46aadead9c30b91590bbd69419bd893b1d7"`
[INFO] [stdout] 5382ee9668cf259df0d65dcb9b2ff46aadead9c30b91590bbd69419bd893b1d7