[INFO] updating cached repository tdejager/rroguelib [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tdejager/rroguelib [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tdejager/rroguelib" "work/ex/clippy-test-run/sources/stable/gh/tdejager/rroguelib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tdejager/rroguelib'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tdejager/rroguelib" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tdejager/rroguelib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tdejager/rroguelib'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4da5f68a93e87c555cc52192f437d41ad6a0c8fe [INFO] sha for GitHub repo tdejager/rroguelib: 4da5f68a93e87c555cc52192f437d41ad6a0c8fe [INFO] validating manifest of tdejager/rroguelib on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tdejager/rroguelib on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tdejager/rroguelib [INFO] finished frobbing tdejager/rroguelib [INFO] frobbed toml for tdejager/rroguelib written to work/ex/clippy-test-run/sources/stable/gh/tdejager/rroguelib/Cargo.toml [INFO] started frobbing tdejager/rroguelib [INFO] finished frobbing tdejager/rroguelib [INFO] frobbed toml for tdejager/rroguelib written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tdejager/rroguelib/Cargo.toml [INFO] crate tdejager/rroguelib has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tdejager/rroguelib against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tdejager/rroguelib:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0d8fe4ee867f343dcd72daa9ab6b1ea4d7d4a29206d5e6c6a171b2bc8cf68de [INFO] running `"docker" "start" "-a" "e0d8fe4ee867f343dcd72daa9ab6b1ea4d7d4a29206d5e6c6a171b2bc8cf68de"` [INFO] [stderr] Checking byteorder v1.2.4 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Checking smallvec v0.6.4 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking backtrace-sys v0.1.23 [INFO] [stderr] Checking ordered-float v1.0.1 [INFO] [stderr] Checking approx v0.3.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking wayland-sys v0.20.11 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking rustc-hash v1.0.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking wayland-commons v0.20.11 [INFO] [stderr] Checking wayland-client v0.20.11 [INFO] [stderr] Checking rusttype v0.7.2 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking wayland-protocols v0.20.11 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Checking roguelib v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `rusttype::gpu_cache::CacheBuilder` [INFO] [stderr] --> src/fonts.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use rusttype::gpu_cache::CacheBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PositionedGlyph`, `Rect`, `Scale`, `point`, `vector` [INFO] [stderr] --> src/fonts.rs:2:16 [INFO] [stderr] | [INFO] [stderr] 2 | use rusttype::{point, vector, Font, PositionedGlyph, Rect, Scale}; [INFO] [stderr] | ^^^^^ ^^^^^^ ^^^^^^^^^^^^^^^ ^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `load_font` [INFO] [stderr] --> src/fonts.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | fn load_font(font_data: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/fonts.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Font::from_bytes(font_data.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused import: `rusttype::gpu_cache::CacheBuilder` [INFO] [stderr] --> src/fonts.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use rusttype::gpu_cache::CacheBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PositionedGlyph`, `Rect`, `Scale`, `point`, `vector` [INFO] [stderr] --> src/fonts.rs:2:16 [INFO] [stderr] | [INFO] [stderr] 2 | use rusttype::{point, vector, Font, PositionedGlyph, Rect, Scale}; [INFO] [stderr] | ^^^^^ ^^^^^^ ^^^^^^^^^^^^^^^ ^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `load_font` [INFO] [stderr] --> src/fonts.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | fn load_font(font_data: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/fonts.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Font::from_bytes(font_data.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused import: `rusttype::gpu_cache::CacheBuilder` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use rusttype::gpu_cache::CacheBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | let vertex_buffer = { [INFO] [stderr] | _________________________^ [INFO] [stderr] 102 | | let colour = [1.0, 1.0, 1.0, 1.0]; [INFO] [stderr] 103 | | let (screen_width, screen_height) = { [INFO] [stderr] 104 | | let (w, h) = display.get_framebuffer_dimensions(); [INFO] [stderr] ... | [INFO] [stderr] 161 | | glium::VertexBuffer::new(display, &vertices).expect("Could not create text vertex buffer") [INFO] [stderr] 162 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | return (vb, ib); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(vb, ib)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:298:27 [INFO] [stderr] | [INFO] [stderr] 298 | max_font_height = (v_metrics.ascent - v_metrics.descent); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `rusttype::gpu_cache::CacheBuilder` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use rusttype::gpu_cache::CacheBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | let vertex_buffer = { [INFO] [stderr] | _________________________^ [INFO] [stderr] 102 | | let colour = [1.0, 1.0, 1.0, 1.0]; [INFO] [stderr] 103 | | let (screen_width, screen_height) = { [INFO] [stderr] 104 | | let (w, h) = display.get_framebuffer_dimensions(); [INFO] [stderr] ... | [INFO] [stderr] 161 | | glium::VertexBuffer::new(display, &vertices).expect("Could not create text vertex buffer") [INFO] [stderr] 162 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | return (vb, ib); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(vb, ib)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:298:27 [INFO] [stderr] | [INFO] [stderr] 298 | max_font_height = (v_metrics.ascent - v_metrics.descent); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bounding_box` [INFO] [stderr] --> src/main.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | let bounding_box = glyph.clone().positioned(point(0.0, 0.0)).pixel_bounding_box().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_bounding_box` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | let program = program!(display, [INFO] [stderr] | ___________________^ [INFO] [stderr] 35 | | 140 => { [INFO] [stderr] 36 | | vertex: " [INFO] [stderr] 37 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | let program = program!( [INFO] [stderr] | ___________________^ [INFO] [stderr] 64 | | display, [INFO] [stderr] 65 | | 140 => { [INFO] [stderr] 66 | | vertex: " [INFO] [stderr] ... | [INFO] [stderr] 93 | | " [INFO] [stderr] 94 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | fn create_text_vb(display: &glium::Display, glyphs: &Vec, cache: &Cache) -> glium::VertexBuffer [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[PositionedGlyph]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:384:26 [INFO] [stderr] | [INFO] [stderr] 384 | } => match keypress { [INFO] [stderr] | __________________________^ [INFO] [stderr] 385 | | VirtualKeyCode::Escape => finished = true, [INFO] [stderr] 386 | | _ => (), [INFO] [stderr] 387 | | }, [INFO] [stderr] | |_____________________^ help: try this: `if let VirtualKeyCode::Escape = keypress { finished = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bounding_box` [INFO] [stderr] --> src/main.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | let bounding_box = glyph.clone().positioned(point(0.0, 0.0)).pixel_bounding_box().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_bounding_box` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | let program = program!(display, [INFO] [stderr] | ___________________^ [INFO] [stderr] 35 | | 140 => { [INFO] [stderr] 36 | | vertex: " [INFO] [stderr] 37 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | let program = program!( [INFO] [stderr] | ___________________^ [INFO] [stderr] 64 | | display, [INFO] [stderr] 65 | | 140 => { [INFO] [stderr] 66 | | vertex: " [INFO] [stderr] ... | [INFO] [stderr] 93 | | " [INFO] [stderr] 94 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | fn create_text_vb(display: &glium::Display, glyphs: &Vec, cache: &Cache) -> glium::VertexBuffer [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[PositionedGlyph]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:384:26 [INFO] [stderr] | [INFO] [stderr] 384 | } => match keypress { [INFO] [stderr] | __________________________^ [INFO] [stderr] 385 | | VirtualKeyCode::Escape => finished = true, [INFO] [stderr] 386 | | _ => (), [INFO] [stderr] 387 | | }, [INFO] [stderr] | |_____________________^ help: try this: `if let VirtualKeyCode::Escape = keypress { finished = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 59.41s [INFO] running `"docker" "inspect" "e0d8fe4ee867f343dcd72daa9ab6b1ea4d7d4a29206d5e6c6a171b2bc8cf68de"` [INFO] running `"docker" "rm" "-f" "e0d8fe4ee867f343dcd72daa9ab6b1ea4d7d4a29206d5e6c6a171b2bc8cf68de"` [INFO] [stdout] e0d8fe4ee867f343dcd72daa9ab6b1ea4d7d4a29206d5e6c6a171b2bc8cf68de