[INFO] updating cached repository tdbgamer/RustBoi [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tdbgamer/RustBoi [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tdbgamer/RustBoi" "work/ex/clippy-test-run/sources/stable/gh/tdbgamer/RustBoi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tdbgamer/RustBoi'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tdbgamer/RustBoi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tdbgamer/RustBoi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tdbgamer/RustBoi'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 200e862e693d7c3d101319bd90e76b77df443ae3 [INFO] sha for GitHub repo tdbgamer/RustBoi: 200e862e693d7c3d101319bd90e76b77df443ae3 [INFO] validating manifest of tdbgamer/RustBoi on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tdbgamer/RustBoi on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tdbgamer/RustBoi [INFO] finished frobbing tdbgamer/RustBoi [INFO] frobbed toml for tdbgamer/RustBoi written to work/ex/clippy-test-run/sources/stable/gh/tdbgamer/RustBoi/Cargo.toml [INFO] started frobbing tdbgamer/RustBoi [INFO] finished frobbing tdbgamer/RustBoi [INFO] frobbed toml for tdbgamer/RustBoi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tdbgamer/RustBoi/Cargo.toml [INFO] crate tdbgamer/RustBoi has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tdbgamer/RustBoi against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tdbgamer/RustBoi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 446841512e218d1b8f4c3d0e37377e336e9065f15c125c41a928dbdacdc3de31 [INFO] running `"docker" "start" "-a" "446841512e218d1b8f4c3d0e37377e336e9065f15c125c41a928dbdacdc3de31"` [INFO] [stderr] Checking rust_boi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | return ((&mut self.rom), addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((&mut self.rom), addr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return ((&mut self.video_ram), addr - 0x8000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((&mut self.video_ram), addr - 0x8000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | return ((&mut self.mapped_io), addr - 0xff00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((&mut self.mapped_io), addr - 0xff00)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | return ((&mut self.zero_page), addr - 0x0FF80); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((&mut self.zero_page), addr - 0x0FF80)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return memory_space[addr as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory_space[addr as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return memory_space[addr as usize] = value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory_space[addr as usize] = value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / return ((self.read_u8(addr+1) as u16) << 8) | [INFO] [stderr] 66 | | ((self.read_u8(addr) as u16)); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | ((self.read_u8(addr+1) as u16) << 8) | [INFO] [stderr] 66 | ((self.read_u8(addr) as u16)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/gameboy/memory.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | ((self.read_u8(addr) as u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/cpu.rs:361:9 [INFO] [stderr] | [INFO] [stderr] 361 | return memory.read_u8(current_pc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory.read_u8(current_pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/cpu.rs:367:9 [INFO] [stderr] | [INFO] [stderr] 367 | return memory.read_u8(current_pc) as i8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory.read_u8(current_pc) as i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/cpu.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | return memory.read_u16(current_pc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory.read_u16(current_pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/cpu.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | / return ((self.hi as u16) << 8) | [INFO] [stderr] 399 | | ((self.lo as u16) & 0x00ff); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 398 | ((self.hi as u16) << 8) | [INFO] [stderr] 399 | ((self.lo as u16) & 0x00ff) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/gameboy/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod gameboy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | return ((&mut self.rom), addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((&mut self.rom), addr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return ((&mut self.video_ram), addr - 0x8000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((&mut self.video_ram), addr - 0x8000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | return ((&mut self.mapped_io), addr - 0xff00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((&mut self.mapped_io), addr - 0xff00)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | return ((&mut self.zero_page), addr - 0x0FF80); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((&mut self.zero_page), addr - 0x0FF80)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return memory_space[addr as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory_space[addr as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return memory_space[addr as usize] = value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory_space[addr as usize] = value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/memory.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / return ((self.read_u8(addr+1) as u16) << 8) | [INFO] [stderr] 66 | | ((self.read_u8(addr) as u16)); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | ((self.read_u8(addr+1) as u16) << 8) | [INFO] [stderr] 66 | ((self.read_u8(addr) as u16)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/gameboy/memory.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | ((self.read_u8(addr) as u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/cpu.rs:361:9 [INFO] [stderr] | [INFO] [stderr] 361 | return memory.read_u8(current_pc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory.read_u8(current_pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/cpu.rs:367:9 [INFO] [stderr] | [INFO] [stderr] 367 | return memory.read_u8(current_pc) as i8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory.read_u8(current_pc) as i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/cpu.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | return memory.read_u16(current_pc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memory.read_u16(current_pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboy/cpu.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | / return ((self.hi as u16) << 8) | [INFO] [stderr] 399 | | ((self.lo as u16) & 0x00ff); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 398 | ((self.hi as u16) << 8) | [INFO] [stderr] 399 | ((self.lo as u16) & 0x00ff) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/gameboy/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod gameboy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/gameboy/memory.rs:30:61 [INFO] [stderr] | [INFO] [stderr] 30 | fn get_memory_space_with_addr(&mut self, addr: u16) -> (&mut Box<[u8]>, u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&mut [u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/memory.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | return ((self.read_u8(addr+1) as u16) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8(addr+1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/memory.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | ((self.read_u8(addr) as u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:87:45 [INFO] [stderr] | [INFO] [stderr] 87 | self.pc = (self.pc as i16 + offset as i16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:92:45 [INFO] [stderr] | [INFO] [stderr] 92 | self.pc = (self.pc as i16 + offset as i16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:110:37 [INFO] [stderr] | [INFO] [stderr] 110 | let addr = 0xff00 + (self.read_u8_at_pc(memory) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8_at_pc(memory))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:114:37 [INFO] [stderr] | [INFO] [stderr] 114 | let addr = 0xff00 + (self.read_u8_at_pc(memory) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8_at_pc(memory))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:123:48 [INFO] [stderr] | [INFO] [stderr] 123 | 0xe2 => { memory.write_u8(0xff00 + (self.bc.lo as u16), self.af.hi); } // LD (C), A [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bc.lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:345:10 [INFO] [stderr] | [INFO] [stderr] 345 | ((higher as u16) << 8) | ((lower as u16) & 0x00ff) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(higher)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:345:35 [INFO] [stderr] | [INFO] [stderr] 345 | ((higher as u16) << 8) | ((lower as u16) & 0x00ff) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:398:17 [INFO] [stderr] | [INFO] [stderr] 398 | return ((self.hi as u16) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:399:17 [INFO] [stderr] | [INFO] [stderr] 399 | ((self.lo as u16) & 0x00ff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/gameboy/memory.rs:30:61 [INFO] [stderr] | [INFO] [stderr] 30 | fn get_memory_space_with_addr(&mut self, addr: u16) -> (&mut Box<[u8]>, u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&mut [u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/memory.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | return ((self.read_u8(addr+1) as u16) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8(addr+1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/memory.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | ((self.read_u8(addr) as u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:87:45 [INFO] [stderr] | [INFO] [stderr] 87 | self.pc = (self.pc as i16 + offset as i16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:92:45 [INFO] [stderr] | [INFO] [stderr] 92 | self.pc = (self.pc as i16 + offset as i16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:110:37 [INFO] [stderr] | [INFO] [stderr] 110 | let addr = 0xff00 + (self.read_u8_at_pc(memory) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8_at_pc(memory))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:114:37 [INFO] [stderr] | [INFO] [stderr] 114 | let addr = 0xff00 + (self.read_u8_at_pc(memory) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8_at_pc(memory))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:123:48 [INFO] [stderr] | [INFO] [stderr] 123 | 0xe2 => { memory.write_u8(0xff00 + (self.bc.lo as u16), self.af.hi); } // LD (C), A [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bc.lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:345:10 [INFO] [stderr] | [INFO] [stderr] 345 | ((higher as u16) << 8) | ((lower as u16) & 0x00ff) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(higher)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:345:35 [INFO] [stderr] | [INFO] [stderr] 345 | ((higher as u16) << 8) | ((lower as u16) & 0x00ff) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:398:17 [INFO] [stderr] | [INFO] [stderr] 398 | return ((self.hi as u16) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/cpu.rs:399:17 [INFO] [stderr] | [INFO] [stderr] 399 | ((self.lo as u16) & 0x00ff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "446841512e218d1b8f4c3d0e37377e336e9065f15c125c41a928dbdacdc3de31"` [INFO] running `"docker" "rm" "-f" "446841512e218d1b8f4c3d0e37377e336e9065f15c125c41a928dbdacdc3de31"` [INFO] [stdout] 446841512e218d1b8f4c3d0e37377e336e9065f15c125c41a928dbdacdc3de31