[INFO] updating cached repository tcsc/asyncho [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tcsc/asyncho [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tcsc/asyncho" "work/ex/clippy-test-run/sources/stable/gh/tcsc/asyncho"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tcsc/asyncho'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tcsc/asyncho" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tcsc/asyncho"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tcsc/asyncho'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ea65583019f2c1aa8de01878435db2f59ae84a5f [INFO] sha for GitHub repo tcsc/asyncho: ea65583019f2c1aa8de01878435db2f59ae84a5f [INFO] validating manifest of tcsc/asyncho on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tcsc/asyncho on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tcsc/asyncho [INFO] finished frobbing tcsc/asyncho [INFO] frobbed toml for tcsc/asyncho written to work/ex/clippy-test-run/sources/stable/gh/tcsc/asyncho/Cargo.toml [INFO] started frobbing tcsc/asyncho [INFO] finished frobbing tcsc/asyncho [INFO] frobbed toml for tcsc/asyncho written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tcsc/asyncho/Cargo.toml [INFO] crate tcsc/asyncho has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tcsc/asyncho against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tcsc/asyncho:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ee4ed25eaf170d084f45344bb4a76f3467a9e2cec7a0eab055d726c1181c20d4 [INFO] running `"docker" "start" "-a" "ee4ed25eaf170d084f45344bb4a76f3467a9e2cec7a0eab055d726c1181c20d4"` [INFO] [stderr] Checking log v0.3.7 [INFO] [stderr] Checking regex-syntax v0.4.0 [INFO] [stderr] Checking futures v0.1.13 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking net2 v0.2.27 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking bytes v0.4.2 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking mio v0.6.6 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking tokio-io v0.1.1 [INFO] [stderr] Checking env_logger v0.4.2 [INFO] [stderr] Checking tokio-core v0.1.6 [INFO] [stderr] Checking asyncho v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:97:31 [INFO] [stderr] | [INFO] [stderr] 97 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | remote_addr: remote_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remote_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:188:31 [INFO] [stderr] | [INFO] [stderr] 188 | conn_id: conn_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `conn_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:193:78 [INFO] [stderr] | [INFO] [stderr] 193 | .and_then(move |_| send_msg(&tx_conn_lost, Msg::ConnectionLost { conn_id: conn_id })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `conn_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:228:27 [INFO] [stderr] | [INFO] [stderr] 228 | conn_id: conn_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `conn_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | new_tx: new_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `new_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:97:31 [INFO] [stderr] | [INFO] [stderr] 97 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | remote_addr: remote_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remote_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:188:31 [INFO] [stderr] | [INFO] [stderr] 188 | conn_id: conn_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `conn_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:193:78 [INFO] [stderr] | [INFO] [stderr] 193 | .and_then(move |_| send_msg(&tx_conn_lost, Msg::ConnectionLost { conn_id: conn_id })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `conn_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:228:27 [INFO] [stderr] | [INFO] [stderr] 228 | conn_id: conn_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `conn_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | new_tx: new_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `new_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/service.rs:238:19 [INFO] [stderr] | [INFO] [stderr] 238 | fn erase(_: T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/service.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/service.rs:238:19 [INFO] [stderr] | [INFO] [stderr] 238 | fn erase(_: T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/service.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/service.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if let Err(_) = msg_loop.run(event_handler) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 114 | | error!("Event loop returned error!") [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________- help: try this: `if msg_loop.run(event_handler).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/service.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | self.spawn_connection(conn).map_err(erase); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/service.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if let Err(_) = msg_loop.run(event_handler) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 114 | | error!("Event loop returned error!") [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________- help: try this: `if msg_loop.run(event_handler).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/service.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | self.spawn_connection(conn).map_err(erase); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.31s [INFO] running `"docker" "inspect" "ee4ed25eaf170d084f45344bb4a76f3467a9e2cec7a0eab055d726c1181c20d4"` [INFO] running `"docker" "rm" "-f" "ee4ed25eaf170d084f45344bb4a76f3467a9e2cec7a0eab055d726c1181c20d4"` [INFO] [stdout] ee4ed25eaf170d084f45344bb4a76f3467a9e2cec7a0eab055d726c1181c20d4