[INFO] updating cached repository tckastanek/kcat
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tckastanek/kcat
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tckastanek/kcat" "work/ex/clippy-test-run/sources/stable/gh/tckastanek/kcat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tckastanek/kcat'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tckastanek/kcat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tckastanek/kcat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tckastanek/kcat'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e62ce6a48842aa988881fba811faa2684f88bdcf
[INFO] sha for GitHub repo tckastanek/kcat: e62ce6a48842aa988881fba811faa2684f88bdcf
[INFO] validating manifest of tckastanek/kcat on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tckastanek/kcat on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tckastanek/kcat
[INFO] finished frobbing tckastanek/kcat
[INFO] frobbed toml for tckastanek/kcat written to work/ex/clippy-test-run/sources/stable/gh/tckastanek/kcat/Cargo.toml
[INFO] started frobbing tckastanek/kcat
[INFO] finished frobbing tckastanek/kcat
[INFO] frobbed toml for tckastanek/kcat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tckastanek/kcat/Cargo.toml
[INFO] crate tckastanek/kcat has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tckastanek/kcat against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tckastanek/kcat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9d996bc6bf6887a70d0d051d5f7d8d9e29ed3b631754fc84c0cd6db9a36fe7ef
[INFO] running `"docker" "start" "-a" "9d996bc6bf6887a70d0d051d5f7d8d9e29ed3b631754fc84c0cd6db9a36fe7ef"`
[INFO] [stderr]     Checking num-traits v0.2.2
[INFO] [stderr]    Compiling plist v0.2.4
[INFO] [stderr]     Checking same-file v1.0.2
[INFO] [stderr]     Checking serde v1.0.35
[INFO] [stderr]    Compiling cmake v0.1.29
[INFO] [stderr]    Compiling miniz-sys v0.1.10
[INFO] [stderr]     Checking atty v0.2.8
[INFO] [stderr]     Checking base64 v0.8.0
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking backtrace-sys v0.1.16
[INFO] [stderr]     Checking backtrace v0.3.6
[INFO] [stderr]     Checking walkdir v2.1.4
[INFO] [stderr]    Compiling onig_sys v68.0.0
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]     Checking flate2 v1.0.1
[INFO] [stderr]     Checking num-integer v0.1.36
[INFO] [stderr]     Checking num-iter v0.1.35
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking chrono v0.4.0
[INFO] [stderr]     Checking onig v3.2.0
[INFO] [stderr]     Checking bincode v0.9.2
[INFO] [stderr]     Checking serde_json v1.0.13
[INFO] [stderr]     Checking syntect v2.0.0
[INFO] [stderr]     Checking kcat v0.1.6 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]  --> src/printers.rs:9:36
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn print_fallback(path: &Path) -> () {
[INFO] [stderr]   |                                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/printers.rs:28:3
[INFO] [stderr]    |
[INFO] [stderr] 28 | ) -> () {
[INFO] [stderr]    |   ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/printers.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 | ) -> () {
[INFO] [stderr]    |   ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]  --> src/printers.rs:9:36
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn print_fallback(path: &Path) -> () {
[INFO] [stderr]   |                                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/printers.rs:28:3
[INFO] [stderr]    |
[INFO] [stderr] 28 | ) -> () {
[INFO] [stderr]    |   ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/printers.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 | ) -> () {
[INFO] [stderr]    |   ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/printers.rs:14:20
[INFO] [stderr]    |
[INFO] [stderr] 14 |               if let Err(_) = file.read_to_string(&mut s) {
[INFO] [stderr]    |  _____________-      ^^^^^^
[INFO] [stderr] 15 | |                 println!("ERROR: {}", KcatError::InvalidFile);
[INFO] [stderr] 16 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if file.read_to_string(&mut s).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]   --> src/printers.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 | /                 if let Some(string) = serde_json::to_string_pretty(final_value).ok() {
[INFO] [stderr] 71 | |                     for line in string.as_str().lines() {
[INFO] [stderr] 72 | |                         let ranges: Vec<(Style, &str)> = h.highlight(line);
[INFO] [stderr] 73 | |                         let escaped = as_24_bit_terminal_escaped(&ranges[..], true);
[INFO] [stderr] 74 | |                         println!("{}", escaped);
[INFO] [stderr] 75 | |                     }
[INFO] [stderr] 76 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]    = help: Consider matching on `Ok(string)` and removing the call to `ok` instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/printers.rs:98:16
[INFO] [stderr]    |
[INFO] [stderr] 98 |             if keys.len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/printers.rs:14:20
[INFO] [stderr]    |
[INFO] [stderr] 14 |               if let Err(_) = file.read_to_string(&mut s) {
[INFO] [stderr]    |  _____________-      ^^^^^^
[INFO] [stderr] 15 | |                 println!("ERROR: {}", KcatError::InvalidFile);
[INFO] [stderr] 16 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if file.read_to_string(&mut s).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]   --> src/printers.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 | /                 if let Some(string) = serde_json::to_string_pretty(final_value).ok() {
[INFO] [stderr] 71 | |                     for line in string.as_str().lines() {
[INFO] [stderr] 72 | |                         let ranges: Vec<(Style, &str)> = h.highlight(line);
[INFO] [stderr] 73 | |                         let escaped = as_24_bit_terminal_escaped(&ranges[..], true);
[INFO] [stderr] 74 | |                         println!("{}", escaped);
[INFO] [stderr] 75 | |                     }
[INFO] [stderr] 76 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]    = help: Consider matching on `Ok(string)` and removing the call to `ok` instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/printers.rs:98:16
[INFO] [stderr]    |
[INFO] [stderr] 98 |             if keys.len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 30.41s
[INFO] running `"docker" "inspect" "9d996bc6bf6887a70d0d051d5f7d8d9e29ed3b631754fc84c0cd6db9a36fe7ef"`
[INFO] running `"docker" "rm" "-f" "9d996bc6bf6887a70d0d051d5f7d8d9e29ed3b631754fc84c0cd6db9a36fe7ef"`
[INFO] [stdout] 9d996bc6bf6887a70d0d051d5f7d8d9e29ed3b631754fc84c0cd6db9a36fe7ef