[INFO] updating cached repository tchagnon/raylang-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tchagnon/raylang-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tchagnon/raylang-rust" "work/ex/clippy-test-run/sources/stable/gh/tchagnon/raylang-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tchagnon/raylang-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tchagnon/raylang-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tchagnon/raylang-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tchagnon/raylang-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a5a1bdcf0c7094e9c07d612eb69be7fa97ba5092 [INFO] sha for GitHub repo tchagnon/raylang-rust: a5a1bdcf0c7094e9c07d612eb69be7fa97ba5092 [INFO] validating manifest of tchagnon/raylang-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tchagnon/raylang-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tchagnon/raylang-rust [INFO] finished frobbing tchagnon/raylang-rust [INFO] frobbed toml for tchagnon/raylang-rust written to work/ex/clippy-test-run/sources/stable/gh/tchagnon/raylang-rust/Cargo.toml [INFO] started frobbing tchagnon/raylang-rust [INFO] finished frobbing tchagnon/raylang-rust [INFO] frobbed toml for tchagnon/raylang-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tchagnon/raylang-rust/Cargo.toml [INFO] crate tchagnon/raylang-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tchagnon/raylang-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tchagnon/raylang-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 38795263540f1827bccc61cc52ad6c3d0366318dd573fbef8fb8a884df232c37 [INFO] running `"docker" "start" "-a" "38795263540f1827bccc61cc52ad6c3d0366318dd573fbef8fb8a884df232c37"` [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking serde v1.0.10 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Compiling serde_derive v1.0.10 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking serde_yaml v0.7.1 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking raylang-rust v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | Vec3f {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | Vec3f {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | Vec3f {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | Vec4f {x: x, y: y, z: z, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | Vec4f {x: x, y: y, z: z, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:148:28 [INFO] [stderr] | [INFO] [stderr] 148 | Vec4f {x: x, y: y, z: z, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | Vec4f {x: x, y: y, z: z, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | Mat4f { r1: r1, r2: r2, r3: r3, r4: r4 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:231:25 [INFO] [stderr] | [INFO] [stderr] 231 | Mat4f { r1: r1, r2: r2, r3: r3, r4: r4 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:231:33 [INFO] [stderr] | [INFO] [stderr] 231 | Mat4f { r1: r1, r2: r2, r3: r3, r4: r4 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:231:41 [INFO] [stderr] | [INFO] [stderr] 231 | Mat4f { r1: r1, r2: r2, r3: r3, r4: r4 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/math.rs:267:17 [INFO] [stderr] | [INFO] [stderr] 267 | let (x, y, z) = (v.x, v.y, v.z); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/math.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | let (x, y, z) = (v.x, v.y, v.z); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | ab_pdet_ac: ab_pdet_ac, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ab_pdet_ac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | vertex_normals: vertex_normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | shading: shading, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `shading` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:211:17 [INFO] [stderr] | [INFO] [stderr] 211 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray_tracer.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | RayTracer { scene: scene } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scene` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ray_tracer.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | let (i, j) = (i as f32, j as f32); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ray_tracer.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let (w, h) = (scene.width as f32, scene.height as f32); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray_tracer.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | let ray = Ray { origin: origin, direction: d_jk }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | Vec3f {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | Vec3f {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | Vec3f {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | Vec4f {x: x, y: y, z: z, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | Vec4f {x: x, y: y, z: z, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:148:28 [INFO] [stderr] | [INFO] [stderr] 148 | Vec4f {x: x, y: y, z: z, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | Vec4f {x: x, y: y, z: z, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | Mat4f { r1: r1, r2: r2, r3: r3, r4: r4 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:231:25 [INFO] [stderr] | [INFO] [stderr] 231 | Mat4f { r1: r1, r2: r2, r3: r3, r4: r4 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:231:33 [INFO] [stderr] | [INFO] [stderr] 231 | Mat4f { r1: r1, r2: r2, r3: r3, r4: r4 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:231:41 [INFO] [stderr] | [INFO] [stderr] 231 | Mat4f { r1: r1, r2: r2, r3: r3, r4: r4 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/math.rs:267:17 [INFO] [stderr] | [INFO] [stderr] 267 | let (x, y, z) = (v.x, v.y, v.z); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/math.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | let (x, y, z) = (v.x, v.y, v.z); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | ab_pdet_ac: ab_pdet_ac, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ab_pdet_ac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | vertex_normals: vertex_normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | shading: shading, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `shading` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:211:17 [INFO] [stderr] | [INFO] [stderr] 211 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray_tracer.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | RayTracer { scene: scene } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scene` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ray_tracer.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | let (i, j) = (i as f32, j as f32); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ray_tracer.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let (w, h) = (scene.width as f32, scene.height as f32); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray_tracer.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | let ray = Ray { origin: origin, direction: d_jk }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math.rs:356:35 [INFO] [stderr] | [INFO] [stderr] 356 | assert_eq!(u.magnitude(), 3.7416575); [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.741_657_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math.rs:357:36 [INFO] [stderr] | [INFO] [stderr] 357 | assert_eq!(u.norm(), vec3f(0.26726124, 0.5345225, 0.8017837)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.267_261_24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math.rs:357:48 [INFO] [stderr] | [INFO] [stderr] 357 | assert_eq!(u.norm(), vec3f(0.26726124, 0.5345225, 0.8017837)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.534_522_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math.rs:357:59 [INFO] [stderr] | [INFO] [stderr] 357 | assert_eq!(u.norm(), vec3f(0.26726124, 0.5345225, 0.8017837)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.801_783_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math.rs:372:35 [INFO] [stderr] | [INFO] [stderr] 372 | assert_eq!(u.magnitude(), 5.477225575); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `5.477_225_575` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math.rs:373:36 [INFO] [stderr] | [INFO] [stderr] 373 | assert_eq!(u.norm(), vec4f(0.1825741858, 0.3651483717, 0.5477225575, 0.7302967433)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.182_574_185_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math.rs:373:50 [INFO] [stderr] | [INFO] [stderr] 373 | assert_eq!(u.norm(), vec4f(0.1825741858, 0.3651483717, 0.5477225575, 0.7302967433)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.365_148_371_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math.rs:373:64 [INFO] [stderr] | [INFO] [stderr] 373 | assert_eq!(u.norm(), vec4f(0.1825741858, 0.3651483717, 0.5477225575, 0.7302967433)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.547_722_557_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math.rs:373:78 [INFO] [stderr] | [INFO] [stderr] 373 | assert_eq!(u.norm(), vec4f(0.1825741858, 0.3651483717, 0.5477225575, 0.7302967433)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.730_296_743_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | assert_eq!(to_radians(360.0), consts::PI * 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | assert_eq!(to_radians(360.0), consts::PI * 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | assert_eq!(u.dot(v), 32.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | assert_eq!(u.dot(v), 32.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | assert_eq!(u.magnitude_squared(), 14.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | assert_eq!(u.magnitude_squared(), 14.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | assert_eq!(u.magnitude(), 3.7416575); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | assert_eq!(u.magnitude(), 3.7416575); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | assert_eq!(u.dot(v), 70.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | assert_eq!(u.dot(v), 70.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | assert_eq!(u.magnitude_squared(), 30.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | assert_eq!(u.magnitude_squared(), 30.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math.rs:372:35 [INFO] [stderr] | [INFO] [stderr] 372 | assert_eq!(u.magnitude(), 5.477225575); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `5.477_226` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math.rs:372:9 [INFO] [stderr] | [INFO] [stderr] 372 | assert_eq!(u.magnitude(), 5.477225575); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math.rs:372:9 [INFO] [stderr] | [INFO] [stderr] 372 | assert_eq!(u.magnitude(), 5.477225575); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math.rs:373:36 [INFO] [stderr] | [INFO] [stderr] 373 | assert_eq!(u.norm(), vec4f(0.1825741858, 0.3651483717, 0.5477225575, 0.7302967433)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.182_574_18` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math.rs:373:50 [INFO] [stderr] | [INFO] [stderr] 373 | assert_eq!(u.norm(), vec4f(0.1825741858, 0.3651483717, 0.5477225575, 0.7302967433)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.365_148_37` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math.rs:373:64 [INFO] [stderr] | [INFO] [stderr] 373 | assert_eq!(u.norm(), vec4f(0.1825741858, 0.3651483717, 0.5477225575, 0.7302967433)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.547_722_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math.rs:373:78 [INFO] [stderr] | [INFO] [stderr] 373 | assert_eq!(u.norm(), vec4f(0.1825741858, 0.3651483717, 0.5477225575, 0.7302967433)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.730_296_73` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: variable `A` should have a snake case name such as `a` [INFO] [stderr] --> src/math.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | let A = mat4f( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `B` should have a snake case name such as `b` [INFO] [stderr] --> src/math.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | let B = mat4f( [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `C` should have a snake case name such as `c` [INFO] [stderr] --> src/math.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | let C = mat4f( [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mesh.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | fn read(s: &String) -> Face { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mesh.rs:45:36 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn normal(&self, vertices: &Vec) -> Vec3f { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Vec3f]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mesh.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn prepare(&self, origin: &Vec3f, vertices: &Vec) -> Face { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Vec3f]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mesh.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | fn read_vertex(s: &String) -> Vec3f { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ray_tracer.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let ref scene = self.scene; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let scene = &self.scene;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ray_tracer.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let ref camera = scene.camera; [INFO] [stderr] | ----^^^^^^^^^^---------------- help: try: `let camera = &scene.camera;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ray_tracer.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let ref material = intx.material; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let material = &intx.material;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/ray_tracer.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | .expect(&format!("Unable to compare distances {} and {}", d1, d2)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to compare distances {} and {}", d1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bounding_box.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / if (t_near > t_far) || t_far < 0.0 { [INFO] [stderr] 24 | | false [INFO] [stderr] 25 | | } else { [INFO] [stderr] 26 | | true [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!((t_near > t_far) || t_far < 0.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bounding_box.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn from_vertices(vertices: &Vec) -> BoundingBox { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Vec3f]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bounding_box.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | fn vec3f_min_max(vs: &Vec, axis_fn: F) -> (f32, f32) [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Vec3f]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mesh.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | fn read(s: &String) -> Face { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mesh.rs:45:36 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn normal(&self, vertices: &Vec) -> Vec3f { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Vec3f]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mesh.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn prepare(&self, origin: &Vec3f, vertices: &Vec) -> Face { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Vec3f]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mesh.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | fn read_vertex(s: &String) -> Vec3f { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ray_tracer.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let ref scene = self.scene; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let scene = &self.scene;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ray_tracer.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let ref camera = scene.camera; [INFO] [stderr] | ----^^^^^^^^^^---------------- help: try: `let camera = &scene.camera;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ray_tracer.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let ref material = intx.material; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let material = &intx.material;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/ray_tracer.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | .expect(&format!("Unable to compare distances {} and {}", d1, d2)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to compare distances {} and {}", d1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:166:32 [INFO] [stderr] | [INFO] [stderr] 166 | transform: transform.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*transform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bounding_box.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / if (t_near > t_far) || t_far < 0.0 { [INFO] [stderr] 24 | | false [INFO] [stderr] 25 | | } else { [INFO] [stderr] 26 | | true [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!((t_near > t_far) || t_far < 0.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bounding_box.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn from_vertices(vertices: &Vec) -> BoundingBox { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Vec3f]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bounding_box.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | fn vec3f_min_max(vs: &Vec, axis_fn: F) -> (f32, f32) [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Vec3f]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | let json_str = CStr::from_ptr(json).to_str() [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:38:11 [INFO] [stderr] | [INFO] [stderr] 38 | (*scene).render(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | println!("Wrote file {:?}", (*scene).image); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `raylang-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:166:32 [INFO] [stderr] | [INFO] [stderr] 166 | transform: transform.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*transform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | let json_str = CStr::from_ptr(json).to_str() [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:38:11 [INFO] [stderr] | [INFO] [stderr] 38 | (*scene).render(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | println!("Wrote file {:?}", (*scene).image); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `raylang-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "38795263540f1827bccc61cc52ad6c3d0366318dd573fbef8fb8a884df232c37"` [INFO] running `"docker" "rm" "-f" "38795263540f1827bccc61cc52ad6c3d0366318dd573fbef8fb8a884df232c37"` [INFO] [stdout] 38795263540f1827bccc61cc52ad6c3d0366318dd573fbef8fb8a884df232c37