[INFO] updating cached repository tbo/rust-mongodb-queryserver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tbo/rust-mongodb-queryserver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tbo/rust-mongodb-queryserver" "work/ex/clippy-test-run/sources/stable/gh/tbo/rust-mongodb-queryserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tbo/rust-mongodb-queryserver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tbo/rust-mongodb-queryserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tbo/rust-mongodb-queryserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tbo/rust-mongodb-queryserver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aa16905ac40c5074d15f1418c6afe169c6fb2ffa [INFO] sha for GitHub repo tbo/rust-mongodb-queryserver: aa16905ac40c5074d15f1418c6afe169c6fb2ffa [INFO] validating manifest of tbo/rust-mongodb-queryserver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tbo/rust-mongodb-queryserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tbo/rust-mongodb-queryserver [INFO] finished frobbing tbo/rust-mongodb-queryserver [INFO] frobbed toml for tbo/rust-mongodb-queryserver written to work/ex/clippy-test-run/sources/stable/gh/tbo/rust-mongodb-queryserver/Cargo.toml [INFO] started frobbing tbo/rust-mongodb-queryserver [INFO] finished frobbing tbo/rust-mongodb-queryserver [INFO] frobbed toml for tbo/rust-mongodb-queryserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tbo/rust-mongodb-queryserver/Cargo.toml [INFO] crate tbo/rust-mongodb-queryserver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tbo/rust-mongodb-queryserver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tbo/rust-mongodb-queryserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78b4b4ea308f88a4ee2e6a12096d6a8840f48bc7f6a601e6c6533cc7a95869ea [INFO] running `"docker" "start" "-a" "78b4b4ea308f88a4ee2e6a12096d6a8840f48bc7f6a601e6c6533cc7a95869ea"` [INFO] [stderr] Checking libc v0.2.31 [INFO] [stderr] Checking futures v0.1.16 [INFO] [stderr] Checking serde v1.0.18 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking separator v0.3.1 [INFO] [stderr] Checking scan_fmt v0.1.1 [INFO] [stderr] Checking data-encoding v1.2.0 [INFO] [stderr] Checking bitflags v1.0.0 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking semver v0.8.0 [INFO] [stderr] Compiling serde_derive v1.0.18 [INFO] [stderr] Checking mime v0.3.4 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking num_cpus v1.7.0 [INFO] [stderr] Checking hostname v0.1.3 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking tokio-io v0.1.3 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking futures-cpupool v0.1.6 [INFO] [stderr] Checking relay v0.1.0 [INFO] [stderr] Checking tokio-core v0.1.9 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking pretty_env_logger v0.1.1 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking serde_json v1.0.5 [INFO] [stderr] Checking textnonce v0.6.3 [INFO] [stderr] Checking hyper v0.11.6 [INFO] [stderr] Checking bson v0.10.0 [INFO] [stderr] Checking mongodb v0.3.7 [INFO] [stderr] Checking queryserver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / return futures::future::ok( [INFO] [stderr] 69 | | Response::new() [INFO] [stderr] 70 | | .with_header(ContentLength(output.len() as u64)) [INFO] [stderr] 71 | | .with_body(output) [INFO] [stderr] 72 | | ) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 68 | futures::future::ok( [INFO] [stderr] 69 | Response::new() [INFO] [stderr] 70 | .with_header(ContentLength(output.len() as u64)) [INFO] [stderr] 71 | .with_body(output) [INFO] [stderr] 72 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | Err(_) => return get_failure_response(StatusCode::InternalServerError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_failure_response(StatusCode::InternalServerError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return default [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `default` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | return db; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / return futures::future::ok( [INFO] [stderr] 69 | | Response::new() [INFO] [stderr] 70 | | .with_header(ContentLength(output.len() as u64)) [INFO] [stderr] 71 | | .with_body(output) [INFO] [stderr] 72 | | ) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 68 | futures::future::ok( [INFO] [stderr] 69 | Response::new() [INFO] [stderr] 70 | .with_header(ContentLength(output.len() as u64)) [INFO] [stderr] 71 | .with_body(output) [INFO] [stderr] 72 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | Err(_) => return get_failure_response(StatusCode::InternalServerError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_failure_response(StatusCode::InternalServerError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return default [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `default` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | return db; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match db.auth(username, config.value_of("password").unwrap_or("")) { [INFO] [stderr] 168 | | Err(_) => { [INFO] [stderr] 169 | | println!("Failed to authenticate"); [INFO] [stderr] 170 | | process::exit(0x0100) [INFO] [stderr] 171 | | }, [INFO] [stderr] 172 | | Ok(_) => () [INFO] [stderr] 173 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | if let Err(_) = db.auth(username, config.value_of("password").unwrap_or("")) { [INFO] [stderr] 168 | println!("Failed to authenticate"); [INFO] [stderr] 169 | process::exit(0x0100) [INFO] [stderr] 170 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match db.auth(username, config.value_of("password").unwrap_or("")) { [INFO] [stderr] 168 | | Err(_) => { [INFO] [stderr] 169 | | println!("Failed to authenticate"); [INFO] [stderr] 170 | | process::exit(0x0100) [INFO] [stderr] 171 | | }, [INFO] [stderr] 172 | | Ok(_) => () [INFO] [stderr] 173 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | if let Err(_) = db.auth(username, config.value_of("password").unwrap_or("")) { [INFO] [stderr] 168 | println!("Failed to authenticate"); [INFO] [stderr] 169 | process::exit(0x0100) [INFO] [stderr] 170 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.07s [INFO] running `"docker" "inspect" "78b4b4ea308f88a4ee2e6a12096d6a8840f48bc7f6a601e6c6533cc7a95869ea"` [INFO] running `"docker" "rm" "-f" "78b4b4ea308f88a4ee2e6a12096d6a8840f48bc7f6a601e6c6533cc7a95869ea"` [INFO] [stdout] 78b4b4ea308f88a4ee2e6a12096d6a8840f48bc7f6a601e6c6533cc7a95869ea