[INFO] updating cached repository tatref/synacor-challenge [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tatref/synacor-challenge [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tatref/synacor-challenge" "work/ex/clippy-test-run/sources/stable/gh/tatref/synacor-challenge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tatref/synacor-challenge'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tatref/synacor-challenge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tatref/synacor-challenge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tatref/synacor-challenge'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6261bbf2ceeacf6397f12e34fd9fdf13039791f1 [INFO] sha for GitHub repo tatref/synacor-challenge: 6261bbf2ceeacf6397f12e34fd9fdf13039791f1 [INFO] validating manifest of tatref/synacor-challenge on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tatref/synacor-challenge on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tatref/synacor-challenge [INFO] finished frobbing tatref/synacor-challenge [INFO] frobbed toml for tatref/synacor-challenge written to work/ex/clippy-test-run/sources/stable/gh/tatref/synacor-challenge/Cargo.toml [INFO] started frobbing tatref/synacor-challenge [INFO] finished frobbing tatref/synacor-challenge [INFO] frobbed toml for tatref/synacor-challenge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tatref/synacor-challenge/Cargo.toml [INFO] crate tatref/synacor-challenge has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting tatref/synacor-challenge against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tatref/synacor-challenge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3c9f36041f60527b4208e7d846ac93b7ebc64bb935d6ce06da712670a0a5a3ae [INFO] running `"docker" "start" "-a" "3c9f36041f60527b4208e7d846ac93b7ebc64bb935d6ce06da712670a0a5a3ae"` [INFO] [stderr] Checking utf8parse v0.1.1 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking rustyline v2.1.0 [INFO] [stderr] Checking synacor-challenge v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | things [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | let things = things_str.lines() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 85 | | .skip(1) [INFO] [stderr] 86 | | .map(|line| line.get(2..).unwrap().to_string()) [INFO] [stderr] 87 | | .collect::>(); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | exits [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:99:29 [INFO] [stderr] | [INFO] [stderr] 99 | let exits = exits_str.lines() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 100 | | .skip(1) [INFO] [stderr] 101 | | .map(|line| line.get(2..).unwrap().to_string()) [INFO] [stderr] 102 | | .collect::>(); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:659:62 [INFO] [stderr] | [INFO] [stderr] 659 | .map_err( |e| { println!("Unknown command"); () })?; [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | things [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | let things = things_str.lines() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 85 | | .skip(1) [INFO] [stderr] 86 | | .map(|line| line.get(2..).unwrap().to_string()) [INFO] [stderr] 87 | | .collect::>(); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | exits [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:99:29 [INFO] [stderr] | [INFO] [stderr] 99 | let exits = exits_str.lines() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 100 | | .skip(1) [INFO] [stderr] 101 | | .map(|line| line.get(2..).unwrap().to_string()) [INFO] [stderr] 102 | | .collect::>(); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:659:62 [INFO] [stderr] | [INFO] [stderr] 659 | .map_err( |e| { println!("Unknown command"); () })?; [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/main.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | vm.load_program_from_mem(program); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | expected &[u16], found struct `std::vec::Vec` [INFO] [stderr] | help: consider borrowing here: `&program` [INFO] [stderr] | [INFO] [stderr] = note: expected type `&[u16]` [INFO] [stderr] found type `std::vec::Vec<{integer}>` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `synacor-challenge`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:251:28 [INFO] [stderr] | [INFO] [stderr] 251 | let pair = x.iter().map(|x| *x).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `x.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data` [INFO] [stderr] --> src/main.rs:260:18 [INFO] [stderr] | [INFO] [stderr] 260 | for i in 0..data.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 260 | for (i, ) in data.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:260:18 [INFO] [stderr] | [INFO] [stderr] 260 | for i in 0..data.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[..data.len()].clone_from_slice(&data[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `program` [INFO] [stderr] --> src/main.rs:268:18 [INFO] [stderr] | [INFO] [stderr] 268 | for i in 0..program.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 268 | for (i, ) in program.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:268:18 [INFO] [stderr] | [INFO] [stderr] 268 | for i in 0..program.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[..program.len()].clone_from_slice(&program[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:684:21 [INFO] [stderr] | [INFO] [stderr] 684 | self.app.print_long_help(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "3c9f36041f60527b4208e7d846ac93b7ebc64bb935d6ce06da712670a0a5a3ae"` [INFO] running `"docker" "rm" "-f" "3c9f36041f60527b4208e7d846ac93b7ebc64bb935d6ce06da712670a0a5a3ae"` [INFO] [stdout] 3c9f36041f60527b4208e7d846ac93b7ebc64bb935d6ce06da712670a0a5a3ae